Improve detection for outdated standalone CLI versions. (#7885)

Author: yuchenshi

firebase-vscode/src/extension.ts

@@ -1,5 +1,5 @@
 import * as vscode from "vscode";
-import { spawnSync } from 'child_process';
+import { spawnSync } from "child_process";
 import * as semver from "semver";
 
 import { ExtensionBroker } from "./extension-broker";
@@ -83,30 +83,40 @@ async function checkCLIInstallation(): Promise<void> {
   let message = "";
   try {
     // Fetch directly so that we don't need to rely on any tools being presnt on path.
-    const latestVersionRes = await fetch("https://registry.npmjs.org/firebase-tools");
-    const latestVersion = (await latestVersionRes.json())?.["dist-tags"]?.["latest"];
-    const env = { ...process.env, "VSCODE_CWD":"" }
+    const latestVersionRes = await fetch(
+      "https://registry.npmjs.org/firebase-tools",
+    );
+    const latestVersion = (await latestVersionRes.json())?.["dist-tags"]?.[
+      "latest"
+    ];
+    const env = { ...process.env, VSCODE_CWD: "" };
     const versionRes = spawnSync("firebase", ["--version"], { env });
-    const currentVersion = semver.valid(versionRes.stdout?.toString())
-    const npmVersionRes = spawnSync("npm", ["--version"])
-    const npmVersion = semver.valid(npmVersionRes.stdout?.toString())
+    const currentVersion = semver.valid(versionRes.stdout?.toString());
+    const npmVersionRes = spawnSync("npm", ["--version"]);
+    const npmVersion = semver.valid(npmVersionRes.stdout?.toString());
     if (!currentVersion) {
       message = `The Firebase CLI is not installed (or not available on $PATH). If you would like to install it, run ${
         npmVersion
           ? "npm install -g firebase-tools"
           : "curl -sL https://firebase.tools | bash"
-      }`
+      }`;
     } else if (semver.lt(currentVersion, latestVersion)) {
-       message = `There is an outdated version of the Firebase CLI installed on your system. We recommened updating to the latest verion by running ${
-        npmVersion
-        ? "npm install -g firebase-tools"
-        : "curl -sL https://firebase.tools | upgrade=true bash"
-       }`
+      let installCommand =
+        "curl -sL https://firebase.tools | upgrade=true bash";
+      if (npmVersion) {
+        // Despite the presence of npm, the existing command may be standalone.
+        // Run a special standalone-specific command to tell if it actually is.
+        const checkRes = spawnSync("firebase", ["--tool:setup-check"], { env });
+        if (checkRes.status !== 0) {
+          installCommand = "npm install -g firebase-tools@latest";
+        }
+      }
+      message = `There is an outdated version of the Firebase CLI installed on your system. We recommened updating to the latest verion by running ${installCommand}`;
     } else {
       pluginLogger.info(`Checked firebase-tools, is up to date!`);
     }
-   } catch(err: any) {
-    pluginLogger.info(`Unable to check firebase-tools installation: ${err}`)
+  } catch (err: any) {
+    pluginLogger.info(`Unable to check firebase-tools installation: ${err}`);
   }
 
   if (message) {