fix: Make test_cmp_full_and_first_diff_mem not cmp file to itself

The Microvm.snapshot_*() functions by default always write the snapshot
to the same file system location. This means that full_snapshot.mem and
diff_snapshot.mem point to the same path, making the final assert in the
test trivially true (as a file is the same as itself - the diff snapshot
will have overwritten the full snapshot). The fix is to use a different
path for the full snapshot.

Signed-off-by: Patrick Roy <[email protected]>

Author: roypat

tests/integration_tests/functional/test_snapshot_basic.py

@@ -257,13 +257,14 @@ def test_cmp_full_and_first_diff_mem(microvm_factory, guest_kernel, rootfs):
 
     logger.info("Create full snapshot.")
     # Create full snapshot.
-    full_snapshot = vm.snapshot_full()
+    full_snapshot = vm.snapshot_full(mem_path="mem_full")
 
     logger.info("Create diff snapshot.")
     # Create diff snapshot.
     diff_snapshot = vm.snapshot_diff()
 
-    assert filecmp.cmp(full_snapshot.mem, diff_snapshot.mem)
+    assert full_snapshot.mem != diff_snapshot.mem
+    assert filecmp.cmp(full_snapshot.mem, diff_snapshot.mem, shallow=False)
 
 
 def test_negative_postload_api(test_microvm_with_api, microvm_factory):