Skip to content

Commit 2d772c8

Browse files
committed
Flip equals statements in converter implementations to prevent NPE
1 parent 0b7366e commit 2d772c8

File tree

6 files changed

+14
-14
lines changed

6 files changed

+14
-14
lines changed

mod-erm-usage-counter50/src/main/java/org/olf/erm/usage/counter50/converter/dr/DRD1Converter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public class DRD1Converter extends DRConverterBase {
2828

2929
private static final Predicate<COUNTERDatabaseUsage> filter =
3030
u ->
31-
u.getAccessMethod().equals(AccessMethodEnum.REGULAR)
31+
AccessMethodEnum.REGULAR.equals(u.getAccessMethod())
3232
&& u.getPerformance().stream()
3333
.anyMatch(p -> p.getInstance().stream().anyMatch(hasMetricType));
3434

mod-erm-usage-counter50/src/main/java/org/olf/erm/usage/counter50/converter/tr/TRB1Converter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ public class TRB1Converter extends TRConverterBase {
2626

2727
private static final Predicate<COUNTERTitleUsage> filter =
2828
u ->
29-
u.getDataType().equals(DataTypeEnum.BOOK)
30-
&& u.getAccessMethod().equals(AccessMethodEnum.REGULAR)
31-
&& u.getAccessType().equals(AccessTypeEnum.CONTROLLED)
29+
DataTypeEnum.BOOK.equals(u.getDataType())
30+
&& AccessMethodEnum.REGULAR.equals(u.getAccessMethod())
31+
&& AccessTypeEnum.CONTROLLED.equals(u.getAccessType())
3232
&& u.getPerformance().stream()
3333
.anyMatch(p -> p.getInstance().stream().anyMatch(hasMetricType));
3434

mod-erm-usage-counter50/src/main/java/org/olf/erm/usage/counter50/converter/tr/TRB3Converter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ public class TRB3Converter extends TRConverterBase {
3131

3232
private static final Predicate<COUNTERTitleUsage> filter =
3333
u ->
34-
u.getDataType().equals(DataTypeEnum.BOOK)
35-
&& u.getAccessMethod().equals(AccessMethodEnum.REGULAR)
34+
DataTypeEnum.BOOK.equals(u.getDataType())
35+
&& AccessMethodEnum.REGULAR.equals(u.getAccessMethod())
3636
&& u.getPerformance().stream()
3737
.anyMatch(p -> p.getInstance().stream().anyMatch(hasMetricType));
3838

mod-erm-usage-counter50/src/main/java/org/olf/erm/usage/counter50/converter/tr/TRJ1Converter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ public class TRJ1Converter extends TRConverterBase {
2626

2727
private static final Predicate<COUNTERTitleUsage> filter =
2828
u ->
29-
u.getDataType().equals(DataTypeEnum.JOURNAL)
30-
&& u.getAccessMethod().equals(AccessMethodEnum.REGULAR)
31-
&& u.getAccessType().equals(AccessTypeEnum.CONTROLLED)
29+
DataTypeEnum.JOURNAL.equals(u.getDataType())
30+
&& AccessMethodEnum.REGULAR.equals(u.getAccessMethod())
31+
&& AccessTypeEnum.CONTROLLED.equals(u.getAccessType())
3232
&& u.getPerformance().stream()
3333
.anyMatch(p -> p.getInstance().stream().anyMatch(hasMetricType));
3434

mod-erm-usage-counter50/src/main/java/org/olf/erm/usage/counter50/converter/tr/TRJ3Converter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ public class TRJ3Converter extends TRConverterBase {
3030

3131
private static final Predicate<COUNTERTitleUsage> filter =
3232
u ->
33-
u.getDataType().equals(DataTypeEnum.JOURNAL)
34-
&& u.getAccessMethod().equals(AccessMethodEnum.REGULAR)
33+
DataTypeEnum.JOURNAL.equals(u.getDataType())
34+
&& AccessMethodEnum.REGULAR.equals(u.getAccessMethod())
3535
&& u.getPerformance().stream()
3636
.anyMatch(p -> p.getInstance().stream().anyMatch(hasMetricType));
3737

mod-erm-usage-counter50/src/main/java/org/olf/erm/usage/counter50/converter/tr/TRJ4Converter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ public class TRJ4Converter extends TRConverterBase {
2727

2828
private static final Predicate<COUNTERTitleUsage> filter =
2929
u ->
30-
u.getDataType().equals(DataTypeEnum.JOURNAL)
31-
&& u.getAccessMethod().equals(AccessMethodEnum.REGULAR)
32-
&& u.getAccessType().equals(AccessTypeEnum.CONTROLLED)
30+
DataTypeEnum.JOURNAL.equals(u.getDataType())
31+
&& AccessMethodEnum.REGULAR.equals(u.getAccessMethod())
32+
&& AccessTypeEnum.CONTROLLED.equals(u.getAccessType())
3333
&& u.getPerformance().stream()
3434
.anyMatch(p -> p.getInstance().stream().anyMatch(hasMetricType));
3535

0 commit comments

Comments
 (0)