fix(theme): variable inheritance without default imported twice

This PR should finally fix proper variable inheritance without scoping and without overriding/double importing the default files twice.
This is solved by simply pointing the theme value to a non existing path in case it's default, because the default path is always imported anyway.

Another workaround would have been to just replace 'default' for each component inside theme.config by an empty string, but as theme.config is a custom file, nobody would have updated it for the next release.
I wanted this to be backward compatible, so i replaced the variable on the fly.

However, by using any LESS function to declare a variable (i tried replace/if/when/e/%), the access breaks when trying to use such variable via @{theme} inside mixins (which are scoped). :(
Even trying to trick it by using %('%s',@theme) instead of the string path did not work and resulted into "malformed import statement instead"
That said ( and even if this could be considered a bug in LESS), to solve all those issues, i just replaced the mixin call by importing another overrides.less file instead, which now isn't scoped anymore, so the import using the theme-variable also works there as well

Just in case somebody has made own custom components i left the loadUIOverrides mixin, but replaced the content by a comment warning so it's not a breaking change and people know what to do.

Author: lubber-de

src/definitions/collections/breadcrumb.less

@@ -115,4 +115,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/collections/form.less

@@ -1160,4 +1160,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/collections/grid.less

@@ -1981,4 +1981,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/collections/menu.less

@@ -2011,4 +2011,5 @@ Floated Menu / Item
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/collections/message.less

@@ -442,4 +442,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/collections/table.less

@@ -1929,4 +1929,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/button.less

@@ -2005,4 +2005,6 @@
         }
     }
 }
-.loadUIOverrides();
+
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/container.less

@@ -294,4 +294,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/divider.less

@@ -282,4 +282,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/emoji.less

@@ -91,4 +91,5 @@ each(@emoji-map, {
 
 /* rtl:end:ignore */
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/flag.less

@@ -83,4 +83,5 @@ each(@flags, {
 
 /* rtl:end:ignore */
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/header.less

@@ -490,4 +490,5 @@
     font-size: @mediumFontSize;
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/icon.less

@@ -655,4 +655,5 @@ i.icons {
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/image.less

@@ -307,4 +307,5 @@ img.ui.image {
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/input.less

@@ -791,4 +791,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/label.less

@@ -1011,4 +1011,5 @@ a.ui.active.label:hover::before {
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/list.less

@@ -1023,4 +1023,5 @@ ol.ui.list ol li,
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/loader.less

@@ -423,4 +423,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/placeholder.less

@@ -248,4 +248,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/rail.less

@@ -144,4 +144,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/reveal.less

@@ -280,4 +280,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/segment.less

@@ -934,4 +934,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/step.less

@@ -617,4 +617,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/elements/text.less

@@ -71,4 +71,5 @@ span.ui.medium.text {
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/globals/reset.less

@@ -40,4 +40,5 @@ input[type="password"] {
     -moz-appearance: none; /* mobile firefox too! */
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/globals/site.less

@@ -207,4 +207,5 @@ input::selection {
     color: @inputHighlightColor;
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/accordion.less

@@ -364,4 +364,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/calendar.less

@@ -215,4 +215,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/checkbox.less

@@ -696,4 +696,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/dimmer.less

@@ -390,4 +390,5 @@ body.dimmable > .dimmer {
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/dropdown.less

@@ -1951,4 +1951,5 @@ select.ui.dropdown {
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/embed.less

@@ -155,4 +155,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/flyout.less

@@ -645,4 +645,5 @@ body.pushable > .pusher {
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/modal.less

@@ -620,4 +620,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/nag.less

@@ -207,4 +207,6 @@ a.ui.nag {
         border-radius: @borderRadius;
     }
 }
-.loadUIOverrides();
+
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/popup.less

@@ -928,4 +928,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/progress.less

@@ -650,4 +650,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/rating.less

@@ -177,4 +177,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/search.less

@@ -553,4 +553,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/shape.less

@@ -143,4 +143,5 @@
     display: block;
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/sidebar.less

@@ -667,4 +667,5 @@ body.pushable > .pusher {
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/slider.less

@@ -426,4 +426,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/sticky.less

@@ -65,4 +65,5 @@
     position: sticky;
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/tab.less

@@ -82,4 +82,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/toast.less

@@ -714,4 +714,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/modules/transition.less

@@ -113,4 +113,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/views/ad.less

@@ -293,4 +293,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/views/card.less

@@ -1178,4 +1178,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/views/comment.less

@@ -291,4 +291,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/views/feed.less

@@ -317,4 +317,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/views/item.less

@@ -598,4 +598,5 @@
     }
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/definitions/views/statistic.less

@@ -414,4 +414,5 @@
     });
 }
 
-.loadUIOverrides();
+// stylelint-disable no-invalid-position-at-import-rule
+@import (multiple, optional) "../../overrides.less";

src/overrides.less

@@ -0,0 +1,7 @@
+// ------------------
+//     Overrides
+// -------------------
+
+@import (optional) "@{themesFolder}/default/@{type}s/@{element}.overrides";
+@import (optional) "@{themesFolder}/@{theme}/@{type}s/@{element}.overrides";
+@import (optional) "@{siteFolder}/@{type}s/@{element}.overrides";

src/theme.less

@@ -6,7 +6,7 @@
        Theme
 ------------------- */
 
-@theme: @@element;
+@theme: if(@@element = "default", "", @@element);
 
 /* --------------------
    Site Variables
@@ -80,10 +80,11 @@
      Overrides
 ------------------- */
 
+// Keep empty mixin in case of custom components using it so they dont break
 .loadUIOverrides() {
-    & when not (@theme = "default") {
-        @import (optional) "@{themesFolder}/default/@{type}s/@{element}.overrides";
-    }
-    @import (optional) "@{themesFolder}/@{theme}/@{type}s/@{element}.overrides";
-    @import (optional) "@{siteFolder}/@{type}s/@{element}.overrides";
+    /* loadUIOverrides mixin is deprecated and will be removed in 2.10.0
+       Replace mixin call by
+          @import (multiple, optional) "../../overrides.less";
+       instead
+    */
 }