Fix eth_signTransaction request and response

Author: alisinabh

crates/anvil/core/src/eth/mod.rs

@@ -142,7 +142,7 @@ pub enum EthRequest {
     #[cfg_attr(feature = "serde", serde(rename = "eth_sign", alias = "personal_sign"))]
     EthSign(Address, Bytes),
 
-    #[cfg_attr(feature = "serde", serde(rename = "eth_signTransaction"))]
+    #[cfg_attr(feature = "serde", serde(rename = "eth_signTransaction", with = "sequence"))]
     EthSignTransaction(Box<WithOtherFields<TransactionRequest>>),
 
     /// Signs data via [EIP-712](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-712.md).

crates/anvil/src/eth/api.rs

@@ -32,6 +32,7 @@ use crate::{
     ClientFork, LoggingManager, Miner, MiningMode, StorageInfo,
 };
 use alloy_dyn_abi::TypedData;
+use alloy_eips::eip2718::Encodable2718;
 use alloy_network::eip2718::Decodable2718;
 use alloy_primitives::{Address, Bytes, TxHash, TxKind, B256, B64, U256, U64};
 use alloy_rpc_types::{
@@ -862,10 +863,9 @@ impl EthApi {
 
         let request = self.build_typed_tx_request(request, nonce)?;
 
-        let signer = self.get_signer(from).ok_or(BlockchainError::NoSignerAvailable)?;
-        let signature =
-            alloy_primitives::hex::encode(signer.sign_transaction(request, &from)?.as_bytes());
-        Ok(format!("0x{signature}"))
+        let signed_transaction =
+            alloy_primitives::hex::encode(self.sign_request(&from, request)?.encoded_2718());
+        Ok(format!("0x{signed_transaction}"))
     }
 
     /// Sends a transaction

crates/anvil/tests/it/sign.rs

@@ -282,6 +282,24 @@ async fn can_sign_typed_data_os() {
     );
 }
 
+#[tokio::test(flavor = "multi_thread")]
+async fn can_sign_transaction() {
+    let (api, handle) = spawn(NodeConfig::test()).await;
+
+    let accounts = handle.dev_wallets().collect::<Vec<_>>();
+    let from = accounts[0].address();
+    let to = accounts[1].address();
+
+    // craft the tx
+    // specify the `from` field so that the client knows which account to use
+    let tx = TransactionRequest::default().to(to).value(U256::from(1001u64)).from(from);
+    let tx = WithOtherFields::new(tx);
+    // broadcast it via the eth_sendTransaction API
+    let signed_tx = api.sign_transaction(tx).await.unwrap();
+
+    assert_eq!(signed_tx, "0x02f86c827a69808084773594008252089470997970c51812dc3a010c7d01b50e0d17dc79c88203e980c082f4f6a05b8c3e67a3cecdad35d8be49df75c6bb07f720dbd9742a4240d3cdee97653e36a02c946c4a6ce6e66803ff22af7b7d1c39307339ca122fa16a0ef63ace382e8d56");
+}
+
 #[tokio::test(flavor = "multi_thread")]
 async fn rejects_different_chain_id() {
     let (_api, handle) = spawn(NodeConfig::test()).await;