Skip to content

fix(gatsby-plugin-sharp): honor stripMetadata setting for webp output images #20860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2020
Merged

fix(gatsby-plugin-sharp): honor stripMetadata setting for webp output images #20860

merged 1 commit into from
Jan 27, 2020

Conversation

rajatsharma
Copy link
Contributor

Fixes #20709

@rajatsharma rajatsharma marked this pull request as ready for review January 25, 2020 07:19
@rajatsharma rajatsharma requested a review from a team as a code owner January 25, 2020 07:19
@pieh pieh self-assigned this Jan 27, 2020
@pieh pieh changed the title Setting metadata option of imagemin-webp as per gatsby-plugin-sharp o… fix(gatsby-plugin-sharp): honor stripMetadata setting for webp output images Jan 27, 2020
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and this indeed allow to keep metadata. Thanks!

@pieh pieh merged commit b1e328a into gatsbyjs:master Jan 27, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 27, 2020

Holy buckets, @rajatsharma — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@pieh
Copy link
Contributor

pieh commented Jan 27, 2020

Published [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-sharp: "stripMetadata": false option does not work with webp
2 participants