4422: Remove sleeper.compaction.repo property replaced with sleeper.e… #4668
Conversation
…cr.repository.prefix
…r.repository.prefix
… sleeper.repository.prefix
…to core and add javadoc
…o core DockerImageConfiguration
| return Stream.of(ECR_COMPACTION_REPO, ECR_INGEST_REPO, | ||
| BULK_EXPORT_ECR_REPO, BULK_IMPORT_REPO, BULK_IMPORT_EMR_SERVERLESS_CUSTOM_IMAGE_REPO) | ||
| return Stream.of(ECR_REPOSITORY_PREFIX, | ||
| BULK_EXPORT_ECR_REPO) |
There was a problem hiding this comment.
I'm not sure if this is the right behaviour for this method. Currently this method returns the names of ECR repositories that are set for the instance, including the prefix. Usually that will just be all the repositories. Previously, it was possible that some of those repositories could be not set at all in the instance properties, and in that case it wouldn't use them.
This is used to delete the repositories by their name. It probably makes sense to still look for all of the repositories.
I was wondering if we should model whether we expect the repositories to exist for the instance, but we probably still want to check if the repositories exist anyway, and we also want to delete this code completely soon and move the behaviour into the CDK.
There was a problem hiding this comment.
I think this needs changing to compute all the repository names.
…cr.repository.prefix
Make sure you have checked all steps below.
Issue
PR"
Tests
Documentation
separate issue for that below.