Skip to content

Commit 5ae2a82

Browse files
authored
Techdebt: Refactor request-handling AWSLambda (#7631)
1 parent b8d55d6 commit 5ae2a82

File tree

5 files changed

+177
-416
lines changed

5 files changed

+177
-416
lines changed

moto/awslambda/models.py

+10-10
Original file line numberDiff line numberDiff line change
@@ -739,7 +739,7 @@ def _get_layers_data(self, layers_versions_arns: List[str]) -> List[LayerDataTyp
739739
{"Arn": lv.arn, "CodeSize": lv.code_size} for lv in layer_versions if lv
740740
]
741741

742-
def get_code_signing_config(self) -> Dict[str, Any]:
742+
def get_function_code_signing_config(self) -> Dict[str, Any]:
743743
return {
744744
"CodeSigningConfigArn": self.code_signing_config_arn,
745745
"FunctionName": self.function_name,
@@ -1408,7 +1408,7 @@ def create_from_cloudformation_json( # type: ignore[misc]
14081408
) -> "LambdaVersion":
14091409
properties = cloudformation_json["Properties"]
14101410
function_name = properties["FunctionName"]
1411-
func = lambda_backends[account_id][region_name].publish_function(function_name)
1411+
func = lambda_backends[account_id][region_name].publish_version(function_name)
14121412
spec = {"Version": func.version} # type: ignore[union-attr]
14131413
return LambdaVersion(spec)
14141414

@@ -1662,7 +1662,7 @@ def put_function(self, fn: LambdaFunction) -> None:
16621662
self._functions[fn.function_name] = {"latest": fn, "versions": []}
16631663
self._arns[fn.function_arn] = fn
16641664

1665-
def publish_function(
1665+
def publish_version(
16661666
self, name_or_arn: str, description: str = ""
16671667
) -> Optional[LambdaFunction]:
16681668
function = self.get_function_by_name_or_arn_forbid_qualifier(name_or_arn)
@@ -1944,7 +1944,7 @@ def create_function(self, spec: Dict[str, Any]) -> LambdaFunction:
19441944
self._lambdas.put_function(fn)
19451945

19461946
if spec.get("Publish"):
1947-
ver = self.publish_function(function_name)
1947+
ver = self.publish_version(function_name)
19481948
fn = copy.deepcopy(
19491949
fn
19501950
) # We don't want to change the actual version - just the return value
@@ -2068,16 +2068,16 @@ def delete_layer_version(self, layer_name: str, layer_version: str) -> None:
20682068
def get_layer_version(self, layer_name: str, layer_version: str) -> LayerVersion:
20692069
return self._layers.get_layer_version(layer_name, layer_version)
20702070

2071-
def get_layer_versions(self, layer_name: str) -> Iterable[LayerVersion]:
2071+
def list_layer_versions(self, layer_name: str) -> Iterable[LayerVersion]:
20722072
return self._layers.get_layer_versions(layer_name)
20732073

20742074
def layers_versions_by_arn(self, layer_version_arn: str) -> Optional[LayerVersion]:
20752075
return self._layers.get_layer_version_by_arn(layer_version_arn)
20762076

2077-
def publish_function(
2077+
def publish_version(
20782078
self, function_name: str, description: str = ""
20792079
) -> Optional[LambdaFunction]:
2080-
return self._lambdas.publish_function(function_name, description)
2080+
return self._lambdas.publish_version(function_name, description)
20812081

20822082
def get_function(
20832083
self, function_name_or_arn: str, qualifier: Optional[str] = None
@@ -2337,9 +2337,9 @@ def remove_permission(
23372337
fn = self.get_function(function_name)
23382338
fn.policy.del_statement(sid, revision)
23392339

2340-
def get_code_signing_config(self, function_name: str) -> Dict[str, Any]:
2340+
def get_function_code_signing_config(self, function_name: str) -> Dict[str, Any]:
23412341
fn = self.get_function(function_name)
2342-
return fn.get_code_signing_config()
2342+
return fn.get_function_code_signing_config()
23432343

23442344
def get_policy(self, function_name: str, qualifier: Optional[str] = None) -> str:
23452345
fn = self._lambdas.get_function_by_name_or_arn_with_qualifier(
@@ -2354,7 +2354,7 @@ def update_function_code(
23542354
fn.update_function_code(body)
23552355

23562356
if body.get("Publish", False):
2357-
fn = self.publish_function(function_name) # type: ignore[assignment]
2357+
fn = self.publish_version(function_name) # type: ignore[assignment]
23582358

23592359
return fn.update_function_code(body)
23602360

0 commit comments

Comments
 (0)