ref(eslint): Set no-unsafe-assignment & no-unsage-argument to error (#919)

Author: Lms24

.eslintrc.js

@@ -59,11 +59,10 @@ module.exports = {
     '@typescript-eslint/no-unsafe-call': 'error',
     '@typescript-eslint/restrict-template-expressions': 'error',
     '@typescript-eslint/no-unsafe-member-access': 'error',
-    '@typescript-eslint/no-unsafe-assignment': 'warn',
-    '@typescript-eslint/no-unsafe-argument': 'warn',
+    '@typescript-eslint/no-unsafe-assignment': 'error',
+    '@typescript-eslint/no-unsafe-argument': 'error',
     '@typescript-eslint/no-unsafe-return': 'error',
     '@typescript-eslint/no-var-requires': 'error',
-    // '@typescript-eslint/restrict-template-expressions': 'warn',
     '@typescript-eslint/no-unused-vars': [
       'error',
       { argsIgnorePattern: '^_', caughtErrorsIgnorePattern: '^_' },

e2e-tests/utils/index.ts

@@ -30,8 +30,31 @@ export const log = {
   info: (message: string) => {
     dim(`[INFO] ${message}`);
   },
-  error: (message: string) => {
-    red(`[ERROR] ${message}`);
+  error: (message: unknown) => {
+    function formatMessage(message: unknown, depth: number): string {
+      if (depth > 3) {
+        return '...';
+      }
+
+      if (message instanceof Error) {
+        return JSON.stringify(
+          {
+            name: message.name,
+            message: message.message,
+            stack: message.stack,
+            ...(message.cause
+              ? {
+                  cause: formatMessage(message.cause, depth + 1),
+                }
+              : {}),
+          },
+          null,
+          2,
+        );
+      }
+      return String(message);
+    }
+    red(`[ERROR] ${formatMessage(message, 0)}`);
   },
 };
 

lib/Helper/File.ts

@@ -5,7 +5,11 @@ const IGNORE_PATTERN = ['node_modules/**', 'ios/Pods/**', '**/Pods/**'];
 
 export function patchMatchingFile(
   globPattern: string,
-  func: (content: string, match: string, ...args: unknown[]) => void,
+  func: (
+    content: string,
+    match: string,
+    ...args: unknown[]
+  ) => Promise<string | void>,
   ...args: unknown[]
 ): Promise<void> {
   const matches = glob.sync(globPattern, {
@@ -19,11 +23,7 @@ export function patchMatchingFile(
     rv = rv
       .then(() => func(contents, match, ...args))
       .then((newContents) => {
-        if (
-          newContents !== null &&
-          newContents !== undefined &&
-          contents !== newContents
-        ) {
+        if (newContents != null && contents !== newContents) {
           fs.writeFileSync(match, newContents);
         }
       });

lib/Steps/Integrations/Cordova.ts

@@ -7,7 +7,7 @@ import xcode from 'xcode';
 import type { Args } from '../../Constants';
 import { exists, matchesContent, patchMatchingFile } from '../../Helper/File';
 import { green } from '../../Helper/Logging';
-import { SentryCli } from '../../Helper/SentryCli';
+import { SentryCli, SentryCliProps } from '../../Helper/SentryCli';
 import { BaseIntegration } from './BaseIntegration';
 
 export class Cordova extends BaseIntegration {
@@ -31,7 +31,7 @@ export class Cordova extends BaseIntegration {
 
     await patchMatchingFile(
       `${this._folderPrefix}/ios/*.xcodeproj/project.pbxproj`,
-      this._patchXcodeProj.bind(this),
+      (contents, filename) => this._patchXcodeProj(contents, filename),
     );
 
     await this._addSentryProperties(sentryCliProperties);
@@ -41,9 +41,8 @@ export class Cordova extends BaseIntegration {
   }
 
   public async uninstall(_answers: Answers): Promise<Answers> {
-    await patchMatchingFile(
-      '**/*.xcodeproj/project.pbxproj',
-      this._unpatchXcodeProj.bind(this),
+    await patchMatchingFile('**/*.xcodeproj/project.pbxproj', (_, filename) =>
+      this._unpatchXcodeProj(filename),
     );
 
     return {};
@@ -135,7 +134,7 @@ export class Cordova extends BaseIntegration {
   private _patchXcodeProj(
     contents: string,
     filename: string,
-  ): Promise<void | string> {
+  ): Promise<string | void> {
     const proj = xcode.project(filename);
     return new Promise((resolve, reject) => {
       proj.parse((err: any) => {
@@ -282,7 +281,7 @@ export class Cordova extends BaseIntegration {
     );
   }
 
-  private _addSentryProperties(properties: any): Promise<void> {
+  private _addSentryProperties(properties: SentryCliProps): Promise<void> {
     let rv = Promise.resolve();
     const fn = path.join('sentry.properties');
     if (exists(fn)) {

lib/Steps/Integrations/MobileProject.ts

@@ -30,7 +30,7 @@ export abstract class MobileProject extends BaseIntegration {
     const isPlatformSet =
       this._argv.platform &&
       Array.isArray(this._argv.platform) &&
-      this._argv.platform.length;
+      !!this._argv.platform.length;
 
     this._platforms = isPlatformSet
       ? this._argv.platform
@@ -52,7 +52,7 @@ export abstract class MobileProject extends BaseIntegration {
     return { shouldConfigurePlatforms };
   }
 
-  protected _platformSelector(): Promise<Answers> {
+  protected _platformSelector(): Promise<Answers & { platform: Platform[] }> {
     if (this._argv.quiet) {
       throw new Error('You need to choose a platform');
     }