use more appropriate exception name

Author: mdtro

src/sentry/models/apitoken.py

@@ -44,6 +44,11 @@ def __init__(
         super().__init__(message)
 
 
+class NotSupported(Exception):
+    def __init__(self, message="the method you called is not supported by this token type"):
+        super().__init__(message)
+
+
 class ApiTokenManager(ControlOutboxProducingManager):
     def create(self, *args, **kwargs):
         token_type: AuthTokenType | None = kwargs.get("token_type", None)
@@ -168,7 +173,7 @@ def _plaintext_refresh_token(self):
         if self.refresh_token or self.hashed_refresh_token:
             return ApiToken.objects.plaintext_refresh_token
         else:
-            raise NotImplementedError("This API token type does not support refresh tokens")
+            raise NotSupported("This API token type does not support refresh tokens")
 
     def save(self, *args: Any, **kwargs: Any) -> None:
         if options.get("apitoken.save-hash-on-create"):
@@ -241,7 +246,7 @@ def get_allowed_origins(self):
 
     def refresh(self, expires_at=None):
         if self.token_type == AuthTokenType.USER:
-            raise NotImplementedError("User auth tokens do not support refreshing the token")
+            raise NotSupported("User auth tokens do not support refreshing the token")
 
         if expires_at is None:
             expires_at = timezone.now() + DEFAULT_EXPIRATION

tests/sentry/models/test_apitoken.py

@@ -6,7 +6,7 @@
 
 from sentry.conf.server import SENTRY_SCOPE_HIERARCHY_MAPPING, SENTRY_SCOPES
 from sentry.hybridcloud.models import ApiTokenReplica
-from sentry.models.apitoken import ApiToken, PlaintextSecretAlreadyRead
+from sentry.models.apitoken import ApiToken, NotSupported, PlaintextSecretAlreadyRead
 from sentry.models.integrations.sentry_app_installation import SentryAppInstallation
 from sentry.models.integrations.sentry_app_installation_token import SentryAppInstallationToken
 from sentry.silo import SiloMode
@@ -77,6 +77,13 @@ def test_last_chars_are_not_set(self):
         token = ApiToken.objects.create(user_id=user.id)
         assert token.token_last_characters is None
 
+    @override_options({"apitoken.save-hash-on-create": True})
+    def test_hash_exists_on_token(self):
+        user = self.create_user()
+        token = ApiToken.objects.create(user_id=user.id)
+        assert token.hashed_token is not None
+        assert token.hashed_refresh_token is not None
+
     @override_options({"apitoken.save-hash-on-create": True})
     def test_hash_exists_on_user_token(self):
         user = self.create_user()
@@ -130,11 +137,19 @@ def test_error_when_accessing_refresh_token_on_user_token(self):
         user = self.create_user()
         token = ApiToken.objects.create(user_id=user.id, token_type=AuthTokenType.USER)
 
-        with pytest.raises(NotImplementedError):
+        with pytest.raises(NotSupported):
             assert token._plaintext_refresh_token is not None
 
     @override_options({"apitoken.save-hash-on-create": True})
-    def test_user_auth_token_hash(self):
+    def test_user_auth_token_refresh_raises_error(self):
+        user = self.create_user()
+        token = ApiToken.objects.create(user_id=user.id, token_type=AuthTokenType.USER)
+
+        with pytest.raises(NotSupported):
+            token.refresh()
+
+    @override_options({"apitoken.save-hash-on-create": True})
+    def test_user_auth_token_sha256_hash(self):
         user = self.create_user()
         token = ApiToken.objects.create(user_id=user.id, token_type=AuthTokenType.USER)
         expected_hash = hashlib.sha256(token._plaintext_token.encode()).hexdigest()