Skip to content

Add Support for in memory caching #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bmike78 opened this issue Apr 17, 2025 · 3 comments · May be fixed by #817
Open

Add Support for in memory caching #816

bmike78 opened this issue Apr 17, 2025 · 3 comments · May be fixed by #817
Labels
enhancement New feature or request

Comments

@bmike78
Copy link

bmike78 commented Apr 17, 2025

Prerequisites:

  • Is the functionality available in the GitHub UI? If so, please provide a link to information about the feature.
    • technically this is a feature of the safe settings and caching frequently used github API calls

New Feature

  • We run a forked copy of safe settings and would like to provide some contributions upstream to be at parity with main-enterprise.

  • We run safe settings at a very large scale of several hundred repos today, but technically have it enabled for several thousand repos.

  • We are constantly rate limited by the github API and so we've added a simple caching layer, which resulted in about 96-97% of repo contents being cached and got us past our rate limit issues of the endpoint of "/repositories/:repository_id/contents/?"
@bmike78 bmike78 added the enhancement New feature or request label Apr 17, 2025
@bmike78
Copy link
Author

bmike78 commented Apr 17, 2025

@decyjphr, is this something that you would approve of if we issued a PR?

@decyjphr
Copy link
Collaborator

Yes, this would be a good addition.

I'll wait for the PR to see the implementation details and will probably have more questions but it will be useful for large orgs.

@DouJohn DouJohn linked a pull request Apr 21, 2025 that will close this issue
Open
@DouJohn
Copy link

DouJohn commented Apr 21, 2025

Fyi @decyjphr - I work with Mike at John Deere, and I just opened the linked pr showing how we implemented our cache. Feel free to take a look and tell me what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add a simple in-memory cache for suborg/repo config fetches DouJohn/safe-settings
3 participants
@bmike78 @DouJohn @decyjphr