Fix Loop contains which contained a missing negation and add test cases. #156
+80
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the action and set up an initial configuration that passes on the codebase at this point in time.
Invalid Go toolchain version (1 result)
* go.mod#L0C0:0: As of Go 1.21, toolchain versions [must use the 1.N.P syntax](https://go.dev/doc/toolchain#version).
`1.21` in `go.mod` does not match this syntax and there is no additional `toolchain` directive, which may cause some `go` commands to fail.
(with comments on what the hash is representing
I couldn't find a better resource than https://github.com/dependabot/dependabot-core/blob/main/github_actions/spec/fixtures/workflow_files/pinned_sources_version_comments.yml to document what formats work.
Add some helpers to shape index cell and range iterator to match C++. Update loop to use the helpers to more closely match the code flows. Negate a boolean check that was missed. TODO: test cases to prove it works now but not before the fix.
alan-strohm
reviewed
Apr 22, 2025
| @@ -1332,6 +1357,18 @@ func TestLoopRelations(t *testing.T) { | |||
| contains: true, | |||
| sharedEdge: true, | |||
| }, | |||
| // https://github.com/golang/geo/issues/77 and 78 | |||
| // These cases failed prior to this fix. | |||
There was a problem hiding this comment.
Remove this comment ("this fix" means the pull request, not the file). I'd suggest a different comment. Something like:
// Cases below here prevent regressions of bugs which previously appeared in the golang version
// and which are missing test coverage in the C++ codebase.
| // containsCenterMatches reports if the clippedShapes containsCenter boolean | ||
| // corresponds to the crossing target type given. (This is to work around C++ | ||
| // allowing false == 0, true == 1 type implicit conversions and comparisons) | ||
| func containsCenterMatches(a bool, target crossingTarget) bool { |
There was a problem hiding this comment.
Why not make a type *rangeIterator? That way you can ensure that the boolean means what you intend it to mean. Alternatively, consider renaming a to containsCenter.
| return true | ||
| } | ||
| // Otherwise test all the edge crossings directly. | ||
| aClipped := ai.it.IndexCell().shapes[0] |
There was a problem hiding this comment.
Why not use your new ai/bi.clipped() function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loop's hasCrossingRelation() had the wrong condition on one branch. This has been resolved and test cases added ensuring it was fixed.
Fix #77
Fix #78