strconv: remove redundant conversions to int

smasher164 · bradfitz · commit 0a364330a2ab · 2020-04-27T21:46:18.000Z
IntSize is an untyped constant that does not need explicit conversion. Annotating IntSize as an int and running github.com/mdempsky/unconvert reveals these two cases. Fixes #38682. Change-Id: I014646b7457ddcde32474810153229dcf0c269c6 Reviewed-on: https://go-review.googlesource.com/c/go/+/230306 Run-TryBot: Akhil Indurti <aindurti@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
diff --git a/src/strconv/atoi.go b/src/strconv/atoi.go
@@ -96,7 +96,7 @@ func ParseUint(s string, base int, bitSize int) (uint64, error) {
 	}
 
 	if bitSize == 0 {
-		bitSize = int(IntSize)
+		bitSize = IntSize
 	} else if bitSize < 0 || bitSize > 64 {
 		return 0, bitSizeError(fnParseUint, s0, bitSize)
 	}
@@ -203,7 +203,7 @@ func ParseInt(s string, base int, bitSize int) (i int64, err error) {
 	}
 
 	if bitSize == 0 {
-		bitSize = int(IntSize)
+		bitSize = IntSize
 	}
 
 	cutoff := uint64(1 << uint(bitSize-1))

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ func ParseUint(s string, base int, bitSize int) (uint64, error) {`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`if bitSize == 0 {`
`99`		`- bitSize = int(IntSize)`
	`99`	`+ bitSize = IntSize`
`100`	`100`	`} else if bitSize < 0 \|\| bitSize > 64 {`
`101`	`101`	`return 0, bitSizeError(fnParseUint, s0, bitSize)`
`102`	`102`	`}`
`@@ -203,7 +203,7 @@ func ParseInt(s string, base int, bitSize int) (i int64, err error) {`
`203`	`203`	`}`
`204`	`204`
`205`	`205`	`if bitSize == 0 {`
`206`		`- bitSize = int(IntSize)`
	`206`	`+ bitSize = IntSize`
`207`	`207`	`}`
`208`	`208`
`209`	`209`	`cutoff := uint64(1 << uint(bitSize-1))`