Merge branch 'master' into 12ya-patch

Author: 12ya

cmd/signature-fuzzer/internal/fuzz-generator/gen_test.go

@@ -112,7 +112,7 @@ func TestIsBuildable(t *testing.T) {
 	verb(1, "output is: %s\n", string(coutput))
 }
 
-// TestExhaustive does a series of code genreation runs, starting with
+// TestExhaustive does a series of code generation runs, starting with
 // (relatively) simple code and then getting progressively more
 // complex (more params, deeper structs, turning on additional
 // features such as address-taken vars and reflect testing). The

cmd/stringer/endtoend_test.go

@@ -286,7 +286,7 @@ func TestTestFiles(t *testing.T) {
 	}
 }
 
-// The -output flag cannot be used in combiation with matching types across multiple packages.
+// The -output flag cannot be used in combination with matching types across multiple packages.
 func TestCollidingOutput(t *testing.T) {
 	testenv.NeedsTool(t, "go")
 	stringer := stringerPath(t)

go/analysis/checker/example_test.go

@@ -69,7 +69,7 @@ func Example() {
 	// min=bufio max=unsafe
 }
 
-// minmaxpkg is a trival example analyzer that uses package facts to
+// minmaxpkg is a trivial example analyzer that uses package facts to
 // compute information from the entire dependency graph.
 var minmaxpkg = &analysis.Analyzer{
 	Name:      "minmaxpkg",

go/analysis/doc/suggested_fixes.md

@@ -79,7 +79,7 @@ These requirements guarantee that suggested fixes can be cleanly applied.
 Because a driver may only analyze, or be able to modify, the current package,
 we restrict edits to the current package. In general this restriction should
 not be a big problem for users because other packages might not belong to the
-same module and so will not be safe to modify in a singe change.
+same module and so will not be safe to modify in a single change.
 
 On the other hand, analyzers will not be required to produce gofmt-compliant
 code. Analysis drivers will be expected to apply gofmt to the results of

go/analysis/internal/checker/checker.go

@@ -99,7 +99,7 @@ func Run(args []string, analyzers []*analysis.Analyzer) (exitcode int) {
 	// without having to remember what code to return.
 	//
 	// TODO(adonovan): interpreting exit codes is like reading tea-leaves.
-	// Insted of wasting effort trying to encode a multidimensional result
+	// Instead of wasting effort trying to encode a multidimensional result
 	// into 7 bits we should just emit structured JSON output, and
 	// an exit code of 0 or 1 for success or failure.
 	exitAtLeast := func(code int) {

go/analysis/passes/asmdecl/asmdecl.go

@@ -57,7 +57,7 @@ type asmArch struct {
 	// include the first integer register and first floating-point register. Accessing
 	// any of them counts as writing to result.
 	retRegs []string
-	// writeResult is a list of instructions that will change result register implicity.
+	// writeResult is a list of instructions that will change result register implicitly.
 	writeResult []string
 	// calculated during initialization
 	sizes    types.Sizes

go/analysis/passes/loopclosure/loopclosure.go

@@ -88,7 +88,7 @@ func run(pass *analysis.Pass) (any, error) {
 		//
 		// TODO: consider allowing the "last" go/defer/Go statement to be followed by
 		// N "trivial" statements, possibly under a recursive definition of "trivial"
-		// so that that checker could, for example, conclude that a go statement is
+		// so that checker could, for example, conclude that a go statement is
 		// followed by an if statement made of only trivial statements and trivial expressions,
 		// and hence the go statement could still be checked.
 		forEachLastStmt(body.List, func(last ast.Stmt) {

go/analysis/passes/structtag/structtag.go

@@ -107,7 +107,7 @@ func checkCanonicalFieldTag(pass *analysis.Pass, field *types.Var, tag string, s
 
 	// Embedded struct. Nothing to do for now, but that
 	// may change, depending on what happens with issue 7363.
-	// TODO(adonovan): investigate, now that that issue is fixed.
+	// TODO(adonovan): investigate, now that issue is fixed.
 	if field.Anonymous() {
 		return
 	}

go/analysis/unitchecker/unitchecker_test.go

@@ -170,7 +170,7 @@ func _() {
 		// TODO(golang/go#65729): this is unsound: any extra
 		// logging by the child process (e.g. due to GODEBUG
 		// options) will add noise to stderr, causing the
-		// CombinedOutput to be unparseable as JSON. But we
+		// CombinedOutput to be unparsable as JSON. But we
 		// can't simply use Output here as some of the tests
 		// look for substrings of stderr. Rework the test to
 		// be specific about which output stream to match.

go/callgraph/vta/graph.go

@@ -658,7 +658,7 @@ func (b *builder) call(c ssa.CallInstruction) {
 }
 
 func addArgumentFlows(b *builder, c ssa.CallInstruction, f *ssa.Function) {
-	// When f has no paremeters (including receiver), there is no type
+	// When f has no parameters (including receiver), there is no type
 	// flow here. Also, f's body and parameters might be missing, such
 	// as when vta is used within the golang.org/x/tools/go/analysis
 	// framework (see github.com/golang/go/issues/50670).
@@ -803,7 +803,7 @@ func (b *builder) nodeFromVal(val ssa.Value) node {
 		return function{f: v}
 	case *ssa.Parameter, *ssa.FreeVar, ssa.Instruction:
 		// ssa.Param, ssa.FreeVar, and a specific set of "register" instructions,
-		// satisifying the ssa.Value interface, can serve as local variables.
+		// satisfying the ssa.Value interface, can serve as local variables.
 		return local{val: v}
 	default:
 		panic(fmt.Errorf("unsupported value %v in node creation", val))

go/callgraph/vta/internal/trie/builder.go

@@ -245,7 +245,7 @@ func (b *Builder) create(leaves []*leaf) node {
 	} else if n == 1 {
 		return leaves[0]
 	}
-	// Note: we can do a more sophisicated algorithm by:
+	// Note: we can do a more sophisticated algorithm by:
 	// - sorting the leaves ahead of time,
 	// - taking the prefix and branching bit of the min and max key,
 	// - binary searching for the branching bit,

go/loader/doc.go

@@ -164,7 +164,7 @@ package loader
 // entry is created in this cache by startLoad the first time the
 // package is imported.  The first goroutine to request an entry becomes
 // responsible for completing the task and broadcasting completion to
-// subsequent requestors, which block until then.
+// subsequent requesters, which block until then.
 //
 // Type checking occurs in (parallel) postorder: we cannot type-check a
 // set of files until we have loaded and type-checked all of their

go/packages/overlay_test.go

@@ -81,7 +81,7 @@ func testOverlayChangesBothPackageNames(t *testing.T, exporter packagestest.Expo
 		t.Fatalf("failed to load: %v", err)
 	}
 	if len(initial) != 3 {
-		t.Errorf("got %d packges, expected 3", len(initial))
+		t.Errorf("got %d packages, expected 3", len(initial))
 	}
 	want := []struct {
 		id, name string
@@ -127,7 +127,7 @@ func testOverlayChangesTestPackageName(t *testing.T, exporter packagestest.Expor
 		t.Fatalf("failed to load: %v", err)
 	}
 	if len(initial) != 3 {
-		t.Errorf("got %d packges, expected 3", len(initial))
+		t.Errorf("got %d packages, expected 3", len(initial))
 	}
 	want := []struct {
 		id, name string

go/packages/packages_test.go

@@ -2676,7 +2676,7 @@ func testIssue48226(t *testing.T, exporter packagestest.Exporter) {
 		t.Fatal(err)
 	}
 	if len(initial) != 1 {
-		t.Fatalf("exepected 1 package, got %d", len(initial))
+		t.Fatalf("expected 1 package, got %d", len(initial))
 	}
 	pkg := initial[0]
 
@@ -2721,7 +2721,7 @@ func testModule(t *testing.T, exporter packagestest.Exporter) {
 			t.Fatal("package.Module: want non-nil, got nil")
 		}
 		if a.Module.Path != "golang.org/fake" {
-			t.Fatalf("package.Modile.Path: want \"golang.org/fake\", got %q", a.Module.Path)
+			t.Fatalf("package.Module.Path: want \"golang.org/fake\", got %q", a.Module.Path)
 		}
 		if a.Module.GoMod != filepath.Join(rootDir, "go.mod") {
 			t.Fatalf("package.Module.GoMod: want %q, got %q", filepath.Join(rootDir, "go.mod"), a.Module.GoMod)

go/ssa/builder.go

@@ -25,7 +25,7 @@ package ssa
 // populating fields such as Function.Body, .Params, and others.
 //
 // Building may create additional methods, including:
-// - wrapper methods (e.g. for embeddding, or implicit &recv)
+// - wrapper methods (e.g. for embedding, or implicit &recv)
 // - bound method closures (e.g. for use(recv.f))
 // - thunks (e.g. for use(I.f) or use(T.f))
 // - generic instances (e.g. to produce f[int] from f[any]).

go/ssa/builder_generic_test.go

@@ -766,7 +766,7 @@ func TestInstructionString(t *testing.T) {
 
 	// Expectation is a {function, type string} -> {want, matches}
 	// where matches is all Instructions.String() that match the key.
-	// Each expecation is that some permutation of matches is wants.
+	// Each expectation is that some permutation of matches is wants.
 	type expKey struct {
 		function string
 		kind     string

go/ssa/interp/external.go

@@ -13,6 +13,7 @@ import (
 	"math"
 	"os"
 	"runtime"
+	"slices"
 	"sort"
 	"strconv"
 	"strings"
@@ -119,15 +120,7 @@ func ext۰bytes۰Equal(fr *frame, args []value) value {
 	// func Equal(a, b []byte) bool
 	a := args[0].([]value)
 	b := args[1].([]value)
-	if len(a) != len(b) {
-		return false
-	}
-	for i := range a {
-		if a[i] != b[i] {
-			return false
-		}
-	}
-	return true
+	return slices.Equal(a, b)
 }
 
 func ext۰bytes۰IndexByte(fr *frame, args []value) value {

go/ssa/subst.go

@@ -543,7 +543,7 @@ func (subst *subster) signature(t *types.Signature) types.Type {
 	// We are choosing not to support tparams.Len() > 0 until a need has been observed in practice.
 	//
 	// There are some known usages for types.Types coming from types.{Eval,CheckExpr}.
-	// To support tparams.Len() > 0, we just need to do the following [psuedocode]:
+	// To support tparams.Len() > 0, we just need to do the following [pseudocode]:
 	//   targs := {subst.replacements[tparams[i]]]}; Instantiate(ctxt, t, targs, false)
 
 	assert(tparams.Len() == 0, "Substituting types.Signatures with generic functions are currently unsupported.")

go/ssa/util.go

@@ -25,7 +25,7 @@ type unit struct{}
 
 //// Sanity checking utilities
 
-// assert panics with the mesage msg if p is false.
+// assert panics with the message msg if p is false.
 // Avoid combining with expensive string formatting.
 func assert(p bool, msg string) {
 	if !p {

gopls/doc/assets/go.mod

@@ -1,6 +1,6 @@
 // This module contains no Go code, but serves to carve out a hole in
 // its parent module to avoid bloating it with large image files that
-// would otherwise be dowloaded by "go install golang.org/x/tools/gopls@latest".
+// would otherwise be downloaded by "go install golang.org/x/tools/gopls@latest".
 
 module golang.org/x/tools/gopls/doc/assets
 

gopls/doc/contributing.md

@@ -188,7 +188,7 @@ Jenkins-like Google infrastructure for running Dockerized tests. This allows us
 to run gopls tests in various environments that would be difficult to add to
 the TryBots. Notably, Kokoro runs tests on
 [older Go versions](../README.md#supported-go-versions) that are no longer supported
-by the TryBots. Per that that policy, support for these older Go versions is
+by the TryBots. Per that policy, support for these older Go versions is
 best-effort, and test failures may be skipped rather than fixed.
 
 Kokoro runs are triggered by the `Run-TryBot=1` label, just like TryBots, but

gopls/doc/emacs.md

@@ -110,7 +110,7 @@ project root.
 
 ;; Optional: install eglot-format-buffer as a save hook.
 ;; The depth of -10 places this before eglot's willSave notification,
-;; so that that notification reports the actual contents that will be saved.
+;; so that notification reports the actual contents that will be saved.
 (defun eglot-format-buffer-before-save ()
   (add-hook 'before-save-hook #'eglot-format-buffer -10 t))
 (add-hook 'go-mode-hook #'eglot-format-buffer-before-save)

gopls/doc/features/passive.md

@@ -46,7 +46,7 @@ structures, or when reading assembly files or stack traces that refer
 to each field by its cryptic byte offset.
 
 In addition, Hover reports:
-- the struct's size class, which is the number of of bytes actually
+- the struct's size class, which is the number of bytes actually
   allocated by the Go runtime for a single object of this type; and
 - the percentage of wasted space due to suboptimal ordering of struct
   fields, if this figure is 20% or higher:

gopls/doc/features/templates.md

@@ -14,7 +14,7 @@ value, since Go templates don't have a canonical file extension.)
 
 Additional configuration may be necessary to ensure that your client
 chooses the correct language kind when opening template files.
-Gopls recogizes both `"tmpl"` and `"gotmpl"` for template files.
+Gopls recognizes both `"tmpl"` and `"gotmpl"` for template files.
 For example, in `VS Code` you will also need to add an
 entry to the
 [`files.associations`](https://code.visualstudio.com/docs/languages/identifiers)

gopls/doc/release/v0.17.0.md

@@ -17,7 +17,7 @@ reduce the considerable costs to us of testing against older Go versions,
 allowing us to spend more time fixing bugs and adding features that benefit the
 majority of gopls users who run recent versions of Go.
 
-This narrowing is occuring in two dimensions: **build compatibility** refers to
+This narrowing is occurring in two dimensions: **build compatibility** refers to
 the versions of the Go toolchain that can be used to build gopls, and **go
 command compatibility** refers to the versions of the `go` command that can be
 used by gopls to list information about packages and modules in your workspace.
@@ -110,7 +110,7 @@ The user can invoke this code action by selecting a function name, the keywords
 or by selecting a whole declaration or multiple declarations.
 
 In order to avoid ambiguity and surprise about what to extract, some kinds
-of paritial selection of a declaration cannot invoke this code action.
+of partial selection of a declaration cannot invoke this code action.
 
 ### Extract constant
 

gopls/doc/release/v0.19.0.md

@@ -35,7 +35,7 @@ Slightly more than half of the analyzers in the
 enabled by default. This subset has been chosen for precision and
 efficiency.
 
-Prevously, Staticcheck analyzers (all of them) would be run only if
+Previously, Staticcheck analyzers (all of them) would be run only if
 the experimental `staticcheck` boolean option was set to `true`. This
 value continues to enable the complete set, and a value of `false`
 continues to disable the complete set. Leaving the option unspecified

gopls/internal/analysis/modernize/testdata/src/minmax/minmax.go

@@ -139,7 +139,7 @@ func fix72727(a, b int) {
 
 type myfloat float64
 
-// The built-in min/max differ in their treatement of NaN,
+// The built-in min/max differ in their treatment of NaN,
 // so reject floating-point numbers (#72829).
 func nopeFloat(a, b myfloat) (res myfloat) {
 	if a < b {

gopls/internal/analysis/modernize/testdata/src/minmax/minmax.go.golden

@@ -126,7 +126,7 @@ func fix72727(a, b int) {
 
 type myfloat float64
 
-// The built-in min/max differ in their treatement of NaN,
+// The built-in min/max differ in their treatment of NaN,
 // so reject floating-point numbers (#72829).
 func nopeFloat(a, b myfloat) (res myfloat) {
 	if a < b {

gopls/internal/analysis/unusedparams/testdata/src/generatedcode/nongeneratedcode.go

@@ -12,7 +12,7 @@ type implementsGeneratedInterface struct{}
 // in the generated code.
 func (implementsGeneratedInterface) n(f bool) {
 	// The body must not be empty, otherwise unusedparams will
-	// not report the unused parameter regardles of the
+	// not report the unused parameter regardless of the
 	// interface.
 	println()
 }

gopls/internal/analysis/unusedparams/testdata/src/generatedcode/nongeneratedcode.go.golden

@@ -12,7 +12,7 @@ type implementsGeneratedInterface struct{}
 // in the generated code.
 func (implementsGeneratedInterface) n(f bool) {
 	// The body must not be empty, otherwise unusedparams will
-	// not report the unused parameter regardles of the
+	// not report the unused parameter regardless of the
 	// interface.
 	println()
 }

gopls/internal/analysis/yield/yield.go

@@ -14,7 +14,7 @@ package yield
 //
 // 	seq(yield)
 //
-// to avoid unnecesary range desugaring and chains of dynamic calls.
+// to avoid unnecessary range desugaring and chains of dynamic calls.
 
 import (
 	_ "embed"

gopls/internal/cache/check.go

@@ -1688,15 +1688,15 @@ func (b *typeCheckBatch) checkPackage(ctx context.Context, fset *token.FileSet,
 
 	// Track URIs with parse errors so that we can suppress type errors for these
 	// files.
-	unparseable := map[protocol.DocumentURI]bool{}
+	unparsable := map[protocol.DocumentURI]bool{}
 	for _, e := range pkg.parseErrors {
 		diags, err := parseErrorDiagnostics(pkg, e)
 		if err != nil {
 			event.Error(ctx, "unable to compute positions for parse errors", err, label.Package.Of(string(inputs.id)))
 			continue
 		}
 		for _, diag := range diags {
-			unparseable[diag.URI] = true
+			unparsable[diag.URI] = true
 			pkg.diagnostics = append(pkg.diagnostics, diag)
 		}
 	}
@@ -1706,7 +1706,7 @@ func (b *typeCheckBatch) checkPackage(ctx context.Context, fset *token.FileSet,
 		// If the file didn't parse cleanly, it is highly likely that type
 		// checking errors will be confusing or redundant. But otherwise, type
 		// checking usually provides a good enough signal to include.
-		if !unparseable[diag.URI] {
+		if !unparsable[diag.URI] {
 			pkg.diagnostics = append(pkg.diagnostics, diag)
 		}
 	}

gopls/internal/cache/mod_tidy.go

@@ -45,7 +45,7 @@ func (s *Snapshot) ModTidy(ctx context.Context, pm *ParsedModule) (*TidiedModule
 
 	uri := pm.URI
 	if pm.File == nil {
-		return nil, fmt.Errorf("cannot tidy unparseable go.mod file: %v", uri)
+		return nil, fmt.Errorf("cannot tidy unparsable go.mod file: %v", uri)
 	}
 
 	s.mu.Lock()

gopls/internal/cache/parse_cache.go

@@ -391,7 +391,7 @@ func (c *parseCache) parseFiles(ctx context.Context, fset *token.FileSet, mode p
 
 // -- priority queue boilerplate --
 
-// queue is a min-atime prority queue of cache entries.
+// queue is a min-atime priority queue of cache entries.
 type queue []*parseCacheEntry
 
 func (q queue) Len() int { return len(q) }

gopls/internal/cache/parsego/parse.go

@@ -82,7 +82,7 @@ func Parse(ctx context.Context, fset *token.FileSet, uri protocol.DocumentURI, s
 		}
 
 		for i := range 10 {
-			// Fix certain syntax errors that render the file unparseable.
+			// Fix certain syntax errors that render the file unparsable.
 			newSrc, srcFix := fixSrc(file, tok, src)
 			if newSrc == nil {
 				break
@@ -213,7 +213,7 @@ func fixAST(n ast.Node, tok *token.File, src []byte) (fixes []FixType) {
 	return fixes
 }
 
-// TODO(rfindley): revert this intrumentation once we're certain the crash in
+// TODO(rfindley): revert this instrumentation once we're certain the crash in
 // #59097 is fixed.
 type FixType int