Skip to content

Commit 5f5a875

Browse files
committed
build/Dockerfile: skip global typescript, vsce installation
We already have vsce and typescript in the project's package.json and don't need to preinstall them. Change-Id: Idf4484a3b5662d9509c3146737d6d448bd9c8771 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/506656 TryBot-Result: kokoro <[email protected]> Reviewed-by: Suzy Mueller <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
1 parent 0de0e11 commit 5f5a875

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

build/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ ENV DEBIAN_FRONTEND noninteractive
2626
ENV NODE_OPTIONS --dns-result-order=ipv4first
2727

2828
RUN apt-get -qq update && apt-get install -qq -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0 jq > /dev/null
29-
RUN npm install -g typescript @vscode/vsce
3029

3130
USER node
3231
WORKDIR /workspace
33-
ENTRYPOINT ["build/all.bash"]
32+
ENTRYPOINT ["build/all.bash"]

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
],
3838
"scripts": {
3939
"clean": "rm -rf ./dist/* && rm *.vsix",
40-
"package": "vsce package",
40+
"package": "npx vsce package",
4141
"vscode:prepublish": "npm run compile",
4242
"bundle": "esbuild src/goMain.ts debugAdapter=src/debugAdapter/goDebug.ts --bundle --outdir=dist --external:vscode --format=cjs --platform=node",
4343
"bundle-dev": "npm run bundle -- --sourcemap",

0 commit comments

Comments
 (0)