Add a UnnecessarilyFullyQualified:BatchFindings flag to support re-enabling UnnecessarilyFullyQualified in Tricorder.

PiperOrigin-RevId: 753573653

Author: graememorgan

core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyFullyQualified.java

@@ -88,9 +88,13 @@ public final class UnnecessarilyFullyQualified extends BugChecker
    */
   private final ImmutableSet<String> exemptedEnclosingTypes;
 
+  private final boolean batchFindings;
+
   @Inject
   UnnecessarilyFullyQualified(ErrorProneFlags errorProneFlags) {
     this.exemptedEnclosingTypes = errorProneFlags.getSetOrEmpty("BadImport:BadEnclosingTypes");
+    this.batchFindings =
+        errorProneFlags.getBoolean("UnnecessarilyFullyQualified:BatchFindings").orElse(false);
   }
 
   @Override
@@ -255,6 +259,9 @@ public Void visitIdentifier(IdentifierTree identifierTree, Void aVoid) {
       SuggestedFix fix = fixBuilder.build();
       for (TreePath path : pathsToFix) {
         state.reportMatch(describeMatch(path.getLeaf(), fix));
+        if (this.batchFindings) {
+          break;
+        }
       }
     }
     return NO_MATCH;

core/src/test/java/com/google/errorprone/bugpatterns/UnnecessarilyFullyQualifiedTest.java

@@ -27,6 +27,9 @@ public final class UnnecessarilyFullyQualifiedTest {
   private final BugCheckerRefactoringTestHelper helper =
       BugCheckerRefactoringTestHelper.newInstance(UnnecessarilyFullyQualified.class, getClass());
 
+  private final CompilationTestHelper compilationHelper =
+      CompilationTestHelper.newInstance(UnnecessarilyFullyQualified.class, getClass());
+
   @Test
   public void singleUse() {
     helper
@@ -397,4 +400,38 @@ abstract class AbstractType {}
         .expectUnchanged()
         .doTest();
   }
+
+  @Test
+  public void unbatchedFindings() {
+    compilationHelper
+        .addSourceLines(
+            "Test.java",
+            """
+            interface Test {
+              // BUG: Diagnostic contains:
+              java.util.List foo();
+
+              // BUG: Diagnostic contains:
+              java.util.List bar();
+            }
+            """)
+        .doTest();
+  }
+
+  @Test
+  public void batchedFindings() {
+    compilationHelper
+        .addSourceLines(
+            "Test.java",
+            """
+            interface Test {
+              // BUG: Diagnostic contains:
+              java.util.List foo();
+
+              java.util.List bar();
+            }
+            """)
+        .setArgs("-XepOpt:UnnecessarilyFullyQualified:BatchFindings=true")
+        .doTest();
+  }
 }