Make incidentEdgeOrder() public for [Value]Graph

nymanjens · netdpb · commit 70164025a8ca · 2020-01-09T15:24:43.000-05:00
RELNOTES=`graph`: Allow setting a stable incident edge order by calling the newly added method `[Value]Graph.Builder.incidentEdgeOrder(ElementOrder.stable())`. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288715042
diff --git a/android/guava/src/com/google/common/graph/ElementOrder.java b/android/guava/src/com/google/common/graph/ElementOrder.java
@@ -116,8 +116,7 @@ public static <S> ElementOrder<S> unordered() {
    *       </ul>
    * </ul>
    */
-  // TODO(b/142723300): Make this method public
-  static <S> ElementOrder<S> stable() {
+  public static <S> ElementOrder<S> stable() {
     return new ElementOrder<S>(Type.STABLE, null);
   }
 
diff --git a/android/guava/src/com/google/common/graph/GraphBuilder.java b/android/guava/src/com/google/common/graph/GraphBuilder.java
@@ -155,8 +155,7 @@ public <N1 extends N> GraphBuilder<N1> nodeOrder(ElementOrder<N1> nodeOrder) {
    * @throws IllegalArgumentException if {@code incidentEdgeOrder} is not either {@code
    *     ElementOrder.unordered()} or {@code ElementOrder.stable()}.
    */
-  // TODO(b/142723300): Make this method public
-  <N1 extends N> GraphBuilder<N1> incidentEdgeOrder(ElementOrder<N1> incidentEdgeOrder) {
+  public <N1 extends N> GraphBuilder<N1> incidentEdgeOrder(ElementOrder<N1> incidentEdgeOrder) {
     checkArgument(
         incidentEdgeOrder.type() == ElementOrder.Type.UNORDERED
             || incidentEdgeOrder.type() == ElementOrder.Type.STABLE,
diff --git a/android/guava/src/com/google/common/graph/ValueGraphBuilder.java b/android/guava/src/com/google/common/graph/ValueGraphBuilder.java
@@ -159,8 +159,8 @@ public <N1 extends N> ValueGraphBuilder<N1, V> nodeOrder(ElementOrder<N1> nodeOr
    * @throws IllegalArgumentException if {@code incidentEdgeOrder} is not either {@code
    *     ElementOrder.unordered()} or {@code ElementOrder.stable()}.
    */
-  // TODO(b/142723300): Make this method public
-  <N1 extends N> ValueGraphBuilder<N1, V> incidentEdgeOrder(ElementOrder<N1> incidentEdgeOrder) {
+  public <N1 extends N> ValueGraphBuilder<N1, V> incidentEdgeOrder(
+      ElementOrder<N1> incidentEdgeOrder) {
     checkArgument(
         incidentEdgeOrder.type() == ElementOrder.Type.UNORDERED
             || incidentEdgeOrder.type() == ElementOrder.Type.STABLE,
diff --git a/guava/src/com/google/common/graph/ElementOrder.java b/guava/src/com/google/common/graph/ElementOrder.java
@@ -115,8 +115,7 @@ public static <S> ElementOrder<S> unordered() {
    *       </ul>
    * </ul>
    */
-  // TODO(b/142723300): Make this method public
-  static <S> ElementOrder<S> stable() {
+  public static <S> ElementOrder<S> stable() {
     return new ElementOrder<S>(Type.STABLE, null);
   }
 
diff --git a/guava/src/com/google/common/graph/GraphBuilder.java b/guava/src/com/google/common/graph/GraphBuilder.java
@@ -155,8 +155,7 @@ public <N1 extends N> GraphBuilder<N1> nodeOrder(ElementOrder<N1> nodeOrder) {
    * @throws IllegalArgumentException if {@code incidentEdgeOrder} is not either {@code
    *     ElementOrder.unordered()} or {@code ElementOrder.stable()}.
    */
-  // TODO(b/142723300): Make this method public
-  <N1 extends N> GraphBuilder<N1> incidentEdgeOrder(ElementOrder<N1> incidentEdgeOrder) {
+  public <N1 extends N> GraphBuilder<N1> incidentEdgeOrder(ElementOrder<N1> incidentEdgeOrder) {
     checkArgument(
         incidentEdgeOrder.type() == ElementOrder.Type.UNORDERED
             || incidentEdgeOrder.type() == ElementOrder.Type.STABLE,
diff --git a/guava/src/com/google/common/graph/ValueGraphBuilder.java b/guava/src/com/google/common/graph/ValueGraphBuilder.java
@@ -159,8 +159,8 @@ public <N1 extends N> ValueGraphBuilder<N1, V> nodeOrder(ElementOrder<N1> nodeOr
    * @throws IllegalArgumentException if {@code incidentEdgeOrder} is not either {@code
    *     ElementOrder.unordered()} or {@code ElementOrder.stable()}.
    */
-  // TODO(b/142723300): Make this method public
-  <N1 extends N> ValueGraphBuilder<N1, V> incidentEdgeOrder(ElementOrder<N1> incidentEdgeOrder) {
+  public <N1 extends N> ValueGraphBuilder<N1, V> incidentEdgeOrder(
+      ElementOrder<N1> incidentEdgeOrder) {
     checkArgument(
         incidentEdgeOrder.type() == ElementOrder.Type.UNORDERED
             || incidentEdgeOrder.type() == ElementOrder.Type.STABLE,

Original file line number	Diff line number	Diff line change
`@@ -116,8 +116,7 @@ public static <S> ElementOrder<S> unordered() {`
`116`	`116`	`* </ul>`
`117`	`117`	`* </ul>`
`118`	`118`	`*/`
`119`		`- // TODO(b/142723300): Make this method public`
`120`		`- static <S> ElementOrder<S> stable() {`
	`119`	`+ public static <S> ElementOrder<S> stable() {`
`121`	`120`	`return new ElementOrder<S>(Type.STABLE, null);`
`122`	`121`	`}`
`123`	`122`
Original file line number	Diff line number	Diff line change
`@@ -115,8 +115,7 @@ public static <S> ElementOrder<S> unordered() {`
`115`	`115`	`* </ul>`
`116`	`116`	`* </ul>`
`117`	`117`	`*/`
`118`		`- // TODO(b/142723300): Make this method public`
`119`		`- static <S> ElementOrder<S> stable() {`
	`118`	`+ public static <S> ElementOrder<S> stable() {`
`120`	`119`	`return new ElementOrder<S>(Type.STABLE, null);`
`121`	`120`	`}`
`122`	`121`