Skip to content

Commit b7b6c17

Browse files
authored
chore: enable all linters by default (#1755)
This means that new linters will automatically be enabled, and also helps with the v2 migration since `presets` are no longer a thing. ~The new linters in the disabled list are ones that apparently were just not enabled and so there might be some we want to actually enable - please put a comment on particular linters that folks think we should look into further.~ Actually I don't think we want to enable any of them Sadly, this has made me realize that somehow I think I've missed some linters when I put together the list for `osv-scalibr` 🥲
1 parent 46632c0 commit b7b6c17

File tree

1 file changed

+21
-23
lines changed

1 file changed

+21
-23
lines changed

.golangci.yaml

+21-23
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,34 @@
11
output:
22
sort-results: true
33
linters:
4-
enable:
5-
- gofmt
6-
- goimports
4+
enable-all: true
75
# prettier-ignore
86
disable:
9-
- tagliatelle # we're parsing data from external sources (g-rath)
10-
- varnamelen # maybe later (g-rath)
7+
- cyclop
8+
- err113 # will re-add later (another-rex)
119
- exhaustruct # overkill (g-rath)
1210
- forcetypeassert # too hard (g-rath)
13-
- lll # line length is hard (g-rath)
14-
- godox # to-do comments are fine (g-rath)
11+
- funlen
12+
- gci
13+
- gochecknoglobals # disagree with, for non changing variables (another-rex)
14+
- gocognit
15+
- goconst # not everything should be a constant
16+
- gocyclo
1517
- godot # comments are fine without full stops (g-rath)
16-
- mnd # not every number is magic (g-rath)
17-
- wsl # disagree with, for now (g-rath)
18+
- godox # to-do comments are fine (g-rath)
19+
- gofumpt
1820
- ireturn # disagree with, sort of (g-rath)
19-
- gochecknoglobals # disagree with, for non changing variables (another-rex)
20-
- wrapcheck # too difficult, will re-add later (another-rex)
21-
- testpackage # will re-add later (another-rex)
22-
- err113 # will re-add later (another-rex)
21+
- lll # line length is hard (g-rath)
22+
- maintidx
23+
- mnd # not every number is magic (g-rath)
24+
- nestif
2325
- nonamedreturns # disagree with, for now (another-rex)
24-
- goconst # not everything should be a constant
25-
presets:
26-
- bugs
27-
- comment
28-
- error
29-
- performance
30-
- sql
31-
- style
32-
- test
33-
- unused
26+
- tagliatelle # we're parsing data from external sources (g-rath)
27+
- tenv # deprecated
28+
- testpackage # will re-add later (another-rex)
29+
- varnamelen # maybe later (g-rath)
30+
- wrapcheck # too difficult, will re-add later (another-rex)
31+
- wsl # disagree with, for now (g-rath)
3432

3533
linters-settings:
3634
exhaustive:

0 commit comments

Comments
 (0)