Skip to content

Commit 08920d8

Browse files
authored
Merge pull request #192 from Polymer/unique-browser
Add all browser config parameters to signature
2 parents be7a23d + f97c344 commit 08920d8

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](http://keepachangelog.com/) and this
66
project adheres to [Semantic Versioning](http://semver.org/).
77

8-
<!-- ## Unreleased -->
8+
## Unreleased
9+
10+
- Fix bug where a unique browser would not be launched if the only difference
11+
between browser configurations was `binary`, `addArguments`,
12+
`removeArguments`, `cpuThrottlingRate` or `preferences`.
913

1014
## [0.5.3] 2020-09-11
1115

src/browser.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,14 @@ export function browserSignature(config: BrowserConfig): string {
8585
return JSON.stringify([
8686
config.name,
8787
config.headless,
88-
config.remoteUrl || '',
88+
config.remoteUrl ?? '',
8989
config.windowSize.width,
9090
config.windowSize.height,
91+
config.binary ?? '',
92+
config.addArguments ?? [],
93+
config.removeArguments ?? [],
94+
config.cpuThrottlingRate ?? 1,
95+
config.preferences ?? {},
9196
]);
9297
}
9398

0 commit comments

Comments
 (0)