Skip to content

Commit f854c77

Browse files
fix: update gapic-generator-java with mock service generation fixes (#209)
* chore(deps): upgrade gapic-generator-java to 2.8.0 and update gax-java to 2.18.1 PiperOrigin-RevId: 450543911 Source-Link: googleapis/googleapis@5528344 Source-Link: https://github.com/googleapis/googleapis-gen/commit/9f6775cab1958982b88967a43e5e806af0f135db Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWY2Nzc1Y2FiMTk1ODk4MmI4ODk2N2E0M2U1ZTgwNmFmMGYxMzVkYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Enable REST transport for most of Java and Go clients PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update pom.xml * fix: update gapic-generator-java with mock service generation fixes PiperOrigin-RevId: 457524730 Source-Link: googleapis/googleapis@917e7f2 Source-Link: https://github.com/googleapis/googleapis-gen/commit/2497f9a069d3f6b2d6810d5a4e239cda1e7e5a39 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ5N2Y5YTA2OWQzZjZiMmQ2ODEwZDVhNGUyMzljZGExZTdlNWEzOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Neenu Shaji <[email protected]>
1 parent 16a114d commit f854c77

29 files changed

+2097
-15
lines changed

java-shell/google-cloud-shell/pom.xml

+16
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,10 @@
5858
<groupId>com.google.api</groupId>
5959
<artifactId>gax-grpc</artifactId>
6060
</dependency>
61+
<dependency>
62+
<groupId>com.google.api</groupId>
63+
<artifactId>gax-httpjson</artifactId>
64+
</dependency>
6165
<dependency>
6266
<groupId>org.threeten</groupId>
6367
<artifactId>threetenbp</artifactId>
@@ -77,12 +81,24 @@
7781
<scope>test</scope>
7882
</dependency>
7983
<!-- Need testing utility classes for generated gRPC clients tests -->
84+
<dependency>
85+
<groupId>com.google.api</groupId>
86+
<artifactId>gax</artifactId>
87+
<classifier>testlib</classifier>
88+
<scope>test</scope>
89+
</dependency>
8090
<dependency>
8191
<groupId>com.google.api</groupId>
8292
<artifactId>gax-grpc</artifactId>
8393
<classifier>testlib</classifier>
8494
<scope>test</scope>
8595
</dependency>
96+
<dependency>
97+
<groupId>com.google.api</groupId>
98+
<artifactId>gax-httpjson</artifactId>
99+
<classifier>testlib</classifier>
100+
<scope>test</scope>
101+
</dependency>
86102
</dependencies>
87103

88104
<profiles>

java-shell/google-cloud-shell/src/main/java/com/google/cloud/shell/v1/CloudShellServiceClient.java

+34-8
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@
1818

1919
import com.google.api.core.BetaApi;
2020
import com.google.api.gax.core.BackgroundResource;
21+
import com.google.api.gax.httpjson.longrunning.OperationsClient;
2122
import com.google.api.gax.longrunning.OperationFuture;
2223
import com.google.api.gax.rpc.OperationCallable;
2324
import com.google.api.gax.rpc.UnaryCallable;
2425
import com.google.cloud.shell.v1.stub.CloudShellServiceStub;
2526
import com.google.cloud.shell.v1.stub.CloudShellServiceStubSettings;
2627
import com.google.longrunning.Operation;
27-
import com.google.longrunning.OperationsClient;
2828
import java.io.IOException;
2929
import java.util.concurrent.TimeUnit;
3030
import javax.annotation.Generated;
@@ -100,13 +100,29 @@
100100
* CloudShellServiceClient.create(cloudShellServiceSettings);
101101
* }</pre>
102102
*
103+
* <p>To use REST (HTTP1.1/JSON) transport (instead of gRPC) for sending and receiving requests over
104+
* the wire:
105+
*
106+
* <pre>{@code
107+
* // This snippet has been automatically generated for illustrative purposes only.
108+
* // It may require modifications to work in your environment.
109+
* CloudShellServiceSettings cloudShellServiceSettings =
110+
* CloudShellServiceSettings.newBuilder()
111+
* .setTransportChannelProvider(
112+
* CloudShellServiceSettings.defaultHttpJsonTransportProviderBuilder().build())
113+
* .build();
114+
* CloudShellServiceClient cloudShellServiceClient =
115+
* CloudShellServiceClient.create(cloudShellServiceSettings);
116+
* }</pre>
117+
*
103118
* <p>Please refer to the GitHub repository's samples for more quickstart code snippets.
104119
*/
105120
@Generated("by gapic-generator-java")
106121
public class CloudShellServiceClient implements BackgroundResource {
107122
private final CloudShellServiceSettings settings;
108123
private final CloudShellServiceStub stub;
109-
private final OperationsClient operationsClient;
124+
private final OperationsClient httpJsonOperationsClient;
125+
private final com.google.longrunning.OperationsClient operationsClient;
110126

111127
/** Constructs an instance of CloudShellServiceClient with default settings. */
112128
public static final CloudShellServiceClient create() throws IOException {
@@ -126,7 +142,6 @@ public static final CloudShellServiceClient create(CloudShellServiceSettings set
126142
* Constructs an instance of CloudShellServiceClient, using the given stub for making calls. This
127143
* is for advanced usage - prefer using create(CloudShellServiceSettings).
128144
*/
129-
@BetaApi("A restructuring of stub classes is planned, so this may break in the future")
130145
public static final CloudShellServiceClient create(CloudShellServiceStub stub) {
131146
return new CloudShellServiceClient(stub);
132147
}
@@ -139,21 +154,23 @@ public static final CloudShellServiceClient create(CloudShellServiceStub stub) {
139154
protected CloudShellServiceClient(CloudShellServiceSettings settings) throws IOException {
140155
this.settings = settings;
141156
this.stub = ((CloudShellServiceStubSettings) settings.getStubSettings()).createStub();
142-
this.operationsClient = OperationsClient.create(this.stub.getOperationsStub());
157+
this.operationsClient =
158+
com.google.longrunning.OperationsClient.create(this.stub.getOperationsStub());
159+
this.httpJsonOperationsClient = OperationsClient.create(this.stub.getHttpJsonOperationsStub());
143160
}
144161

145-
@BetaApi("A restructuring of stub classes is planned, so this may break in the future")
146162
protected CloudShellServiceClient(CloudShellServiceStub stub) {
147163
this.settings = null;
148164
this.stub = stub;
149-
this.operationsClient = OperationsClient.create(this.stub.getOperationsStub());
165+
this.operationsClient =
166+
com.google.longrunning.OperationsClient.create(this.stub.getOperationsStub());
167+
this.httpJsonOperationsClient = OperationsClient.create(this.stub.getHttpJsonOperationsStub());
150168
}
151169

152170
public final CloudShellServiceSettings getSettings() {
153171
return settings;
154172
}
155173

156-
@BetaApi("A restructuring of stub classes is planned, so this may break in the future")
157174
public CloudShellServiceStub getStub() {
158175
return stub;
159176
}
@@ -162,10 +179,19 @@ public CloudShellServiceStub getStub() {
162179
* Returns the OperationsClient that can be used to query the status of a long-running operation
163180
* returned by another API method call.
164181
*/
165-
public final OperationsClient getOperationsClient() {
182+
public final com.google.longrunning.OperationsClient getOperationsClient() {
166183
return operationsClient;
167184
}
168185

186+
/**
187+
* Returns the OperationsClient that can be used to query the status of a long-running operation
188+
* returned by another API method call.
189+
*/
190+
@BetaApi
191+
public final OperationsClient getHttpJsonOperationsClient() {
192+
return httpJsonOperationsClient;
193+
}
194+
169195
// AUTO-GENERATED DOCUMENTATION AND METHOD.
170196
/**
171197
* Gets an environment. Returns NOT_FOUND if the environment does not exist.

java-shell/google-cloud-shell/src/main/java/com/google/cloud/shell/v1/CloudShellServiceSettings.java

+21-2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.google.api.gax.core.GoogleCredentialsProvider;
2222
import com.google.api.gax.core.InstantiatingExecutorProvider;
2323
import com.google.api.gax.grpc.InstantiatingGrpcChannelProvider;
24+
import com.google.api.gax.httpjson.InstantiatingHttpJsonChannelProvider;
2425
import com.google.api.gax.rpc.ApiClientHeaderProvider;
2526
import com.google.api.gax.rpc.ClientContext;
2627
import com.google.api.gax.rpc.ClientSettings;
@@ -148,11 +149,18 @@ public static GoogleCredentialsProvider.Builder defaultCredentialsProviderBuilde
148149
return CloudShellServiceStubSettings.defaultCredentialsProviderBuilder();
149150
}
150151

151-
/** Returns a builder for the default ChannelProvider for this service. */
152+
/** Returns a builder for the default gRPC ChannelProvider for this service. */
152153
public static InstantiatingGrpcChannelProvider.Builder defaultGrpcTransportProviderBuilder() {
153154
return CloudShellServiceStubSettings.defaultGrpcTransportProviderBuilder();
154155
}
155156

157+
/** Returns a builder for the default REST ChannelProvider for this service. */
158+
@BetaApi
159+
public static InstantiatingHttpJsonChannelProvider.Builder
160+
defaultHttpJsonTransportProviderBuilder() {
161+
return CloudShellServiceStubSettings.defaultHttpJsonTransportProviderBuilder();
162+
}
163+
156164
public static TransportChannelProvider defaultTransportChannelProvider() {
157165
return CloudShellServiceStubSettings.defaultTransportChannelProvider();
158166
}
@@ -162,11 +170,17 @@ public static ApiClientHeaderProvider.Builder defaultApiClientHeaderProviderBuil
162170
return CloudShellServiceStubSettings.defaultApiClientHeaderProviderBuilder();
163171
}
164172

165-
/** Returns a new builder for this class. */
173+
/** Returns a new gRPC builder for this class. */
166174
public static Builder newBuilder() {
167175
return Builder.createDefault();
168176
}
169177

178+
/** Returns a new REST builder for this class. */
179+
@BetaApi
180+
public static Builder newHttpJsonBuilder() {
181+
return Builder.createHttpJsonDefault();
182+
}
183+
170184
/** Returns a new builder for this class. */
171185
public static Builder newBuilder(ClientContext clientContext) {
172186
return new Builder(clientContext);
@@ -204,6 +218,11 @@ private static Builder createDefault() {
204218
return new Builder(CloudShellServiceStubSettings.newBuilder());
205219
}
206220

221+
@BetaApi
222+
private static Builder createHttpJsonDefault() {
223+
return new Builder(CloudShellServiceStubSettings.newHttpJsonBuilder());
224+
}
225+
207226
public CloudShellServiceStubSettings.Builder getStubSettingsBuilder() {
208227
return ((CloudShellServiceStubSettings.Builder) getStubSettings());
209228
}

java-shell/google-cloud-shell/src/main/java/com/google/cloud/shell/v1/stub/CloudShellServiceStub.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,11 @@
4747
public abstract class CloudShellServiceStub implements BackgroundResource {
4848

4949
public OperationsStub getOperationsStub() {
50-
throw new UnsupportedOperationException("Not implemented: getOperationsStub()");
50+
return null;
51+
}
52+
53+
public com.google.api.gax.httpjson.longrunning.stub.OperationsStub getHttpJsonOperationsStub() {
54+
return null;
5155
}
5256

5357
public UnaryCallable<GetEnvironmentRequest, Environment> getEnvironmentCallable() {

java-shell/google-cloud-shell/src/main/java/com/google/cloud/shell/v1/stub/CloudShellServiceStubSettings.java

+50-4
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@
2525
import com.google.api.gax.grpc.GrpcTransportChannel;
2626
import com.google.api.gax.grpc.InstantiatingGrpcChannelProvider;
2727
import com.google.api.gax.grpc.ProtoOperationTransformers;
28+
import com.google.api.gax.httpjson.GaxHttpJsonProperties;
29+
import com.google.api.gax.httpjson.HttpJsonTransportChannel;
30+
import com.google.api.gax.httpjson.InstantiatingHttpJsonChannelProvider;
2831
import com.google.api.gax.longrunning.OperationSnapshot;
2932
import com.google.api.gax.longrunning.OperationTimedPollAlgorithm;
3033
import com.google.api.gax.retrying.RetrySettings;
@@ -171,13 +174,17 @@ public UnaryCallSettings<RemovePublicKeyRequest, Operation> removePublicKeySetti
171174
return removePublicKeyOperationSettings;
172175
}
173176

174-
@BetaApi("A restructuring of stub classes is planned, so this may break in the future")
175177
public CloudShellServiceStub createStub() throws IOException {
176178
if (getTransportChannelProvider()
177179
.getTransportName()
178180
.equals(GrpcTransportChannel.getGrpcTransportName())) {
179181
return GrpcCloudShellServiceStub.create(this);
180182
}
183+
if (getTransportChannelProvider()
184+
.getTransportName()
185+
.equals(HttpJsonTransportChannel.getHttpJsonTransportName())) {
186+
return HttpJsonCloudShellServiceStub.create(this);
187+
}
181188
throw new UnsupportedOperationException(
182189
String.format(
183190
"Transport not supported: %s", getTransportChannelProvider().getTransportName()));
@@ -210,30 +217,56 @@ public static GoogleCredentialsProvider.Builder defaultCredentialsProviderBuilde
210217
.setUseJwtAccessWithScope(true);
211218
}
212219

213-
/** Returns a builder for the default ChannelProvider for this service. */
220+
/** Returns a builder for the default gRPC ChannelProvider for this service. */
214221
public static InstantiatingGrpcChannelProvider.Builder defaultGrpcTransportProviderBuilder() {
215222
return InstantiatingGrpcChannelProvider.newBuilder()
216223
.setMaxInboundMessageSize(Integer.MAX_VALUE);
217224
}
218225

226+
/** Returns a builder for the default REST ChannelProvider for this service. */
227+
@BetaApi
228+
public static InstantiatingHttpJsonChannelProvider.Builder
229+
defaultHttpJsonTransportProviderBuilder() {
230+
return InstantiatingHttpJsonChannelProvider.newBuilder();
231+
}
232+
219233
public static TransportChannelProvider defaultTransportChannelProvider() {
220234
return defaultGrpcTransportProviderBuilder().build();
221235
}
222236

223237
@BetaApi("The surface for customizing headers is not stable yet and may change in the future.")
224-
public static ApiClientHeaderProvider.Builder defaultApiClientHeaderProviderBuilder() {
238+
public static ApiClientHeaderProvider.Builder defaultGrpcApiClientHeaderProviderBuilder() {
225239
return ApiClientHeaderProvider.newBuilder()
226240
.setGeneratedLibToken(
227241
"gapic", GaxProperties.getLibraryVersion(CloudShellServiceStubSettings.class))
228242
.setTransportToken(
229243
GaxGrpcProperties.getGrpcTokenName(), GaxGrpcProperties.getGrpcVersion());
230244
}
231245

232-
/** Returns a new builder for this class. */
246+
@BetaApi("The surface for customizing headers is not stable yet and may change in the future.")
247+
public static ApiClientHeaderProvider.Builder defaultHttpJsonApiClientHeaderProviderBuilder() {
248+
return ApiClientHeaderProvider.newBuilder()
249+
.setGeneratedLibToken(
250+
"gapic", GaxProperties.getLibraryVersion(CloudShellServiceStubSettings.class))
251+
.setTransportToken(
252+
GaxHttpJsonProperties.getHttpJsonTokenName(),
253+
GaxHttpJsonProperties.getHttpJsonVersion());
254+
}
255+
256+
public static ApiClientHeaderProvider.Builder defaultApiClientHeaderProviderBuilder() {
257+
return CloudShellServiceStubSettings.defaultGrpcApiClientHeaderProviderBuilder();
258+
}
259+
260+
/** Returns a new gRPC builder for this class. */
233261
public static Builder newBuilder() {
234262
return Builder.createDefault();
235263
}
236264

265+
/** Returns a new REST builder for this class. */
266+
public static Builder newHttpJsonBuilder() {
267+
return Builder.createHttpJsonDefault();
268+
}
269+
237270
/** Returns a new builder for this class. */
238271
public static Builder newBuilder(ClientContext clientContext) {
239272
return new Builder(clientContext);
@@ -389,6 +422,19 @@ private static Builder createDefault() {
389422
return initDefaults(builder);
390423
}
391424

425+
private static Builder createHttpJsonDefault() {
426+
Builder builder = new Builder(((ClientContext) null));
427+
428+
builder.setTransportChannelProvider(defaultHttpJsonTransportProviderBuilder().build());
429+
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
430+
builder.setInternalHeaderProvider(defaultHttpJsonApiClientHeaderProviderBuilder().build());
431+
builder.setEndpoint(getDefaultEndpoint());
432+
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
433+
builder.setSwitchToMtlsEndpointAllowed(true);
434+
435+
return initDefaults(builder);
436+
}
437+
392438
private static Builder initDefaults(Builder builder) {
393439
builder
394440
.getEnvironmentSettings()

0 commit comments

Comments
 (0)