feat!: [dataform] remove deprecated v1alpha2 #11481
Conversation
| @@ -681,7 +681,6 @@ libraries: | |||
| product_documentation: https://cloud.google.com/dataform/docs | |||
| api_description: Help analytics teams manage data inside BigQuery using SQL. | |||
| GAPICs: | |||
| - proto_path: google/cloud/dataform/v1alpha2 | |||
There was a problem hiding this comment.
Thanks @zhumin8 for creating the fix! I thought our default behavior is that if the path does not exist, we would throw errors, @JoeWang1127 can you confirm it? If this is not expected, I think we should create an issue in the backlog to track it.
There was a problem hiding this comment.
It does throw no such file error, if that's what you mean: #11462 (comment)
But iiuc, we still need manually remove the deleted modules.
FYI - this came to my radar because some other testing 1PP group is doing.
There was a problem hiding this comment.
OK, that makes sense then. It was by design that we don't want to automatically remove a deprecated module, because it is technically a breaking change.
Can you please change the title to feat! to indicate that it's a breaking change?
zhumin8
changed the title
|
This should unblock the generation check failure in #11462. Thank you. |
v1alpha2version of dataform was removed in googleapis/googleapis@c3640e2This PR relects these changes in config yaml and delete the removed modules.