Skip to content

Commit 74b46c1

Browse files
address PR comments
1 parent 4e70f5a commit 74b46c1

File tree

3 files changed

+1
-48
lines changed

3 files changed

+1
-48
lines changed

.kokoro/build.sh

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -68,19 +68,3 @@ if [[ -n "${NOX_SESSION:-}" ]]; then
6868
else
6969
python3 -m nox
7070
fi
71-
# Find out if this package was modified.
72-
# Temporarily use Thea's fork of ci-diff-helper w/ Kokoro support.
73-
# python3.6 -m pip install --quiet git+https://github.com/theacodes/ci-diff-helper.git
74-
# python3.6 test_utils/scripts/get_target_packages_kokoro.py > ~/target_packages
75-
# cat ~/target_packages
76-
77-
# if [[ ! -n $(grep -x "$PACKAGE" ~/target_packages) ]]; then
78-
# echo "$PACKAGE was not modified, returning."
79-
# exit;
80-
# fi
81-
82-
# cd "$PACKAGE"
83-
84-
# Some system tests require indexes. Use gcloud to create them.
85-
gcloud auth activate-service-account --key-file=$GOOGLE_APPLICATION_CREDENTIALS --project=$PROJECT_ID
86-
#gcloud --quiet --verbosity=debug datastore indexes create tests/system/index.yaml

src/google_crc32c/__config__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def modify_path():
3434
from importlib_resources import files as _resources_files # type: ignore
3535
extra_dll_dir = str(_resources_files("google_crc32c") / "extra-dll")
3636
if os.path.isdir(extra_dll_dir):
37-
# Python 3.6, 3.7 use path
37+
# Python 3.7 use path
3838
os.environ["PATH"] = path + os.pathsep + extra_dll_dir
3939
# Python 3.8+ uses add_dll_directory.
4040
if sys.version_info[0] == 3 and sys.version_info[1] >= 8:

tests/conftest.py

Lines changed: 0 additions & 31 deletions
This file was deleted.

0 commit comments

Comments
 (0)