Skip to content

Commit 77727a8

Browse files
committed
Revert some cleanups
1 parent cbe8ab5 commit 77727a8

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

src/main/java/com/google/api/generator/gapic/composer/Composer.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,10 @@ public static List<GapicClass> generateMockClasses(GapicContext context, List<Se
153153
s -> {
154154
if (context.transport() == Transport.REST) {
155155
// REST transport tests do not use mock services.
156-
} else if (context.transport() == Transport.GRPC
157-
|| context.transport() == Transport.GRPC_REST) {
156+
} else if (context.transport() == Transport.GRPC) {
157+
clazzes.add(MockServiceClassComposer.instance().generate(context, s));
158+
clazzes.add(MockServiceImplClassComposer.instance().generate(context, s));
159+
} else if (context.transport() == Transport.GRPC_REST) {
158160
clazzes.add(MockServiceClassComposer.instance().generate(context, s));
159161
clazzes.add(MockServiceImplClassComposer.instance().generate(context, s));
160162
}

src/main/java/com/google/api/generator/gapic/composer/common/AbstractTransportServiceStubClassComposer.java

+9-6
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,8 @@ public GapicClass generate(GapicContext context, Service service) {
202202
.setAnnotations(createClassAnnotations(service))
203203
.setScope(ScopeNode.PUBLIC)
204204
.setName(className)
205-
.setExtendsType(typeStore.get(ClassNames.getServiceStubClassName(service)))
205+
.setExtendsType(
206+
typeStore.get(getTransportContext().classNames().getServiceStubClassName(service)))
206207
.setStatements(classStatements)
207208
.setMethods(
208209
createClassMethods(
@@ -477,7 +478,8 @@ protected List<MethodDefinition> createStaticCreatorMethods(
477478
argList ->
478479
NewObjectExpr.builder().setType(creatorMethodReturnType).setArguments(argList).build();
479480

480-
TypeNode stubSettingsType = typeStore.get(ClassNames.getServiceStubSettingsClassName(service));
481+
TypeNode stubSettingsType =
482+
typeStore.get(getTransportContext().classNames().getServiceStubSettingsClassName(service));
481483
VariableExpr settingsVarExpr =
482484
VariableExpr.withVariable(
483485
Variable.builder().setName("settings").setType(stubSettingsType).build());
@@ -540,7 +542,8 @@ protected List<MethodDefinition> createConstructorMethods(
540542
Map<String, VariableExpr> classMemberVarExprs,
541543
Map<String, VariableExpr> callableClassMemberVarExprs,
542544
Map<String, VariableExpr> protoMethodNameToDescriptorVarExprs) {
543-
TypeNode stubSettingsType = typeStore.get(ClassNames.getServiceStubSettingsClassName(service));
545+
TypeNode stubSettingsType =
546+
typeStore.get(getTransportContext().classNames().getServiceStubSettingsClassName(service));
544547
VariableExpr settingsVarExpr =
545548
VariableExpr.withVariable(
546549
Variable.builder().setName("settings").setType(stubSettingsType).build());
@@ -1054,8 +1057,8 @@ private TypeStore createDynamicTypes(Service service, String stubPakkage) {
10541057
stubPakkage,
10551058
Arrays.asList(
10561059
getTransportContext().classNames().getTransportServiceStubClassName(service),
1057-
ClassNames.getServiceStubSettingsClassName(service),
1058-
ClassNames.getServiceStubClassName(service),
1060+
getTransportContext().classNames().getServiceStubSettingsClassName(service),
1061+
getTransportContext().classNames().getServiceStubClassName(service),
10591062
getTransportContext()
10601063
.classNames()
10611064
.getTransportServiceCallableFactoryClassName(service)));
@@ -1067,7 +1070,7 @@ private TypeStore createDynamicTypes(Service service, String stubPakkage) {
10671070
.map(m -> String.format(PAGED_RESPONSE_TYPE_NAME_PATTERN, m.name()))
10681071
.collect(Collectors.toList()),
10691072
true,
1070-
ClassNames.getServiceClientClassName(service));
1073+
getTransportContext().classNames().getServiceClientClassName(service));
10711074
return typeStore;
10721075
}
10731076

0 commit comments

Comments
 (0)