Skip to content

Commit c19dd80

Browse files
authored
feat!: Support Node 18+ (#2011)
* feat!: Support Node 18+ * chore: Additional Node 18 upgrades * chore: don't change test fixtures * feat: Move kokoro directories to 18 * chore: Update checkout and setup-node to v4 - https://github.com/actions/checkout/releases/tag/v4.0.0 - https://github.com/actions/setup-node/releases/tag/v4.0.0
1 parent 38fa49f commit c19dd80

File tree

20 files changed

+24
-24
lines changed

20 files changed

+24
-24
lines changed

synthtool/gcp/templates/node_library/.github/workflows/ci.yaml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ jobs:
99
runs-on: ubuntu-latest
1010
strategy:
1111
matrix:
12-
node: [{{metadata['engine'] | int}}, {{metadata['engine'] | int+2}}, {{metadata['engine'] | int+4}}, {{metadata['engine'] | int+6}}]
12+
node: [{{metadata['engine'] | int}}, {{metadata['engine'] | int+2}}, {{metadata['engine'] | int+4}}}]
1313
steps:
14-
- uses: actions/checkout@v3
15-
- uses: actions/setup-node@v3
14+
- uses: actions/checkout@v4
15+
- uses: actions/setup-node@v4
1616
with:
1717
node-version: ${{ '{{' }} matrix.node {{ '}}' }}
1818
- run: node --version
@@ -29,30 +29,30 @@ jobs:
2929
windows:
3030
runs-on: windows-latest
3131
steps:
32-
- uses: actions/checkout@v3
33-
- uses: actions/setup-node@v3
32+
- uses: actions/checkout@v4
33+
- uses: actions/setup-node@v4
3434
with:
35-
node-version: 14
35+
node-version: 18
3636
- run: npm install --engine-strict
3737
- run: npm test
3838
env:
3939
MOCHA_THROW_DEPRECATION: false
4040
lint:
4141
runs-on: ubuntu-latest
4242
steps:
43-
- uses: actions/checkout@v3
44-
- uses: actions/setup-node@v3
43+
- uses: actions/checkout@v4
44+
- uses: actions/setup-node@v4
4545
with:
46-
node-version: 14
46+
node-version: 18
4747
- run: npm install
4848
- run: npm run lint
4949
docs:
5050
runs-on: ubuntu-latest
5151
steps:
52-
- uses: actions/checkout@v3
53-
- uses: actions/setup-node@v3
52+
- uses: actions/checkout@v4
53+
- uses: actions/setup-node@v4
5454
with:
55-
node-version: 14
55+
node-version: 18
5656
- run: npm install
5757
- run: npm run docs
5858
- uses: JustinBeckwith/linkinator-action@v1

synthtool/gcp/templates/node_library/.kokoro/common.cfg

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

synthtool/gcp/templates/node_library/.kokoro/continuous/node14/common.cfg renamed to synthtool/gcp/templates/node_library/.kokoro/continuous/node18/common.cfg

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

synthtool/gcp/templates/node_library/.kokoro/presubmit/node14/common.cfg renamed to synthtool/gcp/templates/node_library/.kokoro/presubmit/node18/common.cfg

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

synthtool/gcp/templates/node_library/.kokoro/release/docs-devsite.cfg

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

synthtool/gcp/templates/node_library/.kokoro/release/docs.cfg

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

synthtool/gcp/templates/node_library/.kokoro/release/docs.sh

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

synthtool/gcp/templates/node_library/.kokoro/release/publish.cfg

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

synthtool/gcp/templates/node_library/.kokoro/samples-test.sh

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

synthtool/gcp/templates/node_library/.kokoro/system-test.sh

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

synthtool/gcp/templates/node_library/.kokoro/test.bat

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

synthtool/gcp/templates/node_library/.kokoro/test.sh

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

synthtool/gcp/templates/node_library/.kokoro/trampoline_v2.sh

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)