Skip to content

Commit 654a995

Browse files
committed
cleanup: Remove unnecessary codegen config
1 parent 58c61c1 commit 654a995

File tree

5 files changed

+24
-5
lines changed

5 files changed

+24
-5
lines changed

dom/event/event.go

+1
Original file line numberDiff line numberDiff line change
@@ -67,3 +67,4 @@ func (e *Event) PreventDefault() { e.cancelled = true }
6767
func (e *Event) EventPhase() EventPhase { return e.phase }
6868
func (e *Event) Target() EventTarget { return e.target }
6969
func (e *Event) CurrentTarget() EventTarget { return e.currentTarget }
70+
func (e *Event) DefaultPrevented() bool { return e.cancelled }

dom/event/event_target.go

-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ func (e *eventTarget) AddEventListener(
9292
listener := e.createListener(handler, options)
9393
log.Debug(e.logger(), "AddEventListener", "EventType", eventType)
9494
// TODO: Handle options
95-
// - once
9695
// - passive. Defaults to false,
9796
// - signal - TODO: Implement AbortSignal
9897
// Browser specific

internal/code-gen/script-wrappers/configuration/dom_configuration.go

-4
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,8 @@ func configureDOMEvent(domSpecs *WebIdlConfiguration) {
4141
event.Method("composedPath").Ignore()
4242
event.Method("stopImmediatePropagation").Ignore()
4343
event.Method("isTrusted").Ignore()
44-
event.Method("CancelBubble").Ignore()
4544
event.Method("cancelBubble").Ignore()
46-
event.Method("TimeStamp").Ignore()
4745
event.Method("timeStamp").Ignore()
48-
event.Method("ReturnValue").Ignore()
4946
event.Method("returnValue").Ignore()
5047
event.Method("srcElement").Ignore()
51-
event.Method("defaultPrevented").Ignore()
5248
}

scripting/gojahost/event_generated.go

+8
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ func (w eventWrapper) initializePrototype(prototype *g.Object, vm *g.Runtime) {
2020
prototype.DefineAccessorProperty("eventPhase", w.ctx.vm.ToValue(w.eventPhase), nil, g.FLAG_TRUE, g.FLAG_TRUE)
2121
prototype.DefineAccessorProperty("bubbles", w.ctx.vm.ToValue(w.bubbles), nil, g.FLAG_TRUE, g.FLAG_TRUE)
2222
prototype.DefineAccessorProperty("cancelable", w.ctx.vm.ToValue(w.cancelable), nil, g.FLAG_TRUE, g.FLAG_TRUE)
23+
prototype.DefineAccessorProperty("defaultPrevented", w.ctx.vm.ToValue(w.defaultPrevented), nil, g.FLAG_TRUE, g.FLAG_TRUE)
2324
}
2425

2526
func (w eventWrapper) stopPropagation(c g.FunctionCall) g.Value {
@@ -49,3 +50,10 @@ func (w eventWrapper) currentTarget(c g.FunctionCall) g.Value {
4950
result := instance.CurrentTarget()
5051
return w.toEventTarget(result)
5152
}
53+
54+
func (w eventWrapper) defaultPrevented(c g.FunctionCall) g.Value {
55+
log.Debug(w.logger(c), "V8 Function call: Event.defaultPrevented")
56+
instance := w.getInstance(c)
57+
result := instance.DefaultPrevented()
58+
return w.toBoolean(result)
59+
}

scripting/v8host/event_generated.go

+15
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ func (w eventV8Wrapper) installPrototype(prototypeTmpl *v8.ObjectTemplate) {
5353
v8.NewFunctionTemplateWithError(iso, w.cancelable),
5454
nil,
5555
v8.None)
56+
prototypeTmpl.SetAccessorProperty("defaultPrevented",
57+
v8.NewFunctionTemplateWithError(iso, w.defaultPrevented),
58+
nil,
59+
v8.None)
5660
}
5761

5862
func (w eventV8Wrapper) Constructor(info *v8.FunctionCallbackInfo) (*v8.Value, error) {
@@ -111,3 +115,14 @@ func (w eventV8Wrapper) currentTarget(info *v8.FunctionCallbackInfo) (*v8.Value,
111115
result := instance.CurrentTarget()
112116
return w.toNullableEventTarget(ctx, result)
113117
}
118+
119+
func (w eventV8Wrapper) defaultPrevented(info *v8.FunctionCallbackInfo) (*v8.Value, error) {
120+
log.Debug(w.logger(info), "V8 Function call: Event.defaultPrevented")
121+
ctx := w.mustGetContext(info)
122+
instance, err := w.getInstance(info)
123+
if err != nil {
124+
return nil, err
125+
}
126+
result := instance.DefaultPrevented()
127+
return w.toBoolean(ctx, result)
128+
}

0 commit comments

Comments
 (0)