Skip to content

Commit 927b417

Browse files
committed
refactor(codegen): Harmonise callback body intf
1 parent 8a5cbb5 commit 927b417

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

internal/code-gen/script-wrappers/goja_generators.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -134,15 +134,15 @@ func (gen GojaTargetGenerators) CreateMethodCallback(
134134
Name: op.CallbackMethodName(),
135135
Args: g.Arg(callArgument, gojaFc),
136136
RtnTypes: g.List(gojaValue),
137-
Body: gen.CreateWrapperMethodBody(data, op, callArgument),
137+
Body: gen.CreateMethodCallbackBody(data, op),
138138
})
139139
}
140140

141-
func (gen GojaTargetGenerators) CreateWrapperMethodBody(
141+
func (gen GojaTargetGenerators) CreateMethodCallbackBody(
142142
data ESConstructorData,
143143
op ESOperation,
144-
callArgument g.Generator,
145144
) g.Generator {
145+
callArgument := g.Id("c")
146146
if op.NotImplemented {
147147
msg := fmt.Sprintf(
148148
"%s.%s: Not implemented. Create an issue: %s",

internal/code-gen/script-wrappers/v8_generators.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,11 @@ func (gen V8TargetGenerators) CreateMethodCallback(
124124
Name: op.CallbackMethodName(),
125125
Args: g.Arg(g.Id("info"), v8FunctionCallbackInfoPtr),
126126
RtnTypes: g.List(v8Value, g.Id("error")),
127-
Body: CreateV8FunctionTemplateCallbackBody(data, op),
127+
Body: gen.CreateMethodCallbackBody(data, op),
128128
})
129129
}
130130

131-
func CreateV8FunctionTemplateCallbackBody(
131+
func (gen V8TargetGenerators) CreateMethodCallbackBody(
132132
data ESConstructorData,
133133
op ESOperation,
134134
) JenGenerator {

0 commit comments

Comments
 (0)