Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elimination of Bootstrap Class #14021

Open
jdaugherty opened this issue Feb 13, 2025 · 1 comment
Open

Elimination of Bootstrap Class #14021

jdaugherty opened this issue Feb 13, 2025 · 1 comment

Comments

@jdaugherty
Copy link
Contributor

Issue description

As we have gone through the upgrade of Grails 7, we have noticed a lot of empty / default generated files. One of Grail's core principles is convention over configuration. The default, empty Bootstrap file is a good example of not adhering to this principle. However, for functional testing, we need to make sure there is test coverage for grails supported features.

We could remove the empty Bootstrap classes, and leave them in one spot with a comment on why an empty one exists. However, after investigating the changes to the Application class, Spring has taken an alternative approach. Spring uses the application class as a bootstrap class. I can't think of a reason why we couldn't do something similar.

This ticket would remove the Bootstrap.groovy support and integrate it into the Application class instance. This is a post 7.0 goal.

@jdaugherty
Copy link
Contributor Author

This is somewhat related to #14012

doWithSpring already exists on the application class, so this would simplify that setup.

As part of this cleanup, I would suggest changing the closures like doWithSpring, init, etc to be methods so that the GrailsAutoConfiguration class can define base implementations so developers can have better IDE support of what's possible to define.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant