Merge pull request #636 from dackroyd/refactor-validation-test-json

Refactor Validation Tests JSON

Author: pavelnikolov

internal/validation/testdata/export.ts

@@ -1,4 +1,5 @@
 import * as fs from 'node:fs';
+import { createHash } from 'crypto';
 import { printSchema } from 'graphql/src/utilities/printSchema.js';
 import { schemas, testCases } from 'graphql/src/validation/__tests__/harness.js';
 
@@ -36,10 +37,31 @@ import 'graphql/src/validation/__tests__/VariablesAreInputTypesRule-test.js';
 // require('graphql/src/validation/__tests__/VariablesDefaultValueAllowed-test');
 import 'graphql/src/validation/__tests__/VariablesInAllowedPositionRule-test.js';
 
-let output = JSON.stringify({
-	schemas: schemas().map(s => printSchema(s)),
-	tests: testCases(),
-}, null, 2)
+// Schema index in the source array can be unstable, as its dependent on the order they are used in the registered test
+// files. The SHA256 of the schema will change if there are any changes to the content, but is a better reference than
+// the schema indexes all changing when a new schema is inserted.
+let s = schemas().map(s => {
+  const sdl = printSchema(s)
+  const id = createHash('sha256').update(sdl).digest('base64');
+  const v: { id: string; sdl: string; } = {id: id, sdl: sdl};
+  return v;
+});
+
+const tests = testCases().map(c => {
+  const schema = s[c.schema];
+  return {
+    name: c.name,
+	  rule: c.rule,
+	  schema: schema.id,
+	  query: c.query,
+	  errors: c.errors,
+  }
+});
+
+// Order based on the schema string to provide semi-stable ordering
+s = s.sort((a, b) => a.sdl.localeCompare(b.sdl));
+
+let output = JSON.stringify({schemas: s, tests: tests}, null, 2)
 output = output.replace(/ Did you mean to use an inline fragment on [^?]*\?/g, '');
 // Ignore suggested types in errors, which graphql-go does not currently produce.
 output = output.replace(/ Did you mean \\"[A-Z].*\"\?/g, '');