Skip to content

Commit 0dd0bbc

Browse files
svens-s390Alexander Gordeev
authored andcommitted
s390/vdso: check for undefined symbols after build
When adding an undefined symbol the build still succeeds, but userspace is crashing trying to execute vdso because the undefined symbol is not resolved. Add the check for undefined symbols to prevent this. Signed-off-by: Sven Schnelle <[email protected]> Acked-by: Heiko Carstens <[email protected]> Signed-off-by: Alexander Gordeev <[email protected]>
1 parent 51f513f commit 0dd0bbc

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

arch/s390/kernel/vdso32/Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,11 @@ KCSAN_SANITIZE := n
4040
# Force dependency (incbin is bad)
4141
$(obj)/vdso32_wrapper.o : $(obj)/vdso32.so
4242

43+
quiet_cmd_vdso_and_check = VDSO $@
44+
cmd_vdso_and_check = $(cmd_ld); $(cmd_vdso_check)
45+
4346
$(obj)/vdso32.so.dbg: $(src)/vdso32.lds $(obj-vdso32) FORCE
44-
$(call if_changed,ld)
47+
$(call if_changed,vdso_and_check)
4548

4649
# strip rule for the .so file
4750
$(obj)/%.so: OBJCOPYFLAGS := -S

arch/s390/kernel/vdso64/Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,12 @@ KCSAN_SANITIZE := n
4444
# Force dependency (incbin is bad)
4545
$(obj)/vdso64_wrapper.o : $(obj)/vdso64.so
4646

47+
quiet_cmd_vdso_and_check = VDSO $@
48+
cmd_vdso_and_check = $(cmd_ld); $(cmd_vdso_check)
49+
4750
# link rule for the .so file, .lds has to be first
4851
$(obj)/vdso64.so.dbg: $(src)/vdso64.lds $(obj-vdso64) $(obj-cvdso64) FORCE
49-
$(call if_changed,ld)
52+
$(call if_changed,vdso_and_check)
5053

5154
# strip rule for the .so file
5255
$(obj)/%.so: OBJCOPYFLAGS := -S

0 commit comments

Comments
 (0)