Added Address type #442
Closed
Added Address type #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Needs Triage
in Nomad - Community Issues Triage
|
Additional info:
|
|
Thanks for this PR @TheDevtop. But I'm going to close this in lieu of #402 as that has the correct JSON tags. |
github-project-automation
bot
moved this from Needs Triage
to Done
in Nomad - Community Issues Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type enables the plugin to properly handle secondary IP addresses.
As the current Podman API requires ref.
Origins
The DHCP server in my network prioritizes IPv6 over IPv4. When starting a podman container via the CNI (macvlan+dhcp) it would error
json: cannot unmarshal object into Go struct field Inspect Network Settings.Network Settings.S econdaryIPv6Addresses of type string.After some research I found out that Podman indeed returns a list of
Addressinstead of a single string.