Remove immutable annotation from engine_version to support version upgrade. (#13149) (#9534)

[upstream:26817a8f129c2c0c6b5ce68b45346e2efcefa380]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

Diff for: .changelog/13149.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+memorystore: added update support for `engine_version` field in `google_memorystore_instance` resource
+```

Diff for: google-beta/services/memorystore/resource_memorystore_instance.go

@@ -109,8 +109,7 @@ IAM_AUTH`,
 				Type:        schema.TypeString,
 				Computed:    true,
 				Optional:    true,
-				ForceNew:    true,
-				Description: `Optional. Immutable. Engine version of the instance.`,
+				Description: `Optional. Engine version of the instance.`,
 			},
 			"labels": {
 				Type:     schema.TypeMap,
@@ -877,6 +876,12 @@ func resourceMemorystoreInstanceUpdate(d *schema.ResourceData, meta interface{})
 	} else if v, ok := d.GetOkExists("persistence_config"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, persistenceConfigProp)) {
 		obj["persistenceConfig"] = persistenceConfigProp
 	}
+	engineVersionProp, err := expandMemorystoreInstanceEngineVersion(d.Get("engine_version"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("engine_version"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, engineVersionProp)) {
+		obj["engineVersion"] = engineVersionProp
+	}
 	engineConfigsProp, err := expandMemorystoreInstanceEngineConfigs(d.Get("engine_configs"), d, config)
 	if err != nil {
 		return err
@@ -922,6 +927,10 @@ func resourceMemorystoreInstanceUpdate(d *schema.ResourceData, meta interface{})
 		updateMask = append(updateMask, "persistenceConfig")
 	}
 
+	if d.HasChange("engine_version") {
+		updateMask = append(updateMask, "engineVersion")
+	}
+
 	if d.HasChange("engine_configs") {
 		updateMask = append(updateMask, "engineConfigs")
 	}

Diff for: google-beta/services/memorystore/resource_memorystore_instance_test.go

@@ -188,6 +188,49 @@ func TestAccMemorystoreInstance_updateDeletionProtection(t *testing.T) {
 	})
 }
 
+// Validate that engine version is updated for the cluster
+func TestAccMemorystoreInstance_updateEngineVersion(t *testing.T) {
+	t.Parallel()
+
+	name := fmt.Sprintf("tf-test-%d", acctest.RandInt(t))
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckMemorystoreInstanceDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				// create cluster with engine version 7.2
+				Config: createOrUpdateMemorystoreInstance(&InstanceParams{
+					name:                 name,
+					shardCount:           3,
+					zoneDistributionMode: "MULTI_ZONE",
+					engineVersion:        "VALKEY_7_2",
+				}),
+			},
+			{
+				ResourceName:      "google_memorystore_instance.test",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+			{
+				// update cluster with engine version 8.0
+				Config: createOrUpdateMemorystoreInstance(&InstanceParams{
+					name:                 name,
+					shardCount:           3,
+					zoneDistributionMode: "MULTI_ZONE",
+					engineVersion:        "VALKEY_8_0",
+				}),
+			},
+			{
+				ResourceName:      "google_memorystore_instance.test",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
 // Validate that persistence config is updated for the cluster
 func TestAccMemorystoreInstance_updatePersistence(t *testing.T) {
 	t.Parallel()
@@ -236,6 +279,7 @@ type InstanceParams struct {
 	zone                      string
 	deletionProtectionEnabled bool
 	persistenceMode           string
+	engineVersion             string
 }
 
 func createOrUpdateMemorystoreInstance(params *InstanceParams) string {
@@ -280,6 +324,7 @@ resource "google_memorystore_instance" "test" {
             project_id = data.google_project.project.project_id
 	}
     deletion_protection_enabled = %t
+	engine_version = "%s"
 	engine_configs = {
 		%s
 	}
@@ -316,5 +361,5 @@ resource "google_compute_network" "producer_net" {
 
 data "google_project" "project" {
 }
-`, params.name, params.replicaCount, params.shardCount, params.nodeType, params.deletionProtectionEnabled, strBuilder.String(), zoneDistributionConfigBlock, persistenceBlock, lifecycleBlock, params.name, params.name, params.name)
+`, params.name, params.replicaCount, params.shardCount, params.nodeType, params.deletionProtectionEnabled, params.engineVersion, strBuilder.String(), zoneDistributionConfigBlock, persistenceBlock, lifecycleBlock, params.name, params.name, params.name)
 }

Diff for: website/docs/r/memorystore_instance.html.markdown

@@ -280,7 +280,7 @@ The following arguments are supported:
 
 * `engine_version` -
   (Optional)
-  Optional. Immutable. Engine version of the instance.
+  Optional. Engine version of the instance.
 
 * `engine_configs` -
   (Optional)