Skip to content

Commit 225dcd6

Browse files
Add increased length & Unicode tagkey and tagvalue shortname support (#11827) (#8324)
[upstream:faf28013d0c42a059c4c63ed89558ce2900369c3] Signed-off-by: Modular Magician <[email protected]>
1 parent b902238 commit 225dcd6

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

.changelog/11827.txt

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
tags: increased maximum accepted input length for the `short_name` field in `google_tags_tag_key` and `google_tags_tag_value` resources
3+
```

google-beta/services/tags/resource_tags_tag_key.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,10 @@ func ResourceTagsTagKey() *schema.Resource {
6262
Type: schema.TypeString,
6363
Required: true,
6464
ForceNew: true,
65-
ValidateFunc: validation.StringLenBetween(1, 63),
65+
ValidateFunc: validation.StringLenBetween(1, 256),
6666
Description: `Input only. The user friendly name for a TagKey. The short name should be unique for TagKeys within the same tag namespace.
6767
68-
The short name must be 1-63 characters, beginning and ending with an alphanumeric character ([a-z0-9A-Z]) with dashes (-), underscores (_), dots (.), and alphanumerics between.`,
68+
The short name can have a maximum length of 256 characters. The permitted character set for the shortName includes all UTF-8 encoded Unicode characters except single quotes ('), double quotes ("), backslashes (\\), and forward slashes (/).`,
6969
},
7070
"description": {
7171
Type: schema.TypeString,

google-beta/services/tags/resource_tags_tag_value.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,10 @@ func ResourceTagsTagValue() *schema.Resource {
6060
Type: schema.TypeString,
6161
Required: true,
6262
ForceNew: true,
63-
ValidateFunc: validation.StringLenBetween(1, 63),
63+
ValidateFunc: validation.StringLenBetween(1, 256),
6464
Description: `Input only. User-assigned short name for TagValue. The short name should be unique for TagValues within the same parent TagKey.
6565
66-
The short name must be 63 characters or less, beginning and ending with an alphanumeric character ([a-z0-9A-Z]) with dashes (-), underscores (_), dots (.), and alphanumerics between.`,
66+
The short name can have a maximum length of 256 characters. The permitted character set for the shortName includes all UTF-8 encoded Unicode characters except single quotes ('), double quotes ("), backslashes (\\), and forward slashes (/).`,
6767
},
6868
"description": {
6969
Type: schema.TypeString,

website/docs/r/tags_tag_key.html.markdown

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ The following arguments are supported:
5151
* `short_name` -
5252
(Required)
5353
Input only. The user friendly name for a TagKey. The short name should be unique for TagKeys within the same tag namespace.
54-
The short name must be 1-63 characters, beginning and ending with an alphanumeric character ([a-z0-9A-Z]) with dashes (-), underscores (_), dots (.), and alphanumerics between.
54+
The short name can have a maximum length of 256 characters. The permitted character set for the shortName includes all UTF-8 encoded Unicode characters except single quotes ('), double quotes ("), backslashes (\\), and forward slashes (/).
5555

5656

5757
- - -

website/docs/r/tags_tag_value.html.markdown

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ The following arguments are supported:
5757
* `short_name` -
5858
(Required)
5959
Input only. User-assigned short name for TagValue. The short name should be unique for TagValues within the same parent TagKey.
60-
The short name must be 63 characters or less, beginning and ending with an alphanumeric character ([a-z0-9A-Z]) with dashes (-), underscores (_), dots (.), and alphanumerics between.
60+
The short name can have a maximum length of 256 characters. The permitted character set for the shortName includes all UTF-8 encoded Unicode characters except single quotes ('), double quotes ("), backslashes (\\), and forward slashes (/).
6161

6262

6363
- - -

0 commit comments

Comments
 (0)