add tiering_policy to volume replication create (#13515) (#9716)

[upstream:0c08ea13fb8cae0839dd6d98a781a566b4f96a97]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/13515.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+netapp: added `tiering_policy` to google_netapp_volume_replication resource
+```

google-beta/services/netapp/resource_netapp_volume.go

@@ -437,7 +437,7 @@ To disable automatic snapshot creation you have to remove the whole snapshot_pol
 						"cooling_threshold_days": {
 							Type:     schema.TypeInt,
 							Optional: true,
-							Description: `Optional. Time in days to mark the volume's data block as cold and make it eligible for tiering, can be range from 7-183.
+							Description: `Optional. Time in days to mark the volume's data block as cold and make it eligible for tiering, can be range from 2-183.
 Default is 31.`,
 						},
 						"tier_action": {

google-beta/services/netapp/resource_netapp_volume_replication.go

@@ -165,6 +165,29 @@ func ResourceNetappVolumeReplication() *schema.Resource {
 							ForceNew:    true,
 							Description: `Share name for destination volume. If not specified, name of source volume's share name will be used.`,
 						},
+						"tiering_policy": {
+							Type:        schema.TypeList,
+							Optional:    true,
+							Description: `Tiering policy for the volume.`,
+							MaxItems:    1,
+							Elem: &schema.Resource{
+								Schema: map[string]*schema.Schema{
+									"cooling_threshold_days": {
+										Type:     schema.TypeInt,
+										Optional: true,
+										Description: `Optional. Time in days to mark the volume's data block as cold and make it eligible for tiering, can be range from 2-183.
+Default is 31.`,
+									},
+									"tier_action": {
+										Type:         schema.TypeString,
+										Optional:     true,
+										ValidateFunc: verify.ValidateEnum([]string{"ENABLED", "PAUSED", ""}),
+										Description:  `Optional. Flag indicating if the volume has tiering policy enable/pause. Default is PAUSED. Default value: "PAUSED" Possible values: ["ENABLED", "PAUSED"]`,
+										Default:      "PAUSED",
+									},
+								},
+							},
+						},
 						"volume_id": {
 							Type:        schema.TypeString,
 							Computed:    true,
@@ -1096,6 +1119,13 @@ func expandNetappVolumeReplicationDestinationVolumeParameters(v interface{}, d t
 		transformed["description"] = transformedDescription
 	}
 
+	transformedTieringPolicy, err := expandNetappVolumeReplicationDestinationVolumeParametersTieringPolicy(original["tiering_policy"], d, config)
+	if err != nil {
+		return nil, err
+	} else if val := reflect.ValueOf(transformedTieringPolicy); val.IsValid() && !tpgresource.IsEmptyValue(val) {
+		transformed["tieringPolicy"] = transformedTieringPolicy
+	}
+
 	return transformed, nil
 }
 
@@ -1115,6 +1145,40 @@ func expandNetappVolumeReplicationDestinationVolumeParametersDescription(v inter
 	return v, nil
 }
 
+func expandNetappVolumeReplicationDestinationVolumeParametersTieringPolicy(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	l := v.([]interface{})
+	if len(l) == 0 || l[0] == nil {
+		return nil, nil
+	}
+	raw := l[0]
+	original := raw.(map[string]interface{})
+	transformed := make(map[string]interface{})
+
+	transformedCoolingThresholdDays, err := expandNetappVolumeReplicationDestinationVolumeParametersTieringPolicyCoolingThresholdDays(original["cooling_threshold_days"], d, config)
+	if err != nil {
+		return nil, err
+	} else if val := reflect.ValueOf(transformedCoolingThresholdDays); val.IsValid() && !tpgresource.IsEmptyValue(val) {
+		transformed["coolingThresholdDays"] = transformedCoolingThresholdDays
+	}
+
+	transformedTierAction, err := expandNetappVolumeReplicationDestinationVolumeParametersTieringPolicyTierAction(original["tier_action"], d, config)
+	if err != nil {
+		return nil, err
+	} else if val := reflect.ValueOf(transformedTierAction); val.IsValid() && !tpgresource.IsEmptyValue(val) {
+		transformed["tierAction"] = transformedTierAction
+	}
+
+	return transformed, nil
+}
+
+func expandNetappVolumeReplicationDestinationVolumeParametersTieringPolicyCoolingThresholdDays(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
+func expandNetappVolumeReplicationDestinationVolumeParametersTieringPolicyTierAction(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandNetappVolumeReplicationDescription(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
 	return v, nil
 }

google-beta/services/netapp/resource_netapp_volume_replication_generated_meta.yaml

@@ -13,6 +13,8 @@ fields:
   - field: 'destination_volume_parameters.description'
   - field: 'destination_volume_parameters.share_name'
   - field: 'destination_volume_parameters.storage_pool'
+  - field: 'destination_volume_parameters.tiering_policy.cooling_threshold_days'
+  - field: 'destination_volume_parameters.tiering_policy.tier_action'
   - field: 'destination_volume_parameters.volume_id'
   - field: 'effective_labels'
     provider_only: true

google-beta/services/netapp/resource_netapp_volume_replication_generated_test.go

@@ -77,6 +77,7 @@ resource "google_netapp_storage_pool" "destination_pool" {
   service_level = "PREMIUM"
   capacity_gib  = 2048
   network       = data.google_compute_network.default.id
+  allow_auto_tiering = true
 }
 
 resource "google_netapp_volume" "source_volume" {
@@ -105,6 +106,10 @@ resource "google_netapp_volume_replication" "test_replication" {
     # simplifies implementing client failover concepts
     share_name  = "tf-test-source-volume%{random_suffix}"
     description = "This is a replicated volume"
+    tiering_policy {
+        cooling_threshold_days = 20
+        tier_action = "ENABLED"
+    }
   }
   # WARNING: Setting delete_destination_volume to true, will delete the
   # CURRENT destination volume if the replication is deleted. Omit the field 

google-beta/services/netapp/resource_netapp_volume_replication_test.go

@@ -87,6 +87,7 @@ resource "google_netapp_storage_pool" "destination_pool" {
   service_level = "PREMIUM"
   capacity_gib  = 2048
   network       = data.google_compute_network.default.id
+  allow_auto_tiering = true
 }
 
 resource "google_netapp_volume" "source_volume" {
@@ -114,6 +115,10 @@ resource "google_netapp_volume_replication" "test_replication" {
     # simplifies implementing client failover concepts
     share_name  = "tf-test-source-volume%{random_suffix}"
     description = "This is a replicated volume"
+    tiering_policy {
+      cooling_threshold_days = 20
+      tier_action = "ENABLED"
+    }
   }
   delete_destination_volume = true
   wait_for_mirror = true
@@ -142,6 +147,7 @@ resource "google_netapp_storage_pool" "destination_pool" {
   service_level = "PREMIUM"
   capacity_gib  = 2048
   network       = data.google_compute_network.default.id
+  allow_auto_tiering = true
 }
 
 resource "google_netapp_volume" "source_volume" {
@@ -174,6 +180,10 @@ resource "google_netapp_volume_replication" "test_replication" {
     # simplifies implementing client failover concepts
     share_name  = "tf-test-source-volume%{random_suffix}"
     description = "This is a replicated volume"
+    tiering_policy {
+      cooling_threshold_days = 20
+      tier_action = "ENABLED"
+    }
   }
   replication_enabled = true
   delete_destination_volume = true
@@ -204,6 +214,7 @@ resource "google_netapp_storage_pool" "destination_pool" {
   service_level = "PREMIUM"
   capacity_gib  = 2048
   network       = data.google_compute_network.default.id
+  allow_auto_tiering = true
 }
 
 resource "google_netapp_volume" "source_volume" {
@@ -236,6 +247,10 @@ resource "google_netapp_volume_replication" "test_replication" {
     # simplifies implementing client failover concepts
     share_name  = "tf-test-source-volume%{random_suffix}"
     description = "This is a replicated volume"
+    tiering_policy {
+      cooling_threshold_days = 20
+      tier_action = "ENABLED"
+    }
   }
   replication_enabled = false
   delete_destination_volume = true
@@ -266,6 +281,7 @@ resource "google_netapp_storage_pool" "destination_pool" {
   service_level = "PREMIUM"
   capacity_gib  = 2048
   network       = data.google_compute_network.default.id
+  allow_auto_tiering = true
 }
 
 resource "google_netapp_volume" "source_volume" {
@@ -298,6 +314,10 @@ resource "google_netapp_volume_replication" "test_replication" {
     # simplifies implementing client failover concepts
     share_name  = "tf-test-source-volume%{random_suffix}"
     description = "This is a replicated volume"
+    tiering_policy {
+      cooling_threshold_days = 20
+      tier_action = "ENABLED"
+    }
   }
   replication_enabled = true
   delete_destination_volume = true

website/docs/r/netapp_volume.html.markdown

@@ -360,7 +360,7 @@ Possible values: DEFAULT, FORCE.
 
 * `cooling_threshold_days` -
   (Optional)
-  Optional. Time in days to mark the volume's data block as cold and make it eligible for tiering, can be range from 7-183.
+  Optional. Time in days to mark the volume's data block as cold and make it eligible for tiering, can be range from 2-183.
   Default is 31.
 
 * `tier_action` -

website/docs/r/netapp_volume_replication.html.markdown

@@ -70,6 +70,7 @@ resource "google_netapp_storage_pool" "destination_pool" {
   service_level = "PREMIUM"
   capacity_gib  = 2048
   network       = data.google_compute_network.default.id
+  allow_auto_tiering = true
 }
 
 resource "google_netapp_volume" "source_volume" {
@@ -98,6 +99,10 @@ resource "google_netapp_volume_replication" "test_replication" {
     # simplifies implementing client failover concepts
     share_name  = "source-volume"
     description = "This is a replicated volume"
+    tiering_policy {
+        cooling_threshold_days = 20
+        tier_action = "ENABLED"
+    }
   }
   # WARNING: Setting delete_destination_volume to true, will delete the
   # CURRENT destination volume if the replication is deleted. Omit the field 
@@ -193,6 +198,25 @@ create/stop/resume operations, set this parameter to true. Default is false.
   (Optional)
   Description for the destination volume.
 
+* `tiering_policy` -
+  (Optional)
+  Tiering policy for the volume.
+  Structure is [documented below](#nested_destination_volume_parameters_tiering_policy).
+
+
+<a name="nested_destination_volume_parameters_tiering_policy"></a>The `tiering_policy` block supports:
+
+* `cooling_threshold_days` -
+  (Optional)
+  Optional. Time in days to mark the volume's data block as cold and make it eligible for tiering, can be range from 2-183.
+  Default is 31.
+
+* `tier_action` -
+  (Optional)
+  Optional. Flag indicating if the volume has tiering policy enable/pause. Default is PAUSED.
+  Default value is `PAUSED`.
+  Possible values are: `ENABLED`, `PAUSED`.
+
 ## Attributes Reference
 
 In addition to the arguments listed above, the following computed attributes are exported: