Update Instance.yaml delete_url for Looker (#11950) (#8453)

[upstream:b7d5a7d1eeeda16a04126c1dd4f37e10a0c537b8]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/11950.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+looker: added `deletion_policy` to `google_looker_instance` to allow force-destroying instances with nested resources by setting `deletion_policy = FORCE` 
+```

google-beta/services/looker/resource_looker_instance.go

@@ -496,6 +496,15 @@ accurate to nanoseconds.`,
 				Description: `The time the instance was updated in RFC3339 UTC "Zulu" format,
 accurate to nanoseconds.`,
 			},
+			"deletion_policy": {
+				Type:     schema.TypeString,
+				Optional: true,
+				Description: `Policy to determine if the cluster should be deleted forcefully.
+If setting deletion_policy = "FORCE", the Looker instance will be deleted regardless
+of its nested resources. If set to "DEFAULT", Looker instances that still have
+nested resources will return an error. Possible values: DEFAULT, FORCE`,
+				Default: "DEFAULT",
+			},
 			"project": {
 				Type:     schema.TypeString,
 				Optional: true,
@@ -712,6 +721,12 @@ func resourceLookerInstanceRead(d *schema.ResourceData, meta interface{}) error
 		return transport_tpg.HandleNotFoundError(err, d, fmt.Sprintf("LookerInstance %q", d.Id()))
 	}
 
+	// Explicitly set virtual fields to default values if unset
+	if _, ok := d.GetOkExists("deletion_policy"); !ok {
+		if err := d.Set("deletion_policy", "DEFAULT"); err != nil {
+			return fmt.Errorf("Error setting deletion_policy: %s", err)
+		}
+	}
 	if err := d.Set("project", project); err != nil {
 		return fmt.Errorf("Error reading Instance: %s", err)
 	}
@@ -1021,6 +1036,10 @@ func resourceLookerInstanceDelete(d *schema.ResourceData, meta interface{}) erro
 	}
 
 	headers := make(http.Header)
+	// Forcefully delete the Looker instance
+	if deletionPolicy := d.Get("deletion_policy"); deletionPolicy == "FORCE" {
+		url = url + "?force=True"
+	}
 
 	log.Printf("[DEBUG] Deleting Instance %q", d.Id())
 	res, err := transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
@@ -1068,6 +1087,11 @@ func resourceLookerInstanceImport(d *schema.ResourceData, meta interface{}) ([]*
 	}
 	d.SetId(id)
 
+	// Explicitly set virtual fields to default values on import
+	if err := d.Set("deletion_policy", "DEFAULT"); err != nil {
+		return nil, fmt.Errorf("Error setting deletion_policy: %s", err)
+	}
+
 	return []*schema.ResourceData{d}, nil
 }
 

google-beta/services/looker/resource_looker_instance_generated_test.go

@@ -65,6 +65,7 @@ resource "google_looker_instance" "looker-instance" {
     client_id = "tf-test-my-client-id%{random_suffix}"
     client_secret = "tf-test-my-client-secret%{random_suffix}"
   }
+  deletion_policy = "DEFAULT"
 }
 `, context)
 }
@@ -368,6 +369,46 @@ resource "google_looker_instance" "looker-instance" {
 `, context)
 }
 
+func TestAccLookerInstance_lookerInstanceForceDeleteExample(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckLookerInstanceDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccLookerInstance_lookerInstanceForceDeleteExample(context),
+			},
+			{
+				ResourceName:            "google_looker_instance.looker-instance",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"deletion_policy", "name", "oauth_config", "region"},
+			},
+		},
+	})
+}
+
+func testAccLookerInstance_lookerInstanceForceDeleteExample(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource "google_looker_instance" "looker-instance" {
+  name              = "tf-test-my-instance%{random_suffix}"
+  platform_edition  = "LOOKER_CORE_STANDARD_ANNUAL"
+  region            = "us-central1"
+  oauth_config {
+    client_id = "tf-test-my-client-id%{random_suffix}"
+    client_secret = "tf-test-my-client-secret%{random_suffix}"
+  }
+  deletion_policy = "FORCE"
+}
+`, context)
+}
+
 func testAccCheckLookerInstanceDestroyProducer(t *testing.T) func(s *terraform.State) error {
 	return func(s *terraform.State) error {
 		for name, rs := range s.RootModule().Resources {

website/docs/r/looker_instance.html.markdown

@@ -46,6 +46,7 @@ resource "google_looker_instance" "looker-instance" {
     client_id = "my-client-id"
     client_secret = "my-client-secret"
   }
+  deletion_policy = "DEFAULT"
 }
 ```
 <div class = "oics-button" style="float: right; margin: 0 0 -15px">
@@ -250,6 +251,26 @@ resource "google_looker_instance" "looker-instance" {
   }
 }
 ```
+<div class = "oics-button" style="float: right; margin: 0 0 -15px">
+  <a href="https://console.cloud.google.com/cloudshell/open?cloudshell_git_repo=https%3A%2F%2Fgithub.jpy.wang%2Fterraform-google-modules%2Fdocs-examples.git&cloudshell_image=gcr.io%2Fcloudshell-images%2Fcloudshell%3Alatest&cloudshell_print=.%2Fmotd&cloudshell_tutorial=.%2Ftutorial.md&cloudshell_working_dir=looker_instance_force_delete&open_in_editor=main.tf" target="_blank">
+    <img alt="Open in Cloud Shell" src="//gstatic.com/cloudssh/images/open-btn.svg" style="max-height: 44px; margin: 32px auto; max-width: 100%;">
+  </a>
+</div>
+## Example Usage - Looker Instance Force Delete
+
+
+```hcl
+resource "google_looker_instance" "looker-instance" {
+  name              = "my-instance"
+  platform_edition  = "LOOKER_CORE_STANDARD_ANNUAL"
+  region            = "us-central1"
+  oauth_config {
+    client_id = "my-client-id"
+    client_secret = "my-client-secret"
+  }
+  deletion_policy = "FORCE"
+}
+```
 
 ## Argument Reference
 
@@ -360,6 +381,11 @@ The following arguments are supported:
 * `project` - (Optional) The ID of the project in which the resource belongs.
     If it is not provided, the provider project is used.
 
+* `deletion_policy` - (Optional) Policy to determine if the cluster should be deleted forcefully.
+If setting deletion_policy = "FORCE", the Looker instance will be deleted regardless
+of its nested resources. If set to "DEFAULT", Looker instances that still have
+nested resources will return an error. Possible values: DEFAULT, FORCE
+
 
 <a name="nested_admin_settings"></a>The `admin_settings` block supports: