Skip to content

Commit 443ca35

Browse files
Removed duplicate code from Cloud Build Trigger post_create (#13540) (#9725)
[upstream:a3b698e521b74772beea3e45df5c275421d887d4] Signed-off-by: Modular Magician <[email protected]>
1 parent dc27186 commit 443ca35

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

google-beta/services/cloudbuild/resource_cloudbuild_trigger.go

-15
Original file line numberDiff line numberDiff line change
@@ -1609,21 +1609,6 @@ func resourceCloudBuildTriggerCreate(d *schema.ResourceData, meta interface{}) e
16091609
}
16101610
d.SetId(id)
16111611

1612-
// `name` is autogenerated from the api so needs to be set post-create
1613-
triggerId, ok := res["id"]
1614-
if !ok {
1615-
return fmt.Errorf("Create response didn't contain id. Create may not have succeeded.")
1616-
}
1617-
if err := d.Set("trigger_id", triggerId.(string)); err != nil {
1618-
return fmt.Errorf("Error setting trigger_id: %s", err)
1619-
}
1620-
1621-
// Store the ID now. We tried to set it before and it failed because
1622-
// trigger_id didn't exist yet.
1623-
id, err = tpgresource.ReplaceVars(d, config, "projects/{{project}}/locations/{{location}}/triggers/{{trigger_id}}")
1624-
if err != nil {
1625-
return fmt.Errorf("Error constructing id: %s", err)
1626-
}
16271612
// Force legacy id format for global triggers.
16281613
id = strings.ReplaceAll(id, "/locations/global/", "/")
16291614
d.SetId(id)

0 commit comments

Comments
 (0)