Migrate google_compute_firewall_policy_association resource from DCL to MMv1 (#12466)

Co-authored-by: Zhenhua Li <[email protected]>

[upstream:613bdaee0c0243e40465a7b5497693b9720eeb85]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/12466.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+compute: `google_compute_firewall_policy_association` now uses MMv1 engine instead of DCL.
+```

google-beta/provider/provider_dcl_resources.go

@@ -36,27 +36,26 @@ import (
 )
 
 var dclResources = map[string]*schema.Resource{
-	"google_apikeys_key":                         apikeys.ResourceApikeysKey(),
-	"google_assured_workloads_workload":          assuredworkloads.ResourceAssuredWorkloadsWorkload(),
-	"google_cloudbuild_worker_pool":              cloudbuild.ResourceCloudbuildWorkerPool(),
-	"google_clouddeploy_delivery_pipeline":       clouddeploy.ResourceClouddeployDeliveryPipeline(),
-	"google_clouddeploy_target":                  clouddeploy.ResourceClouddeployTarget(),
-	"google_compute_firewall_policy":             compute.ResourceComputeFirewallPolicy(),
-	"google_compute_firewall_policy_association": compute.ResourceComputeFirewallPolicyAssociation(),
-	"google_container_aws_cluster":               containeraws.ResourceContainerAwsCluster(),
-	"google_container_aws_node_pool":             containeraws.ResourceContainerAwsNodePool(),
-	"google_container_azure_client":              containerazure.ResourceContainerAzureClient(),
-	"google_container_azure_cluster":             containerazure.ResourceContainerAzureCluster(),
-	"google_container_azure_node_pool":           containerazure.ResourceContainerAzureNodePool(),
-	"google_dataplex_asset":                      dataplex.ResourceDataplexAsset(),
-	"google_dataplex_lake":                       dataplex.ResourceDataplexLake(),
-	"google_dataplex_zone":                       dataplex.ResourceDataplexZone(),
-	"google_dataproc_workflow_template":          dataproc.ResourceDataprocWorkflowTemplate(),
-	"google_eventarc_channel":                    eventarc.ResourceEventarcChannel(),
-	"google_eventarc_google_channel_config":      eventarc.ResourceEventarcGoogleChannelConfig(),
-	"google_eventarc_trigger":                    eventarc.ResourceEventarcTrigger(),
-	"google_firebaserules_release":               firebaserules.ResourceFirebaserulesRelease(),
-	"google_firebaserules_ruleset":               firebaserules.ResourceFirebaserulesRuleset(),
-	"google_gke_hub_feature_membership":          gkehub.ResourceGkeHubFeatureMembership(),
-	"google_recaptcha_enterprise_key":            recaptchaenterprise.ResourceRecaptchaEnterpriseKey(),
+	"google_apikeys_key":                    apikeys.ResourceApikeysKey(),
+	"google_assured_workloads_workload":     assuredworkloads.ResourceAssuredWorkloadsWorkload(),
+	"google_cloudbuild_worker_pool":         cloudbuild.ResourceCloudbuildWorkerPool(),
+	"google_clouddeploy_delivery_pipeline":  clouddeploy.ResourceClouddeployDeliveryPipeline(),
+	"google_clouddeploy_target":             clouddeploy.ResourceClouddeployTarget(),
+	"google_compute_firewall_policy":        compute.ResourceComputeFirewallPolicy(),
+	"google_container_aws_cluster":          containeraws.ResourceContainerAwsCluster(),
+	"google_container_aws_node_pool":        containeraws.ResourceContainerAwsNodePool(),
+	"google_container_azure_client":         containerazure.ResourceContainerAzureClient(),
+	"google_container_azure_cluster":        containerazure.ResourceContainerAzureCluster(),
+	"google_container_azure_node_pool":      containerazure.ResourceContainerAzureNodePool(),
+	"google_dataplex_asset":                 dataplex.ResourceDataplexAsset(),
+	"google_dataplex_lake":                  dataplex.ResourceDataplexLake(),
+	"google_dataplex_zone":                  dataplex.ResourceDataplexZone(),
+	"google_dataproc_workflow_template":     dataproc.ResourceDataprocWorkflowTemplate(),
+	"google_eventarc_channel":               eventarc.ResourceEventarcChannel(),
+	"google_eventarc_google_channel_config": eventarc.ResourceEventarcGoogleChannelConfig(),
+	"google_eventarc_trigger":               eventarc.ResourceEventarcTrigger(),
+	"google_firebaserules_release":          firebaserules.ResourceFirebaserulesRelease(),
+	"google_firebaserules_ruleset":          firebaserules.ResourceFirebaserulesRuleset(),
+	"google_gke_hub_feature_membership":     gkehub.ResourceGkeHubFeatureMembership(),
+	"google_recaptcha_enterprise_key":       recaptchaenterprise.ResourceRecaptchaEnterpriseKey(),
 }

google-beta/provider/provider_mmv1_resources.go

@@ -511,9 +511,9 @@ var handwrittenIAMDatasources = map[string]*schema.Resource{
 }
 
 // Resources
-// Generated resources: 570
+// Generated resources: 571
 // Generated IAM resources: 294
-// Total generated resources: 864
+// Total generated resources: 865
 var generatedResources = map[string]*schema.Resource{
 	"google_folder_access_approval_settings":                                     accessapproval.ResourceAccessApprovalFolderSettings(),
 	"google_organization_access_approval_settings":                               accessapproval.ResourceAccessApprovalOrganizationSettings(),
@@ -716,6 +716,7 @@ var generatedResources = map[string]*schema.Resource{
 	"google_compute_disk_resource_policy_attachment":                             compute.ResourceComputeDiskResourcePolicyAttachment(),
 	"google_compute_external_vpn_gateway":                                        compute.ResourceComputeExternalVpnGateway(),
 	"google_compute_firewall":                                                    compute.ResourceComputeFirewall(),
+	"google_compute_firewall_policy_association":                                 compute.ResourceComputeFirewallPolicyAssociation(),
 	"google_compute_firewall_policy_rule":                                        compute.ResourceComputeFirewallPolicyRule(),
 	"google_compute_firewall_policy_with_rules":                                  compute.ResourceComputeFirewallPolicyWithRules(),
 	"google_compute_forwarding_rule":                                             compute.ResourceComputeForwardingRule(),