Skip to content

Commit fb590d9

Browse files
Promote google_chronicle_rule_deployment resource of chronicle to GA (#13481) (#9667)
[upstream:493da686bb498c97d83aef2a6bedc2d4715a8ca6] Signed-off-by: Modular Magician <[email protected]>
1 parent d507a23 commit fb590d9

File tree

4 files changed

+8
-23
lines changed

4 files changed

+8
-23
lines changed

.changelog/13481.txt

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:note
2+
Promote google_chronicle_rule_deployment resource of chronicle to GA
3+
```

google-beta/services/chronicle/resource_chronicle_rule_deployment_generated_test.go

+3-9
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample(t *testi
3636

3737
acctest.VcrTest(t, resource.TestCase{
3838
PreCheck: func() { acctest.AccTestPreCheck(t) },
39-
ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
39+
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
4040
Steps: []resource.TestStep{
4141
{
4242
Config: testAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample(context),
@@ -54,7 +54,6 @@ func TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample(t *testi
5454
func testAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample(context map[string]interface{}) string {
5555
return acctest.Nprintf(`
5656
resource "google_chronicle_rule" "my-rule" {
57-
provider = "google-beta"
5857
location = "us"
5958
instance = "%{chronicle_id}"
6059
text = <<-EOT
@@ -63,7 +62,6 @@ resource "google_chronicle_rule" "my-rule" {
6362
}
6463
6564
resource "google_chronicle_rule_deployment" "example" {
66-
provider = "google-beta"
6765
location = "us"
6866
instance = "%{chronicle_id}"
6967
rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)
@@ -85,7 +83,7 @@ func TestAccChronicleRuleDeployment_chronicleRuledeploymentDisabledExample(t *te
8583

8684
acctest.VcrTest(t, resource.TestCase{
8785
PreCheck: func() { acctest.AccTestPreCheck(t) },
88-
ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
86+
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
8987
Steps: []resource.TestStep{
9088
{
9189
Config: testAccChronicleRuleDeployment_chronicleRuledeploymentDisabledExample(context),
@@ -103,7 +101,6 @@ func TestAccChronicleRuleDeployment_chronicleRuledeploymentDisabledExample(t *te
103101
func testAccChronicleRuleDeployment_chronicleRuledeploymentDisabledExample(context map[string]interface{}) string {
104102
return acctest.Nprintf(`
105103
resource "google_chronicle_rule" "my-rule" {
106-
provider = "google-beta"
107104
location = "us"
108105
instance = "%{chronicle_id}"
109106
text = <<-EOT
@@ -112,7 +109,6 @@ resource "google_chronicle_rule" "my-rule" {
112109
}
113110
114111
resource "google_chronicle_rule_deployment" "example" {
115-
provider = "google-beta"
116112
location = "us"
117113
instance = "%{chronicle_id}"
118114
rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)
@@ -132,7 +128,7 @@ func TestAccChronicleRuleDeployment_chronicleRuledeploymentRunFrequencyMissingEx
132128

133129
acctest.VcrTest(t, resource.TestCase{
134130
PreCheck: func() { acctest.AccTestPreCheck(t) },
135-
ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
131+
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
136132
Steps: []resource.TestStep{
137133
{
138134
Config: testAccChronicleRuleDeployment_chronicleRuledeploymentRunFrequencyMissingExample(context),
@@ -150,7 +146,6 @@ func TestAccChronicleRuleDeployment_chronicleRuledeploymentRunFrequencyMissingEx
150146
func testAccChronicleRuleDeployment_chronicleRuledeploymentRunFrequencyMissingExample(context map[string]interface{}) string {
151147
return acctest.Nprintf(`
152148
resource "google_chronicle_rule" "my-rule" {
153-
provider = "google-beta"
154149
location = "us"
155150
instance = "%{chronicle_id}"
156151
text = <<-EOT
@@ -159,7 +154,6 @@ resource "google_chronicle_rule" "my-rule" {
159154
}
160155
161156
resource "google_chronicle_rule_deployment" "example" {
162-
provider = "google-beta"
163157
location = "us"
164158
instance = "%{chronicle_id}"
165159
rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)

google-beta/services/chronicle/resource_chronicle_rule_deployment_test.go

+1-5
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ func TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_update(t
2121

2222
acctest.VcrTest(t, resource.TestCase{
2323
PreCheck: func() { acctest.AccTestPreCheck(t) },
24-
ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
24+
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
2525
Steps: []resource.TestStep{
2626
{
2727
Config: testAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_basic(context),
@@ -48,7 +48,6 @@ func TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_update(t
4848
func testAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_basic(context map[string]interface{}) string {
4949
return acctest.Nprintf(`
5050
resource "google_chronicle_rule" "my-rule" {
51-
provider = "google-beta"
5251
location = "us"
5352
instance = "%{chronicle_id}"
5453
text = <<-EOT
@@ -57,7 +56,6 @@ resource "google_chronicle_rule" "my-rule" {
5756
}
5857
5958
resource "google_chronicle_rule_deployment" "example" {
60-
provider = "google-beta"
6159
location = "us"
6260
instance = "%{chronicle_id}"
6361
rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)
@@ -72,7 +70,6 @@ resource "google_chronicle_rule_deployment" "example" {
7270
func testAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_update(context map[string]interface{}) string {
7371
return acctest.Nprintf(`
7472
resource "google_chronicle_rule" "my-rule" {
75-
provider = "google-beta"
7673
location = "us"
7774
instance = "%{chronicle_id}"
7875
text = <<-EOT
@@ -81,7 +78,6 @@ resource "google_chronicle_rule" "my-rule" {
8178
}
8279
8380
resource "google_chronicle_rule_deployment" "example" {
84-
provider = "google-beta"
8581
location = "us"
8682
instance = "%{chronicle_id}"
8783
rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)

website/docs/r/chronicle_rule_deployment.html.markdown

+1-9
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,10 @@ description: |-
2323

2424
The RuleDeployment resource represents the deployment state of a Rule.
2525

26-
~> **Warning:** This resource is in beta, and should be used with the terraform-provider-google-beta provider.
27-
See [Provider Versions](https://terraform.io/docs/providers/google/guides/provider_versions.html) for more details on beta resources.
2826

2927
To get more information about RuleDeployment, see:
3028

31-
* [API documentation](https://cloud.google.com/chronicle/docs/reference/rest/v1alpha/RuleDeployment)
29+
* [API documentation](https://cloud.google.com/chronicle/docs/reference/rest/v1/RuleDeployment)
3230
* How-to Guides
3331
* [Google SecOps Guides](https://cloud.google.com/chronicle/docs/secops/secops-overview)
3432

@@ -37,7 +35,6 @@ To get more information about RuleDeployment, see:
3735

3836
```hcl
3937
resource "google_chronicle_rule" "my-rule" {
40-
provider = "google-beta"
4138
location = "us"
4239
instance = "00000000-0000-0000-0000-000000000000"
4340
text = <<-EOT
@@ -46,7 +43,6 @@ resource "google_chronicle_rule" "my-rule" {
4643
}
4744
4845
resource "google_chronicle_rule_deployment" "example" {
49-
provider = "google-beta"
5046
location = "us"
5147
instance = "00000000-0000-0000-0000-000000000000"
5248
rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)
@@ -61,7 +57,6 @@ resource "google_chronicle_rule_deployment" "example" {
6157

6258
```hcl
6359
resource "google_chronicle_rule" "my-rule" {
64-
provider = "google-beta"
6560
location = "us"
6661
instance = "00000000-0000-0000-0000-000000000000"
6762
text = <<-EOT
@@ -70,7 +65,6 @@ resource "google_chronicle_rule" "my-rule" {
7065
}
7166
7267
resource "google_chronicle_rule_deployment" "example" {
73-
provider = "google-beta"
7468
location = "us"
7569
instance = "00000000-0000-0000-0000-000000000000"
7670
rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)
@@ -83,7 +77,6 @@ resource "google_chronicle_rule_deployment" "example" {
8377

8478
```hcl
8579
resource "google_chronicle_rule" "my-rule" {
86-
provider = "google-beta"
8780
location = "us"
8881
instance = "00000000-0000-0000-0000-000000000000"
8982
text = <<-EOT
@@ -92,7 +85,6 @@ resource "google_chronicle_rule" "my-rule" {
9285
}
9386
9487
resource "google_chronicle_rule_deployment" "example" {
95-
provider = "google-beta"
9688
location = "us"
9789
instance = "00000000-0000-0000-0000-000000000000"
9890
rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)

0 commit comments

Comments
 (0)