Remove redundant privateca cert authority tests (#6338) (#12205)

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/6338.txt

@@ -0,0 +1,2 @@
+```release-note:none
+```

google/resource_privateca_certificate_authority_test.go

@@ -6,7 +6,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 )
 
-func TestAccPrivatecaCertificateAuthority_rootCaIsEnabledByDefault(t *testing.T) {
+func TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityUpdate(t *testing.T) {
 	t.Parallel()
 
 	context := map[string]interface{}{
@@ -16,119 +16,19 @@ func TestAccPrivatecaCertificateAuthority_rootCaIsEnabledByDefault(t *testing.T)
 		"random_suffix":       randString(t, 10),
 	}
 
-	resourceName := "google_privateca_certificate_authority.default"
 	vcrTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckPrivatecaCertificateAuthorityDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
 				Config: testAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicRoot(context),
+				// we added a `desired_state` field in https://github.com/GoogleCloudPlatform/magic-modules/pull/5934, this ensures
+				// we don't regress and that CAs are enabled by default
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr(resourceName, "state", "ENABLED"),
-				),
-			},
-		},
-	})
-}
-
-func TestAccPrivatecaCertificateAuthority_rootCaCreatedInStaged(t *testing.T) {
-	t.Parallel()
-
-	context := map[string]interface{}{
-		"pool_name":           BootstrapSharedCaPoolInLocation(t, "us-central1"),
-		"pool_location":       "us-central1",
-		"deletion_protection": false,
-		"random_suffix":       randString(t, 10),
-		"desired_state":       "STAGED",
-	}
-
-	resourceName := "google_privateca_certificate_authority.default"
-	vcrTest(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckPrivatecaCertificateAuthorityDestroyProducer(t),
-		Steps: []resource.TestStep{
-			{
-				Config: testAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityWithDesiredState(context),
-				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr(resourceName, "state", "STAGED"),
-				),
-			},
-		},
-	})
-}
-
-func TestAccPrivatecaCertificateAuthority_subordinateCaCreatedInAwaitingUserActivation(t *testing.T) {
-	t.Parallel()
-
-	context := map[string]interface{}{
-		"pool_name":           BootstrapSharedCaPoolInLocation(t, "us-central1"),
-		"pool_location":       "us-central1",
-		"deletion_protection": false,
-		"random_suffix":       randString(t, 10),
-	}
-
-	resourceName := "google_privateca_certificate_authority.default"
-	vcrTest(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckPrivatecaCertificateAuthorityDestroyProducer(t),
-		Steps: []resource.TestStep{
-			{
-				Config: testAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicSubordinate(context),
-				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr(resourceName, "state", "AWAITING_USER_ACTIVATION"),
-				),
-			},
-		},
-	})
-}
-
-func TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation(t *testing.T) {
-	t.Parallel()
-
-	context := map[string]interface{}{
-		"pool_name":           BootstrapSharedCaPoolInLocation(t, "us-central1"),
-		"pool_location":       "us-central1",
-		"deletion_protection": false,
-		"random_suffix":       randString(t, 10),
-	}
-
-	resourceName := "google_privateca_certificate_authority.default"
-	vcrTest(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckPrivatecaCertificateAuthorityDestroyProducer(t),
-		Steps: []resource.TestStep{
-			{
-				Config: testAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateWithFirstPartyIssuer(context),
-				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr(resourceName, "state", "ENABLED"),
+					resource.TestCheckResourceAttr("google_privateca_certificate_authority.default", "state", "ENABLED"),
 				),
 			},
-		},
-	})
-}
-
-func TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityUpdate(t *testing.T) {
-	t.Parallel()
-
-	context := map[string]interface{}{
-		"pool_name":           BootstrapSharedCaPoolInLocation(t, "us-central1"),
-		"pool_location":       "us-central1",
-		"deletion_protection": false,
-		"random_suffix":       randString(t, 10),
-	}
-
-	vcrTest(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckPrivatecaCertificateAuthorityDestroyProducer(t),
-		Steps: []resource.TestStep{
-			{
-				Config: testAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicRoot(context),
-			},
 			{
 				ResourceName:            "google_privateca_certificate_authority.default",
 				ImportState:             true,
@@ -381,168 +281,3 @@ resource "google_privateca_certificate_authority" "default" {
 }
 `, context)
 }
-
-func testAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicSubordinate(context map[string]interface{}) string {
-	return Nprintf(`
-resource "google_privateca_certificate_authority" "default" {
-	// This example assumes this pool already exists.
-	// Pools cannot be deleted in normal test circumstances, so we depend on static pools
-	pool = "%{pool_name}"
-	certificate_authority_id = "tf-test-my-certificate-authority-%{random_suffix}"
-	location = "%{pool_location}"
-	deletion_protection = false
-	config {
-		subject_config {
-		subject {
-			organization = "HashiCorp"
-			common_name = "my-certificate-authority"
-		}
-		subject_alt_name {
-			dns_names = ["hashicorp.com"]
-		}
-		}
-		x509_config {
-		ca_options {
-			is_ca = true
-			max_issuer_path_length = 10
-		}
-		key_usage {
-			base_key_usage {
-			digital_signature = true
-			content_commitment = true
-			key_encipherment = false
-			data_encipherment = true
-			key_agreement = true
-			cert_sign = true
-			crl_sign = true
-			decipher_only = true
-			}
-			extended_key_usage {
-			server_auth = true
-			client_auth = false
-			email_protection = true
-			code_signing = true
-			time_stamping = true
-			}
-		}
-		}
-	}
-	lifetime = "86400s"
-	key_spec {
-		algorithm = "RSA_PKCS1_4096_SHA256"
-	}
-	type = "SUBORDINATE"
-}
-`, context)
-}
-
-// testAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateWithFirstPartyIssuer provides a config
-// which contains
-// * A root CA
-// * A subordinate CA which should be activated by the above root CA
-func testAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateWithFirstPartyIssuer(context map[string]interface{}) string {
-	return Nprintf(`
-resource "google_privateca_certificate_authority" "root-1" {
-	// This example assumes this pool already exists.
-	// Pools cannot be deleted in normal test circumstances, so we depend on static pools
-	pool = "%{pool_name}"
-	certificate_authority_id = "tf-test-my-certificate-authority-root-%{random_suffix}"
-	location = "%{pool_location}"
-	deletion_protection = false
-	ignore_active_certificates_on_deletion = true
-	config {
-		subject_config {
-		subject {
-			organization = "HashiCorp"
-			common_name = "my-certificate-authority"
-		}
-		subject_alt_name {
-			dns_names = ["hashicorp.com"]
-		}
-		}
-		x509_config {
-		ca_options {
-			is_ca = true
-			max_issuer_path_length = 10
-		}
-		key_usage {
-			base_key_usage {
-			digital_signature = true
-			content_commitment = true
-			key_encipherment = false
-			data_encipherment = true
-			key_agreement = true
-			cert_sign = true
-			crl_sign = true
-			decipher_only = true
-			}
-			extended_key_usage {
-			server_auth = true
-			client_auth = false
-			email_protection = true
-			code_signing = true
-			time_stamping = true
-			}
-		}
-		}
-	}
-	lifetime = "86400s"
-	key_spec {
-		algorithm = "RSA_PKCS1_4096_SHA256"
-	}
-}
-
-resource "google_privateca_certificate_authority" "default" {
-	// This example assumes this pool already exists.
-	// Pools cannot be deleted in normal test circumstances, so we depend on static pools
-	pool = "%{pool_name}"
-	certificate_authority_id = "tf-test-my-certificate-authority-sub-%{random_suffix}"
-	location = "%{pool_location}"
-	deletion_protection = false
-	subordinate_config {
-		certificate_authority = google_privateca_certificate_authority.root-1.name
-	}
-	config {
-		subject_config {
-		subject {
-			organization = "HashiCorp"
-			common_name = "my-certificate-authority"
-		}
-		subject_alt_name {
-			dns_names = ["hashicorp.com"]
-		}
-		}
-		x509_config {
-		ca_options {
-			is_ca = true
-			max_issuer_path_length = 10
-		}
-		key_usage {
-			base_key_usage {
-			digital_signature = true
-			content_commitment = true
-			key_encipherment = false
-			data_encipherment = true
-			key_agreement = true
-			cert_sign = true
-			crl_sign = true
-			decipher_only = true
-			}
-			extended_key_usage {
-			server_auth = true
-			client_auth = false
-			email_protection = true
-			code_signing = true
-			time_stamping = true
-			}
-		}
-		}
-	}
-	lifetime = "86400s"
-	key_spec {
-		algorithm = "RSA_PKCS1_4096_SHA256"
-	}
-	type = "SUBORDINATE"
-}
-`, context)
-}