Skip to content

Commit 3627111

Browse files
modular-magiciandanawillow
authored andcommitted
allow setting firewall priority to 0 (#3700)
Signed-off-by: Modular Magician <[email protected]>
1 parent 90c27fa commit 3627111

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

google/resource_compute_firewall.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ func resourceComputeFirewallCreate(d *schema.ResourceData, meta interface{}) err
282282
priorityProp, err := expandComputeFirewallPriority(d.Get("priority"), d, config)
283283
if err != nil {
284284
return err
285-
} else if v, ok := d.GetOkExists("priority"); !isEmptyValue(reflect.ValueOf(priorityProp)) && (ok || !reflect.DeepEqual(v, priorityProp)) {
285+
} else if v, ok := d.GetOkExists("priority"); ok || !reflect.DeepEqual(v, priorityProp) {
286286
obj["priority"] = priorityProp
287287
}
288288
sourceRangesProp, err := expandComputeFirewallSourceRanges(d.Get("source_ranges"), d, config)
@@ -475,7 +475,7 @@ func resourceComputeFirewallUpdate(d *schema.ResourceData, meta interface{}) err
475475
priorityProp, err := expandComputeFirewallPriority(d.Get("priority"), d, config)
476476
if err != nil {
477477
return err
478-
} else if v, ok := d.GetOkExists("priority"); !isEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, priorityProp)) {
478+
} else if v, ok := d.GetOkExists("priority"); ok || !reflect.DeepEqual(v, priorityProp) {
479479
obj["priority"] = priorityProp
480480
}
481481
sourceRangesProp, err := expandComputeFirewallSourceRanges(d.Get("source_ranges"), d, config)

0 commit comments

Comments
 (0)