Support replica materialized view in resource_bigquery_table in the beta provider (#9773) (#17020)

* support replica materialized view in resource_bigquery_table

* fix typo

* add unit tests

* fix white spaces

* fix the condition check for table_replication_info in Update

* create source materialized view in unit tests using DDL instead of table API

* add missing google-beta provider declarations in unit test

* create source table using DDL in unit test

* Revert "create source table using DDL in unit test"

This reverts commit 232a7ac431114cd405f0cec858bb0496d48fd07c.

* reorder input args in unit tests

* remove wrong project declaration in unit tests

* remove update check, make the new fields forcenew, and add default to replication_interval_ms

* add ForceNew to table_replication_info
[upstream:256f7f56789ee965c2e7582735140de383270400]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/9773.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+bigquery: support replica materialized view in resource_bigquery_table (beta)
+```

google/services/bigquery/resource_bigquery_table.go

@@ -530,7 +530,7 @@ func ResourceBigQueryTable() *schema.Resource {
 							Default:      "NONE",
 							Description:  `The compression type of the data source. Valid values are "NONE" or "GZIP".`,
 						},
-						// Schema: Optional] The schema for the  data.
+						// Schema: [Optional] The schema for the data.
 						// Schema is required for CSV and JSON formats if autodetect is not on.
 						// Schema is disallowed for Google Cloud Bigtable, Cloud Datastore backups, Avro, Iceberg, ORC, and Parquet formats.
 						"schema": {
@@ -889,7 +889,7 @@ func ResourceBigQueryTable() *schema.Resource {
 							Type:        schema.TypeInt,
 							Default:     1800000,
 							Optional:    true,
-							Description: `Specifies maximum frequency at which this materialized view will be refreshed. The default is 1800000`,
+							Description: `Specifies maximum frequency at which this materialized view will be refreshed. The default is 1800000.`,
 						},
 
 						"allow_non_incremental_definition": {
@@ -1390,7 +1390,7 @@ func resourceBigQueryTableCreate(d *schema.ResourceData, meta interface{}) error
 
 	if table.View != nil && table.Schema != nil {
 
-		log.Printf("[INFO] Removing schema from table definition because big query does not support setting schema on view creation")
+		log.Printf("[INFO] Removing schema from table definition because BigQuery does not support setting schema on view creation")
 		schemaBack := table.Schema
 		table.Schema = nil
 
@@ -1410,7 +1410,7 @@ func resourceBigQueryTableCreate(d *schema.ResourceData, meta interface{}) error
 			return err
 		}
 
-		log.Printf("[INFO] BigQuery table %s has been update with schema", res.Id)
+		log.Printf("[INFO] BigQuery table %s has been updated with schema", res.Id)
 	} else {
 		log.Printf("[INFO] Creating BigQuery table: %s", table.TableReference.TableId)
 

google/services/bigquery/resource_bigquery_table_test.go

@@ -1765,7 +1765,7 @@ resource "google_bigquery_table" "test" {
     hive_partitioning_options {
       mode = "AUTO"
       source_uri_prefix = "gs://${google_storage_bucket.test.name}/"
-	  require_partition_filter = true
+      require_partition_filter = true
     }
 
   }
@@ -1805,7 +1805,7 @@ resource "google_bigquery_table" "test" {
     hive_partitioning_options {
       mode = "CUSTOM"
       source_uri_prefix = "gs://${google_storage_bucket.test.name}/{key1:STRING}"
-	  require_partition_filter = true
+      require_partition_filter = true
     }
 
     schema = <<EOH
@@ -3012,48 +3012,48 @@ resource "google_bigquery_table" "test" {
 
 func testAccBigQueryTableFromBigtable(context map[string]interface{}) string {
 	return acctest.Nprintf(`
-	resource "google_bigtable_instance" "instance" {
-		name = "tf-test-bigtable-inst-%{random_suffix}"
-		cluster {
-			cluster_id = "tf-test-bigtable-%{random_suffix}"
-			zone       = "us-central1-b"
-		}
-		instance_type = "DEVELOPMENT"
-		deletion_protection = false
-	}
-	resource "google_bigtable_table" "table" {
-		name          = "%{random_suffix}"
-		instance_name = google_bigtable_instance.instance.name
-		column_family {
-			family = "cf-%{random_suffix}-first"
-		}
-		column_family {
-			family = "cf-%{random_suffix}-second"
-		}
-	}
-	resource "google_bigquery_table" "table" {
-		deletion_protection = false
-		dataset_id = google_bigquery_dataset.dataset.dataset_id
-		table_id   = "tf_test_bigtable_%{random_suffix}"
-		external_data_configuration {
-		  autodetect            = true
-		  source_format         = "BIGTABLE"
-		  ignore_unknown_values = true
-		  source_uris = [
-			"https://googleapis.com/bigtable/${google_bigtable_table.table.id}",
-		  ]
-		}
-	  }
-	  resource "google_bigquery_dataset" "dataset" {
-		dataset_id                  = "tf_test_ds_%{random_suffix}"
-		friendly_name               = "test"
-		description                 = "This is a test description"
-		location                    = "EU"
-		default_table_expiration_ms = 3600000
-		labels = {
-		  env = "default"
-		}
-	  }
+resource "google_bigtable_instance" "instance" {
+  name = "tf-test-bigtable-inst-%{random_suffix}"
+  cluster {
+    cluster_id = "tf-test-bigtable-%{random_suffix}"
+    zone       = "us-central1-b"
+  }
+  instance_type = "DEVELOPMENT"
+  deletion_protection = false
+}
+resource "google_bigtable_table" "table" {
+  name          = "%{random_suffix}"
+  instance_name = google_bigtable_instance.instance.name
+  column_family {
+    family = "cf-%{random_suffix}-first"
+  }
+  column_family {
+    family = "cf-%{random_suffix}-second"
+  }
+}
+resource "google_bigquery_table" "table" {
+  deletion_protection = false
+  dataset_id = google_bigquery_dataset.dataset.dataset_id
+  table_id   = "tf_test_bigtable_%{random_suffix}"
+  external_data_configuration {
+    autodetect            = true
+    source_format         = "BIGTABLE"
+    ignore_unknown_values = true
+    source_uris = [
+    "https://googleapis.com/bigtable/${google_bigtable_table.table.id}",
+    ]
+  }
+}
+resource "google_bigquery_dataset" "dataset" {
+  dataset_id                  = "tf_test_ds_%{random_suffix}"
+  friendly_name               = "test"
+  description                 = "This is a test description"
+  location                    = "EU"
+  default_table_expiration_ms = 3600000
+  labels = {
+    env = "default"
+  }
+}
 `, context)
 }