Allow duration to be updatable and force new

Author: chrisst

google/resource_monitoring_uptime_check_config.go

@@ -455,6 +455,8 @@ func resourceMonitoringUptimeCheckConfigUpdate(d *schema.ResourceData, meta inte
 		obj["monitoredResource"] = monitoredResourceProp
 	}
 
+	obj, err = resourceMonitoringUptimeCheckConfigUpdateEncoder(d, meta, obj)
+
 	url, err := replaceVars(d, config, "https://monitoring.googleapis.com/v3/{{name}}")
 	if err != nil {
 		return err
@@ -1057,3 +1059,20 @@ func expandMonitoringUptimeCheckConfigMonitoredResourceLabels(v interface{}, d *
 	}
 	return m, nil
 }
+
+func resourceMonitoringUptimeCheckConfigUpdateEncoder(d *schema.ResourceData, meta interface{}, obj map[string]interface{}) (map[string]interface{}, error) {
+	// Even thought uptimeCheckConfig is modified with a PATCH call it still requires `duration` to
+	// be sent on every request. Also if duration has changed the resource needs to be recreated. This
+	// is a pattern we're not planning on supporting and this should be removed and `duration` no longer
+	// marked as `input: true` if this is fixed upstream.
+	config := meta.(*Config)
+
+	periodProp, err := expandMonitoringUptimeCheckConfigPeriod(d.Get("period"), d, config)
+	if err != nil {
+		return nil, err
+	} else if v, ok := d.GetOkExists("period"); !isEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, periodProp)) {
+		obj["period"] = periodProp
+	}
+
+	return obj, nil
+}