Remove IP validation for host of on-premise instance (#9225) (#16235)

* Remove IP validation for host of on-premise instance

In admin API, we don't have validation for host of on-premise instances. Host can take the value of IP address or DNS address. As of now it is validating that host contain the IP address in terraform, in order to be consistent with admin API and accept DNS address as well, removing the validation function for host.

* Update the description of the host field
[upstream:e8667f2683131ffa0b14914d9e4821c1ad6a43f6]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/9225.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+sql: removed host validation to support IP address and DNS address in host in `google_sql_source_representation_instance` resource
+```

google/services/sql/resource_sql_source_representation_instance.go

@@ -70,11 +70,10 @@ func ResourceSQLSourceRepresentationInstance() *schema.Resource {
 				Description: `The name of the source representation instance. Use any valid Cloud SQL instance name.`,
 			},
 			"host": {
-				Type:         schema.TypeString,
-				Required:     true,
-				ForceNew:     true,
-				ValidateFunc: verify.ValidateIpAddress,
-				Description:  `The externally accessible IPv4 address for the source database server.`,
+				Type:        schema.TypeString,
+				Required:    true,
+				ForceNew:    true,
+				Description: `The IPv4 address and port for the external server, or the the DNS address for the external server. If the external server is hosted on Cloud SQL, the port is 5432.`,
 			},
 			"ca_certificate": {
 				Type:        schema.TypeString,

website/docs/r/sql_source_representation_instance.html.markdown

@@ -89,7 +89,7 @@ The following arguments are supported:
 
 * `host` -
   (Required)
-  The externally accessible IPv4 address for the source database server.
+  The IPv4 address and port for the external server, or the the DNS address for the external server. If the external server is hosted on Cloud SQL, the port is 5432.
 
 
 - - -