Remove outdated tests (superseded by generated ones) (#2836)

<!-- This change is generated by MagicModules. -->
/cc @rileykarson

Author: modular-magician

google/resource_cloudbuild_build_trigger_test.go renamed to google/resource_cloudbuild_trigger_test.go

@@ -35,27 +35,6 @@ func TestAccCloudBuildTrigger_basic(t *testing.T) {
 	})
 }
 
-func TestAccCloudBuildTrigger_filename(t *testing.T) {
-	t.Parallel()
-
-	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckCloudbuildTriggerDestroy,
-		Steps: []resource.TestStep{
-			{
-				Config: testGoogleCloudBuildTrigger_filename(),
-			},
-			{
-				ResourceName:      "google_cloudbuild_trigger.filename_build_trigger",
-				ImportState:       true,
-				ImportStateVerify: true,
-			},
-		},
-	})
-
-}
-
 func testGoogleCloudBuildTrigger_basic() string {
 	return fmt.Sprintf(`
 resource "google_cloudbuild_trigger" "build_trigger" {
@@ -115,20 +94,3 @@ resource "google_cloudbuild_trigger" "build_trigger" {
 }
   `)
 }
-
-func testGoogleCloudBuildTrigger_filename() string {
-	return fmt.Sprintf(`
-resource "google_cloudbuild_trigger" "filename_build_trigger" {
-  description = "acceptance test build trigger"
-  trigger_template {
-    branch_name = "master"
-    repo_name   = "some-repo"
-  }
-  substitutions = {
-    _FOO = "bar"
-    _BAZ = "qux"
-  }
-  filename = "cloudbuild.yaml"
-}
-  `)
-}

google/resource_compute_address_test.go

@@ -8,26 +8,6 @@ import (
 	"github.com/hashicorp/terraform/helper/resource"
 )
 
-func TestAccComputeAddress_basic(t *testing.T) {
-	t.Parallel()
-
-	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckComputeAddressDestroy,
-		Steps: []resource.TestStep{
-			{
-				Config: testAccComputeAddress_basic(acctest.RandString(10)),
-			},
-			{
-				ResourceName:      "google_compute_address.foobar",
-				ImportState:       true,
-				ImportStateVerify: true,
-			},
-		},
-	})
-}
-
 func TestAccComputeAddress_networkTier(t *testing.T) {
 	t.Parallel()
 
@@ -78,13 +58,6 @@ func TestAccComputeAddress_internal(t *testing.T) {
 	})
 }
 
-func testAccComputeAddress_basic(i string) string {
-	return fmt.Sprintf(`
-resource "google_compute_address" "foobar" {
-	name = "address-test-%s"
-}`, i)
-}
-
 func testAccComputeAddress_internal(i string) string {
 	return fmt.Sprintf(`
 resource "google_compute_address" "internal" {

google/resource_compute_autoscaler_test.go

@@ -11,38 +11,6 @@ import (
 	"google.golang.org/api/compute/v1"
 )
 
-func TestAccComputeAutoscaler_basic(t *testing.T) {
-	t.Parallel()
-
-	var ascaler compute.Autoscaler
-
-	var it_name = fmt.Sprintf("autoscaler-test-%s", acctest.RandString(10))
-	var tp_name = fmt.Sprintf("autoscaler-test-%s", acctest.RandString(10))
-	var igm_name = fmt.Sprintf("autoscaler-test-%s", acctest.RandString(10))
-	var autoscaler_name = fmt.Sprintf("autoscaler-test-%s", acctest.RandString(10))
-
-	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckComputeAutoscalerDestroy,
-		Steps: []resource.TestStep{
-			{
-				Config: testAccComputeAutoscaler_basic(it_name, tp_name, igm_name, autoscaler_name),
-				Check: resource.ComposeTestCheckFunc(
-					testAccCheckComputeAutoscalerExists(
-						"google_compute_autoscaler.foobar", &ascaler),
-				),
-			},
-
-			{
-				ResourceName:      "google_compute_autoscaler.foobar",
-				ImportState:       true,
-				ImportStateVerify: true,
-			},
-		},
-	})
-}
-
 func TestAccComputeAutoscaler_update(t *testing.T) {
 	t.Parallel()
 

google/resource_compute_backend_bucket_test.go

@@ -10,38 +10,6 @@ import (
 	"google.golang.org/api/compute/v1"
 )
 
-func TestAccComputeBackendBucket_basic(t *testing.T) {
-	t.Parallel()
-
-	backendName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
-	storageName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
-	var svc compute.BackendBucket
-
-	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckComputeBackendBucketDestroy,
-		Steps: []resource.TestStep{
-			{
-				Config: testAccComputeBackendBucket_basic(backendName, storageName),
-				Check: resource.ComposeTestCheckFunc(
-					testAccCheckComputeBackendBucketExists(
-						"google_compute_backend_bucket.foobar", &svc),
-				),
-			},
-			{
-				ResourceName:      "google_compute_backend_bucket.foobar",
-				ImportState:       true,
-				ImportStateVerify: true,
-			},
-		},
-	})
-
-	if svc.BucketName != storageName {
-		t.Errorf("Expected BucketName to be %q, got %q", storageName, svc.BucketName)
-	}
-}
-
 func TestAccComputeBackendBucket_basicModified(t *testing.T) {
 	t.Parallel()
 

google/resource_compute_disk_test.go

@@ -205,35 +205,6 @@ func TestAccComputeDisk_imageDiffSuppressPublicVendorsFamilyNames(t *testing.T)
 	}
 }
 
-func TestAccComputeDisk_basic(t *testing.T) {
-	t.Parallel()
-
-	diskName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
-	var disk compute.Disk
-
-	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckComputeDiskDestroy,
-		Steps: []resource.TestStep{
-			{
-				Config: testAccComputeDisk_basic(diskName),
-				Check: resource.ComposeTestCheckFunc(
-					testAccCheckComputeDiskExists(
-						"google_compute_disk.foobar", getTestProjectFromEnv(), &disk),
-					testAccCheckComputeDiskHasLabel(&disk, "my-label", "my-label-value"),
-					testAccCheckComputeDiskHasLabelFingerprint(&disk, "google_compute_disk.foobar"),
-				),
-			},
-			{
-				ResourceName:      "google_compute_disk.foobar",
-				ImportState:       true,
-				ImportStateVerify: true,
-			},
-		},
-	})
-}
-
 func TestAccComputeDisk_timeout(t *testing.T) {
 	t.Parallel()
 

google/resource_compute_firewall_test.go

@@ -13,35 +13,6 @@ import (
 	"google.golang.org/api/compute/v1"
 )
 
-func TestAccComputeFirewall_basic(t *testing.T) {
-	t.Parallel()
-
-	var firewall compute.Firewall
-	networkName := fmt.Sprintf("firewall-test-%s", acctest.RandString(10))
-	firewallName := fmt.Sprintf("firewall-test-%s", acctest.RandString(10))
-
-	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckComputeFirewallDestroy,
-		Steps: []resource.TestStep{
-			{
-				Config: testAccComputeFirewall_basic(networkName, firewallName),
-				Check: resource.ComposeTestCheckFunc(
-					testAccCheckComputeFirewallExists(
-						"google_compute_firewall.foobar", &firewall),
-					testAccCheckComputeFirewallApiVersion(&firewall),
-				),
-			},
-			{
-				ResourceName:      "google_compute_firewall.foobar",
-				ImportState:       true,
-				ImportStateVerify: true,
-			},
-		},
-	})
-}
-
 func TestAccComputeFirewall_update(t *testing.T) {
 	t.Parallel()
 

google/resource_compute_global_address_test.go

@@ -11,35 +11,6 @@ import (
 	"google.golang.org/api/compute/v1"
 )
 
-func TestAccComputeGlobalAddress_basic(t *testing.T) {
-	t.Parallel()
-
-	var addr compute.Address
-
-	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckComputeGlobalAddressDestroy,
-		Steps: []resource.TestStep{
-			{
-				Config: testAccComputeGlobalAddress_basic(),
-				Check: resource.ComposeTestCheckFunc(
-					testAccCheckComputeGlobalAddressExists(
-						"google_compute_global_address.foobar", &addr),
-
-					// implicitly IPV4 - if we don't send an ip_version, we don't get one back.
-					testAccCheckComputeGlobalAddressIpVersion("google_compute_global_address.foobar", ""),
-				),
-			},
-			{
-				ResourceName:      "google_compute_global_address.foobar",
-				ImportState:       true,
-				ImportStateVerify: true,
-			},
-		},
-	})
-}
-
 func TestAccComputeGlobalAddress_ipv6(t *testing.T) {
 	t.Parallel()
 
@@ -122,14 +93,6 @@ func testAccCheckComputeGlobalAddressIpVersion(n, version string) resource.TestC
 	}
 }
 
-func testAccComputeGlobalAddress_basic() string {
-	return fmt.Sprintf(`
-resource "google_compute_global_address" "foobar" {
-	name = "address-test-%s"
-	description = "Created for Terraform acceptance testing"
-}`, acctest.RandString(10))
-}
-
 func testAccComputeGlobalAddress_ipv6() string {
 	return fmt.Sprintf(`
 resource "google_compute_global_address" "foobar" {

google/resource_compute_http_health_check_test.go

@@ -10,38 +10,6 @@ import (
 	"google.golang.org/api/compute/v1"
 )
 
-func TestAccComputeHttpHealthCheck_basic(t *testing.T) {
-	t.Parallel()
-
-	var healthCheck compute.HttpHealthCheck
-
-	hhckName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
-
-	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckComputeHttpHealthCheckDestroy,
-		Steps: []resource.TestStep{
-			{
-				Config: testAccComputeHttpHealthCheck_basic(hhckName),
-				Check: resource.ComposeTestCheckFunc(
-					testAccCheckComputeHttpHealthCheckExists(
-						"google_compute_http_health_check.foobar", &healthCheck),
-					testAccCheckComputeHttpHealthCheckRequestPath(
-						"/health_check", &healthCheck),
-					testAccCheckComputeHttpHealthCheckThresholds(
-						3, 3, &healthCheck),
-				),
-			},
-			{
-				ResourceName:      "google_compute_http_health_check.foobar",
-				ImportState:       true,
-				ImportStateVerify: true,
-			},
-		},
-	})
-}
-
 func TestAccComputeHttpHealthCheck_update(t *testing.T) {
 	t.Parallel()
 
@@ -133,22 +101,6 @@ func testAccCheckComputeHttpHealthCheckThresholds(healthy, unhealthy int64, heal
 	}
 }
 
-func testAccComputeHttpHealthCheck_basic(hhckName string) string {
-	return fmt.Sprintf(`
-resource "google_compute_http_health_check" "foobar" {
-	name = "%s"
-	check_interval_sec = 3
-	description = "Resource created for Terraform acceptance testing"
-	healthy_threshold = 3
-	host = "foobar"
-	port = "80"
-	request_path = "/health_check"
-	timeout_sec = 2
-	unhealthy_threshold = 3
-}
-`, hhckName)
-}
-
 func testAccComputeHttpHealthCheck_update1(hhckName string) string {
 	return fmt.Sprintf(`
 resource "google_compute_http_health_check" "foobar" {