location attribute incorrectly marked as optional for cross-cloud interconnect (#13665) (#22480)

[upstream:b5195e9aebd183d32970fd8e87289a050ec91b97]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/13665.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+compute: marked `location` field as required in `google_compute_interconnect` resource
+```

google/services/compute/resource_compute_interconnect.go

@@ -82,6 +82,14 @@ bundle, not the speed of the entire bundle. Can take one of the following values
   - LINK_TYPE_ETHERNET_10G_LR: A 10G Ethernet with LR optics.
   - LINK_TYPE_ETHERNET_100G_LR: A 100G Ethernet with LR optics.
   - LINK_TYPE_ETHERNET_400G_LR4: A 400G Ethernet with LR4 optics Possible values: ["LINK_TYPE_ETHERNET_10G_LR", "LINK_TYPE_ETHERNET_100G_LR", "LINK_TYPE_ETHERNET_400G_LR4"]`,
+			},
+			"location": {
+				Type:             schema.TypeString,
+				Required:         true,
+				ForceNew:         true,
+				DiffSuppressFunc: tpgresource.CompareSelfLinkOrResourceName,
+				Description: `URL of the InterconnectLocation object that represents where this connection is to be provisioned.
+Specifies the location inside Google's Networks.`,
 			},
 			"name": {
 				Type:         schema.TypeString,
@@ -132,14 +140,6 @@ method. Each label key/value pair must comply with RFC1035. Label values may be
 Please refer to the field 'effective_labels' for all of the labels present on the resource.`,
 				Elem: &schema.Schema{Type: schema.TypeString},
 			},
-			"location": {
-				Type:             schema.TypeString,
-				Optional:         true,
-				ForceNew:         true,
-				DiffSuppressFunc: tpgresource.CompareSelfLinkOrResourceName,
-				Description: `URL of the InterconnectLocation object that represents where this connection is to be provisioned.
-Specifies the location inside Google's Networks, should not be passed in case of cross-cloud interconnect.`,
-			},
 			"macsec": {
 				Type:     schema.TypeList,
 				Optional: true,

website/docs/r/compute_interconnect.html.markdown

@@ -60,6 +60,11 @@ The following arguments are supported:
   character must be a lowercase letter, and all following characters must be a dash,
   lowercase letter, or digit, except the last character, which cannot be a dash.
 
+* `location` -
+  (Required)
+  URL of the InterconnectLocation object that represents where this connection is to be provisioned.
+  Specifies the location inside Google's Networks.
+
 * `link_type` -
   (Required)
   Type of link requested. Note that this field indicates the speed of each of the links in the
@@ -89,11 +94,6 @@ The following arguments are supported:
   (Optional)
   An optional description of this resource. Provide this property when you create the resource.
 
-* `location` -
-  (Optional)
-  URL of the InterconnectLocation object that represents where this connection is to be provisioned.
-  Specifies the location inside Google's Networks, should not be passed in case of cross-cloud interconnect.
-
 * `admin_enabled` -
   (Optional)
   Administrative status of the interconnect. When this is set to true, the Interconnect is