inspect_template_name changed from required to optional (#8036) (#14845)

* inspect_template_name changed to optional from required

* changed random string func and config in test

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/8036.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+dlp: changed `inspect_template_name` field from required to optional in `google_data_loss_prevention_job_trigger` resource
+```

google/resource_data_loss_prevention_job_trigger_test.go

@@ -435,6 +435,50 @@ func TestAccDataLossPreventionJobTrigger_dlpJobTriggerActionsOptionalExample(t *
 	})
 }
 
+func TestAccDataLossPreventionJobTrigger_dlpJobTriggerInspectOptionalExample(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"project":       acctest.GetTestProjectFromEnv(),
+		"random_suffix": RandString(t, 10),
+	}
+
+	VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckDataLossPreventionJobTriggerDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccDataLossPreventionJobTrigger_dlpJobTriggerInspectOptionalBasic(context),
+			},
+			{
+				ResourceName:            "google_data_loss_prevention_job_trigger.basic",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"parent"},
+			},
+			{
+				Config: testAccDataLossPreventionJobTrigger_dlpJobTriggerBasic(context),
+			},
+			{
+				ResourceName:            "google_data_loss_prevention_job_trigger.basic",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"parent"},
+			},
+			{
+				Config: testAccDataLossPreventionJobTrigger_dlpJobTriggerInspectOptionalBasic(context),
+			},
+			{
+				ResourceName:            "google_data_loss_prevention_job_trigger.basic",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"parent"},
+			},
+		},
+	})
+}
+
 func testAccDataLossPreventionJobTrigger_dlpJobTriggerBasic(context map[string]interface{}) string {
 	return Nprintf(`
 resource "google_data_loss_prevention_job_trigger" "basic" {
@@ -2273,3 +2317,39 @@ resource "google_data_loss_prevention_job_trigger" "basic" {
 }
 `, context)
 }
+
+func testAccDataLossPreventionJobTrigger_dlpJobTriggerInspectOptionalBasic(context map[string]interface{}) string {
+	return Nprintf(`
+resource "google_data_loss_prevention_job_trigger" "basic" {
+	parent = "projects/%{project}"
+	description = "Starting description"
+	display_name = "display"
+
+	triggers {
+		schedule {
+			recurrence_period_duration = "86400s"
+		}
+	}
+
+	inspect_job {
+		actions {
+			save_findings {
+				output_config {
+					table {
+						project_id = "project"
+						dataset_id = "dataset123"
+					}
+				}
+			}
+		}
+		storage_config {
+			cloud_storage_options {
+				file_set {
+					url = "gs://mybucket/directory/"
+				}
+			}
+		}
+	}
+}
+`, context)
+}

google/services/datalossprevention/resource_data_loss_prevention_job_trigger.go

@@ -112,11 +112,6 @@ A duration in seconds with up to nine fractional digits, terminated by 's'. Exam
 				MaxItems:    1,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
-						"inspect_template_name": {
-							Type:        schema.TypeString,
-							Required:    true,
-							Description: `The name of the template to run when this job is triggered.`,
-						},
 						"storage_config": {
 							Type:        schema.TypeList,
 							Required:    true,
@@ -1275,6 +1270,11 @@ at https://cloud.google.com/dlp/docs/infotypes-reference when specifying a built
 								},
 							},
 						},
+						"inspect_template_name": {
+							Type:        schema.TypeString,
+							Optional:    true,
+							Description: `The name of the template to run when this job is triggered.`,
+						},
 					},
 				},
 			},

website/docs/r/data_loss_prevention_job_trigger.html.markdown

@@ -496,7 +496,7 @@ The following arguments are supported:
 <a name="nested_inspect_job"></a>The `inspect_job` block supports:
 
 * `inspect_template_name` -
-  (Required)
+  (Optional)
   The name of the template to run when this job is triggered.
 
 * `inspect_config` -