Make the destination.cloud_function field on google_eventarc_trigger output only, update field description in docs (#9820) (#17052)

* Make the `destination.cloud_function` field on google_eventarc_trigger output only

* Update description of `destination.cloud_function` field on google_eventarc_trigger

* Add beta overrides to `google_eventarc_trigger` resource
[upstream:ad8f182ac10f8c3537ef793f6f99b1053d153d7f]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/9820.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+eventarc: made the `destination.cloud_function` field on `google_eventarc_trigger` an output. Previously when users attempted to set this in their configuration it caused an API error.
+```

google/services/eventarc/resource_eventarc_trigger.go

@@ -184,13 +184,6 @@ func ResourceEventarcTrigger() *schema.Resource {
 func EventarcTriggerDestinationSchema() *schema.Resource {
 	return &schema.Resource{
 		Schema: map[string]*schema.Schema{
-			"cloud_function": {
-				Type:             schema.TypeString,
-				Optional:         true,
-				DiffSuppressFunc: tpgresource.CompareSelfLinkOrResourceName,
-				Description:      "[WARNING] Configuring a Cloud Function in Trigger is not supported as of today. The Cloud Function resource name. Format: projects/{project}/locations/{location}/functions/{function}",
-			},
-
 			"cloud_run_service": {
 				Type:        schema.TypeList,
 				Optional:    true,
@@ -213,6 +206,12 @@ func EventarcTriggerDestinationSchema() *schema.Resource {
 				DiffSuppressFunc: tpgresource.CompareSelfLinkOrResourceName,
 				Description:      "The resource name of the Workflow whose Executions are triggered by the events. The Workflow resource should be deployed in the same project as the trigger. Format: `projects/{project}/locations/{location}/workflows/{workflow}`",
 			},
+
+			"cloud_function": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "The Cloud Function resource name. Only Cloud Functions V2 is supported. Format projects/{project}/locations/{location}/functions/{function} This is a read-only field. [WARNING] Creating Cloud Functions V2 triggers is only supported via the Cloud Functions product. An error will be returned if the user sets this value.",
+			},
 		},
 	}
 }
@@ -620,7 +619,6 @@ func expandEventarcTriggerDestination(o interface{}) *eventarc.TriggerDestinatio
 	}
 	obj := objArr[0].(map[string]interface{})
 	return &eventarc.TriggerDestination{
-		CloudFunction:   dcl.String(obj["cloud_function"].(string)),
 		CloudRunService: expandEventarcTriggerDestinationCloudRunService(obj["cloud_run_service"]),
 		Gke:             expandEventarcTriggerDestinationGke(obj["gke"]),
 		Workflow:        dcl.String(obj["workflow"].(string)),
@@ -632,10 +630,10 @@ func flattenEventarcTriggerDestination(obj *eventarc.TriggerDestination) interfa
 		return nil
 	}
 	transformed := map[string]interface{}{
-		"cloud_function":    obj.CloudFunction,
 		"cloud_run_service": flattenEventarcTriggerDestinationCloudRunService(obj.CloudRunService),
 		"gke":               flattenEventarcTriggerDestinationGke(obj.Gke),
 		"workflow":          obj.Workflow,
+		"cloud_function":    obj.CloudFunction,
 	}
 
 	return []interface{}{transformed}

website/docs/r/eventarc_trigger.html.markdown

@@ -100,8 +100,7 @@ The following arguments are supported:
 The `destination` block supports:
 
 * `cloud_function` -
-  (Optional)
-  [WARNING] Configuring a Cloud Function in Trigger is not supported as of today. The Cloud Function resource name. Format: projects/{project}/locations/{location}/functions/{function}
+  The Cloud Function resource name. Only Cloud Functions V2 is supported. Format projects/{project}/locations/{location}/functions/{function} This is a read-only field. [WARNING] Creating Cloud Functions V2 triggers is only supported via the Cloud Functions product. An error will be returned if the user sets this value.
 
 * `cloud_run_service` -
   (Optional)