fix: cloud funcions gen2 enable taint on creation failure (#8545) (#15418)

modular-magician · Kristof Havasi · web-flow · commit 689dff2ede5d · 2023-08-07T09:56:09.000-07:00
Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
Co-authored-by: Kristof Havasi &lt;kristof.havasi@nearform.com&gt;
diff --git a/.changelog/8545.txt b/.changelog/8545.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+cloudfunctions2: fixed creation failure TF state inconsistency in `google_cloudfunctions2_function`
+```
diff --git a/google/services/cloudfunctions2/resource_cloudfunctions2_function.go b/google/services/cloudfunctions2/resource_cloudfunctions2_function.go
@@ -607,9 +607,6 @@ func resourceCloudfunctions2functionCreate(d *schema.ResourceData, meta interfac
 		config, res, &opRes, project, "Creating function", userAgent,
 		d.Timeout(schema.TimeoutCreate))
 	if err != nil {
-		// The resource didn't actually create
-		d.SetId("")
-
 		return fmt.Errorf("Error waiting to create function: %s", err)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+```release-note:bug
	`2`	+cloudfunctions2: fixed creation failure TF state inconsistency in `google_cloudfunctions2_function`
	`3`	+```
Original file line number	Diff line number	Diff line change
`@@ -607,9 +607,6 @@ func resourceCloudfunctions2functionCreate(d *schema.ResourceData, meta interfac`
`607`	`607`	`config, res, &opRes, project, "Creating function", userAgent,`
`608`	`608`	`d.Timeout(schema.TimeoutCreate))`
`609`	`609`	`if err != nil {`
`610`		`- // The resource didn't actually create`
`611`		`- d.SetId("")`
`612`		`-`
`613`	`610`	`return fmt.Errorf("Error waiting to create function: %s", err)`
`614`	`611`	`}`
`615`	`612`