Skip to content

Commit 6b0dbf5

Browse files
committed
check d.Set errors for complex values for container cluster
1 parent f8c3a10 commit 6b0dbf5

File tree

1 file changed

+23
-9
lines changed

1 file changed

+23
-9
lines changed

google/resource_container_cluster.go

+23-9
Original file line numberDiff line numberDiff line change
@@ -709,17 +709,25 @@ func resourceContainerClusterRead(d *schema.ResourceData, meta interface{}) erro
709709
}
710710

711711
d.Set("name", cluster.Name)
712-
d.Set("network_policy", flattenNetworkPolicy(cluster.NetworkPolicy))
712+
if err := d.Set("network_policy", flattenNetworkPolicy(cluster.NetworkPolicy)); err != nil {
713+
return err
714+
}
713715
d.Set("zone", cluster.Zone)
714716

715717
locations := schema.NewSet(schema.HashString, convertStringArrToInterface(cluster.Locations))
716718
locations.Remove(cluster.Zone) // Remove the original zone since we only store additional zones
717719
d.Set("additional_zones", locations)
718720

719721
d.Set("endpoint", cluster.Endpoint)
720-
d.Set("maintenance_policy", flattenMaintenancePolicy(cluster.MaintenancePolicy))
721-
d.Set("master_auth", flattenMasterAuth(cluster.MasterAuth))
722-
d.Set("master_authorized_networks_config", flattenMasterAuthorizedNetworksConfig(cluster.MasterAuthorizedNetworksConfig))
722+
if err := d.Set("maintenance_policy", flattenMaintenancePolicy(cluster.MaintenancePolicy)); err != nil {
723+
return err
724+
}
725+
if err := d.Set("master_auth", flattenMasterAuth(cluster.MasterAuth)); err != nil {
726+
return err
727+
}
728+
if err := d.Set("master_authorized_networks_config", flattenMasterAuthorizedNetworksConfig(cluster.MasterAuthorizedNetworksConfig)); err != nil {
729+
return err
730+
}
723731
d.Set("initial_node_count", cluster.InitialNodeCount)
724732
d.Set("master_version", cluster.CurrentMasterVersion)
725733
d.Set("node_version", cluster.CurrentNodeVersion)
@@ -735,22 +743,28 @@ func resourceContainerClusterRead(d *schema.ResourceData, meta interface{}) erro
735743
return err
736744
}
737745
d.Set("project", project)
738-
d.Set("addons_config", flattenClusterAddonsConfig(cluster.AddonsConfig))
746+
if err := d.Set("addons_config", flattenClusterAddonsConfig(cluster.AddonsConfig)); err != nil {
747+
748+
}
739749

740750
nps, err := flattenClusterNodePools(d, config, cluster.NodePools)
741751
if err != nil {
742752
return err
743753
}
744-
d.Set("node_pool", nps)
754+
if err := d.Set("node_pool", nps); err != nil {
755+
return err
756+
}
745757

746758
if err := d.Set("ip_allocation_policy", flattenIPAllocationPolicy(cluster.IpAllocationPolicy)); err != nil {
747759
return err
748760
}
749761

750-
if igUrls, err := getInstanceGroupUrlsFromManagerUrls(config, cluster.InstanceGroupUrls); err != nil {
762+
igUrls, err := getInstanceGroupUrlsFromManagerUrls(config, cluster.InstanceGroupUrls)
763+
if err != nil {
764+
return err
765+
}
766+
if err := d.Set("instance_group_urls", igUrls); err != nil {
751767
return err
752-
} else {
753-
d.Set("instance_group_urls", igUrls)
754768
}
755769

756770
if err := d.Set("pod_security_policy_config", flattenPodSecurityPolicyConfig(cluster.PodSecurityPolicyConfig)); err != nil {

0 commit comments

Comments
 (0)