feat: support encoding_format (#7966) (#14663)

* feat: support encodingFormat

* Update mmv1/products/privateca/CaPool.yaml



---------

Signed-off-by: Modular Magician <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

Author: modular-magician

.changelog/7966.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+privateca: added support for encoding_format on CaPool
+```

google/resource_privateca_ca_pool.go

@@ -573,6 +573,14 @@ in all issued Certificates. If this is false, CRLs will not be published and the
 be written in issued certificates. CRLs will expire 7 days from their creation. However, we will rebuild daily. CRLs are
 also rebuilt shortly after a certificate is revoked.`,
 						},
+						"encoding_format": {
+							Type:         schema.TypeString,
+							Optional:     true,
+							ValidateFunc: verify.ValidateEnum([]string{"PEM", "DER", ""}),
+							Description: `Specifies the encoding format of each CertificateAuthority's CA
+certificate and CRLs. If this is omitted, CA certificates and CRLs
+will be published in PEM. Possible values: ["PEM", "DER"]`,
+						},
 					},
 				},
 			},
@@ -1110,6 +1118,8 @@ func flattenPrivatecaCaPoolPublishingOptions(v interface{}, d *schema.ResourceDa
 		flattenPrivatecaCaPoolPublishingOptionsPublishCaCert(original["publishCaCert"], d, config)
 	transformed["publish_crl"] =
 		flattenPrivatecaCaPoolPublishingOptionsPublishCrl(original["publishCrl"], d, config)
+	transformed["encoding_format"] =
+		flattenPrivatecaCaPoolPublishingOptionsEncodingFormat(original["encodingFormat"], d, config)
 	return []interface{}{transformed}
 }
 func flattenPrivatecaCaPoolPublishingOptionsPublishCaCert(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
@@ -1120,6 +1130,10 @@ func flattenPrivatecaCaPoolPublishingOptionsPublishCrl(v interface{}, d *schema.
 	return v
 }
 
+func flattenPrivatecaCaPoolPublishingOptionsEncodingFormat(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	return v
+}
+
 func flattenPrivatecaCaPoolLabels(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
 	return v
 }
@@ -1472,6 +1486,13 @@ func expandPrivatecaCaPoolPublishingOptions(v interface{}, d tpgresource.Terrafo
 		transformed["publishCrl"] = transformedPublishCrl
 	}
 
+	transformedEncodingFormat, err := expandPrivatecaCaPoolPublishingOptionsEncodingFormat(original["encoding_format"], d, config)
+	if err != nil {
+		return nil, err
+	} else if val := reflect.ValueOf(transformedEncodingFormat); val.IsValid() && !tpgresource.IsEmptyValue(val) {
+		transformed["encodingFormat"] = transformedEncodingFormat
+	}
+
 	return transformed, nil
 }
 
@@ -1483,6 +1504,10 @@ func expandPrivatecaCaPoolPublishingOptionsPublishCrl(v interface{}, d tpgresour
 	return v, nil
 }
 
+func expandPrivatecaCaPoolPublishingOptionsEncodingFormat(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandPrivatecaCaPoolLabels(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (map[string]string, error) {
 	if v == nil {
 		return map[string]string{}, nil

google/resource_privateca_ca_pool_generated_test.go

@@ -103,6 +103,7 @@ resource "google_privateca_ca_pool" "default" {
   publishing_options {
     publish_ca_cert = false
     publish_crl = true
+    encoding_format = "PEM"
   }
   labels = {
     foo = "bar"

website/docs/r/privateca_ca_pool.html.markdown

@@ -63,6 +63,7 @@ resource "google_privateca_ca_pool" "default" {
   publishing_options {
     publish_ca_cert = false
     publish_crl = true
+    encoding_format = "PEM"
   }
   labels = {
     foo = "bar"
@@ -551,6 +552,13 @@ The following arguments are supported:
   be written in issued certificates. CRLs will expire 7 days from their creation. However, we will rebuild daily. CRLs are
   also rebuilt shortly after a certificate is revoked.
 
+* `encoding_format` -
+  (Optional)
+  Specifies the encoding format of each CertificateAuthority's CA
+  certificate and CRLs. If this is omitted, CA certificates and CRLs
+  will be published in PEM.
+  Possible values are: `PEM`, `DER`.
+
 ## Attributes Reference
 
 In addition to the arguments listed above, the following computed attributes are exported: