Skip to content

Commit 84b790e

Browse files
Breaking changes for Firebase apps deletion policy (#8458) (#15406)
Signed-off-by: Modular Magician <[email protected]>
1 parent a154a9e commit 84b790e

File tree

3 files changed

+5
-23
lines changed

3 files changed

+5
-23
lines changed

.changelog/8458.txt

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:breaking-change
2+
firebase: changed `deletion_policy` default to `DELETE` for `google_firebase_web_app`.
3+
```

website/docs/r/firebase_hosting_site.html.markdown

-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ resource "google_firebase_web_app" "default" {
4848
provider = google-beta
4949
project = "my-project-name"
5050
display_name = "Test web app for Firebase Hosting"
51-
deletion_policy = "DELETE"
5251
}
5352
5453
resource "google_firebase_hosting_site" "full" {

website/docs/r/firebase_web_app.html.markdown

+2-22
Original file line numberDiff line numberDiff line change
@@ -34,30 +34,10 @@ To get more information about WebApp, see:
3434

3535

3636
```hcl
37-
resource "google_project" "default" {
38-
provider = google-beta
39-
40-
project_id = "my-project"
41-
name = "my-project"
42-
org_id = "123456789"
43-
44-
labels = {
45-
"firebase" = "enabled"
46-
}
47-
}
48-
49-
resource "google_firebase_project" "default" {
50-
provider = google-beta
51-
project = google_project.default.project_id
52-
}
53-
5437
resource "google_firebase_web_app" "basic" {
5538
provider = google-beta
56-
project = google_project.default.project_id
39+
project = "my-project-name"
5740
display_name = "Display Name Basic"
58-
deletion_policy = "DELETE"
59-
60-
depends_on = [google_firebase_project.default]
6141
}
6242
6343
data "google_firebase_web_app_config" "basic" {
@@ -106,7 +86,7 @@ The following arguments are supported:
10686

10787
* `deletion_policy` - (Optional) Set to `ABANDON` to allow the WebApp to be untracked from terraform state
10888
rather than deleted upon `terraform destroy`. This is useful becaue the WebApp may be
109-
serving traffic. Set to `DELETE` to delete the WebApp. Default to `ABANDON`
89+
serving traffic. Set to `DELETE` to delete the WebApp. Default to `DELETE`
11090

11191

11292
## Attributes Reference

0 commit comments

Comments
 (0)